From 6c73999f494f2636f23f219d3d510017ef303b40 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 5 Oct 2026 06:20:44 +0000 Subject: [PATCH] ci: never fail test-with-coverage on a Codecov upload error The upload step already sets fail_ci_if_error: false, but a TLS handshake failure inside codecov-action itself throws before the uploader runs and still failed the job (EPROTO, SSL alert 40, on #1327 and #1328) after every test had passed. continue-on-error makes the step non-blocking as intended; test failures still fail the cargo llvm-cov step above. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg --- .github/workflows/rust-test.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/rust-test.yml b/.github/workflows/rust-test.yml index 23cde336c..cf08afe27 100644 --- a/.github/workflows/rust-test.yml +++ b/.github/workflows/rust-test.yml @@ -536,6 +536,11 @@ jobs: cargo llvm-cov --manifest-path crates/lance-graph/Cargo.toml --lib --lcov --output-path lcov.info - name: Upload coverage to Codecov uses: codecov/codecov-action@v4 + # `fail_ci_if_error: false` only covers errors the uploader reports. A + # TLS failure inside the action itself (seen as `EPROTO … SSL alert + # number 40` on #1327 and #1328) throws before the uploader runs and + # failed the job anyway. Test failures surface in the step above. + continue-on-error: true with: files: lcov.info flags: rust-unittests