From ad2a6959eb98673d2488bed82c99eccf46c5ff9b Mon Sep 17 00:00:00 2001 From: Michael Burr Date: Thu, 5 Nov 2026 22:47:40 +0000 Subject: [PATCH 01/24] feat(frontend): warm-ink UI polish overhaul (round 1) --- e2e/tests/app.spec.ts | 2 +- e2e/tests/avatar-upload.spec.ts | 19 +- e2e/tests/demo.spec.ts | 5 +- e2e/tests/file-settings.spec.ts | 4 +- e2e/tests/invites.spec.ts | 2 +- e2e/tests/limited-permissions.spec.ts | 6 +- e2e/tests/orgs.spec.ts | 2 +- e2e/tests/profile-card.spec.ts | 4 +- packages/frontend/index.html | 6 +- packages/frontend/src/components/AuthForm.tsx | 61 +++- .../frontend/src/components/CodeBlock.tsx | 10 +- .../frontend/src/components/DocOutline.tsx | 50 +++ .../src/components/ExcalidrawCanvas.tsx | 94 ++++- .../src/components/ExportPdfDialog.tsx | 17 +- .../src/components/FileManager.test.tsx | 32 ++ .../frontend/src/components/FileManager.tsx | 320 +++++++++-------- .../frontend/src/components/GraphView.tsx | 71 +++- .../frontend/src/components/HistorySheet.tsx | 7 +- .../src/components/LinkedDocsPanel.tsx | 6 +- .../src/components/MermaidDiagram.tsx | 8 +- .../frontend/src/components/RecycleBin.tsx | 17 +- .../src/components/ReportSiteDialog.tsx | 2 +- .../frontend/src/components/SearchPalette.tsx | 9 +- .../frontend/src/components/SiteFooter.tsx | 33 +- .../src/components/UserProfileCard.tsx | 14 +- .../src/components/settings/SettingsShell.tsx | 46 ++- .../src/components/ui/alert-dialog.tsx | 4 +- .../frontend/src/components/ui/avatar.tsx | 4 +- .../frontend/src/components/ui/button.tsx | 8 +- .../frontend/src/components/ui/command.tsx | 10 +- .../src/components/ui/context-menu.tsx | 12 +- .../frontend/src/components/ui/dialog.tsx | 10 +- .../src/components/ui/dropdown-menu.tsx | 12 +- packages/frontend/src/components/ui/input.tsx | 2 +- .../frontend/src/components/ui/popover.tsx | 2 +- .../src/components/ui/resizable-table.tsx | 42 ++- .../frontend/src/components/ui/select.tsx | 6 +- packages/frontend/src/components/ui/sheet.tsx | 6 +- .../frontend/src/components/ui/textarea.tsx | 2 +- .../src/components/wysiwyg/WysiwygEditor.tsx | 6 +- .../src/components/wysiwyg/WysiwygToolbar.tsx | 18 +- .../wysiwyg/decorations/block/frontmatter.ts | 18 +- .../src/components/wysiwyg/styles.css | 79 +++-- .../wysiwyg/widgets/CodeFenceWidget.ts | 4 +- .../frontend/src/hooks/useActiveHeading.ts | 58 +++ packages/frontend/src/index.css | 117 ++++--- packages/frontend/src/layouts/DocsLayout.tsx | 128 ++++--- packages/frontend/src/lib/fileKind.ts | 22 ++ packages/frontend/src/lib/fonts.ts | 6 +- packages/frontend/src/lib/roleStyles.ts | 10 + packages/frontend/src/lib/shiki.ts | 2 +- packages/frontend/src/lib/theme.ts | 7 +- .../frontend/src/pages/AcceptInvitePage.tsx | 37 +- .../src/pages/AcknowledgementsPage.tsx | 23 +- .../src/pages/CheckEmailPage.test.tsx | 2 + .../frontend/src/pages/CheckEmailPage.tsx | 31 +- packages/frontend/src/pages/DashboardPage.tsx | 170 +++++---- packages/frontend/src/pages/DocPage.tsx | 104 +++--- packages/frontend/src/pages/FilePage.tsx | 131 +++---- .../frontend/src/pages/GraphPage.test.tsx | 6 +- packages/frontend/src/pages/GraphPage.tsx | 15 +- packages/frontend/src/pages/LandingPage.css | 44 ++- packages/frontend/src/pages/LandingPage.tsx | 31 +- packages/frontend/src/pages/LoginPage.tsx | 2 +- packages/frontend/src/pages/NotFound404.css | 103 ++---- packages/frontend/src/pages/NotFound404.tsx | 29 +- .../frontend/src/pages/NotFoundPage.test.tsx | 6 + packages/frontend/src/pages/NotFoundPage.tsx | 3 +- .../frontend/src/pages/OAuthAuthorizePage.tsx | 10 +- packages/frontend/src/pages/OrgPage.test.tsx | 2 +- packages/frontend/src/pages/OrgPage.tsx | 59 ++-- .../frontend/src/pages/OrgSettingsPage.tsx | 51 +-- .../frontend/src/pages/PendingInvitesPage.tsx | 98 +++--- .../frontend/src/pages/PrivacyPage.test.tsx | 6 +- packages/frontend/src/pages/PrivacyPage.tsx | 35 +- packages/frontend/src/pages/PublicDocPage.tsx | 213 ++++++----- packages/frontend/src/pages/RegisterPage.tsx | 4 +- .../frontend/src/pages/SiteSettingsPage.tsx | 331 +++++++++++------- packages/frontend/src/pages/TagPage.test.tsx | 16 +- packages/frontend/src/pages/TagPage.tsx | 85 +++-- .../frontend/src/pages/TermsPage.test.tsx | 2 +- packages/frontend/src/pages/TermsPage.tsx | 37 +- .../frontend/src/pages/UserProfilePage.tsx | 328 ++++++++++++++++- .../frontend/src/pages/UserSettingsPage.tsx | 164 ++++----- .../frontend/src/pages/VerifyEmailPage.tsx | 20 +- packages/frontend/vite.config.ts | 4 +- 86 files changed, 2336 insertions(+), 1308 deletions(-) create mode 100644 packages/frontend/src/components/DocOutline.tsx create mode 100644 packages/frontend/src/hooks/useActiveHeading.ts create mode 100644 packages/frontend/src/lib/roleStyles.ts diff --git a/e2e/tests/app.spec.ts b/e2e/tests/app.spec.ts index 1dae9cd..b058729 100644 --- a/e2e/tests/app.spec.ts +++ b/e2e/tests/app.spec.ts @@ -120,7 +120,7 @@ test("registers a new account", async () => { test("shows the dashboard with no projects", async () => { await page.goto("/dashboard"); - await expect(page.getByText("Your Sites")).toBeVisible(); + await expect(page.getByText("Your sites")).toBeVisible(); await expect(page.getByText("New site")).toBeVisible(); }); diff --git a/e2e/tests/avatar-upload.spec.ts b/e2e/tests/avatar-upload.spec.ts index 8bc7984..81aef3c 100644 --- a/e2e/tests/avatar-upload.spec.ts +++ b/e2e/tests/avatar-upload.spec.ts @@ -199,15 +199,16 @@ test("a light request falls back to the dark variant when no light exists", asyn test("uploading with the toggle on Light stores an independent light variant", async () => { await page.goto("/settings"); - // The sun/moon toggle sits directly below the avatar. It starts on "Dark" - // (Moon); clicking it switches the slot that Upload/Remove targets to Light. - // Locate by title, not accessible name - the theme picker on the same page - // also has buttons named "Dark"/"Light". - const toggle = page.getByTitle("Switch which avatar variant you view and edit (dark vs light backgrounds)"); - await expect(toggle).toBeVisible({ timeout: 5000 }); - await expect(toggle).toHaveText(/Dark/); - await toggle.click(); - await expect(toggle).toHaveText(/Light/); + // The "Avatar for background" segmented control sits directly below the + // avatar. It starts on Dark; picking Light switches the slot that + // Upload/Remove targets. Scope to the radiogroup - the theme picker on the + // same page also has buttons named "Dark"/"Light". + const variantGroup = page.getByRole("radiogroup", { name: "Avatar for background" }); + await expect(variantGroup).toBeVisible({ timeout: 5000 }); + await expect(variantGroup.getByRole("radio", { name: "Dark" })).toHaveAttribute("aria-checked", "true"); + const lightOption = variantGroup.getByRole("radio", { name: "Light" }); + await lightOption.click(); + await expect(lightOption).toHaveAttribute("aria-checked", "true"); const fileInput = page.locator('input[type="file"][accept*="image/gif"]'); await fileInput.setInputFiles({ diff --git a/e2e/tests/demo.spec.ts b/e2e/tests/demo.spec.ts index 14e3081..30a9b9d 100644 --- a/e2e/tests/demo.spec.ts +++ b/e2e/tests/demo.spec.ts @@ -143,7 +143,7 @@ test.describe("demo sandbox", () => { // Client-side navigation only from here: a full reload reseeds the demo store. // The bin is a section of Site Settings. - await page.getByTitle("Site Settings").click(); + await page.getByTitle("Site settings").click(); await expect(page.getByRole("heading", { name: "Recycle bin" })).toBeVisible(); await expect(page.getByText("Guides", { exact: true })).toBeVisible(); await page.getByRole("button", { name: "Restore Guides" }).click(); @@ -172,7 +172,8 @@ test.describe("demo sandbox", () => { await page.getByRole("link", { name: /\/@demo-person$/ }).click(); await page.waitForURL("**/@demo-person"); await expect(page.getByRole("heading", { level: 1, name: "Demo User" })).toBeVisible(); - await expect(page.getByRole("dialog").getByText("@demo-person", { exact: true })).toBeVisible(); + // Opened directly (no background page), the profile renders as a full page. + await expect(page.getByText("@demo-person", { exact: true })).toBeVisible(); await page.goBack(); await page.getByRole("switch", { name: "Profile link" }).click(); diff --git a/e2e/tests/file-settings.spec.ts b/e2e/tests/file-settings.spec.ts index fed08f0..6c82754 100644 --- a/e2e/tests/file-settings.spec.ts +++ b/e2e/tests/file-settings.spec.ts @@ -73,12 +73,12 @@ async function putDoc(p: Page, id: string, title: string, content: string) { async function openDocSettings(p: Page) { await p.getByRole("button", { name: "Document settings" }).click(); - await expect(p.getByRole("dialog", { name: "Document Settings" })).toBeVisible({ timeout: 5000 }); + await expect(p.getByRole("dialog", { name: "Document settings" })).toBeVisible({ timeout: 5000 }); } async function closeDocSettings(p: Page) { await p.keyboard.press("Escape"); - await expect(p.getByRole("dialog", { name: "Document Settings" })).not.toBeVisible({ timeout: 5000 }); + await expect(p.getByRole("dialog", { name: "Document settings" })).not.toBeVisible({ timeout: 5000 }); } test.describe.configure({ mode: "serial" }); diff --git a/e2e/tests/invites.spec.ts b/e2e/tests/invites.spec.ts index a68ad5d..6dfe2b6 100644 --- a/e2e/tests/invites.spec.ts +++ b/e2e/tests/invites.spec.ts @@ -177,7 +177,7 @@ test("email invite - invited member shows as pending in the members list", async test("email invite - invitee sees the pending invite", async () => { await login(inviteePage, EMAIL_USER); await inviteePage.goto("/invites/pending"); - await expect(inviteePage.getByRole("heading", { name: "Pending Invites" })).toBeVisible({ timeout: 5000 }); + await expect(inviteePage.getByRole("heading", { name: "Pending invites" })).toBeVisible({ timeout: 5000 }); // The pending-invites fetch can get dropped by the local wrangler chain // under full-suite load - reload until the invite shows. await expect(async () => { diff --git a/e2e/tests/limited-permissions.spec.ts b/e2e/tests/limited-permissions.spec.ts index 52a502e..002f0e9 100644 --- a/e2e/tests/limited-permissions.spec.ts +++ b/e2e/tests/limited-permissions.spec.ts @@ -186,7 +186,7 @@ test("owner invites the second account with the Limited role", async () => { test("limited user accepts the invite", async () => { await login(limitedPage, LIMITED); await limitedPage.goto("/invites/pending"); - await expect(limitedPage.getByRole("heading", { name: "Pending Invites" })).toBeVisible({ timeout: 5000 }); + await expect(limitedPage.getByRole("heading", { name: "Pending invites" })).toBeVisible({ timeout: 5000 }); // The pending-invites fetch or the accept POST can get dropped by the local // wrangler chain under full-suite load - reload / re-click until it lands. await expect(async () => { @@ -240,7 +240,7 @@ test("owner grants the limited user VIEW access on the doc", async () => { await ownerPage.goto(`/projects/${projectId}/docs/${docId}`); await ownerPage.getByTitle("Manage limited viewer access").click(); - const dialog = ownerPage.getByRole("dialog", { name: "Document Access" }); + const dialog = ownerPage.getByRole("dialog", { name: "Document access" }); await expect(dialog).toBeVisible({ timeout: 5000 }); // Sanity: no shares yet - the empty-state copy is visible. @@ -286,7 +286,7 @@ test("owner uplifts the share from VIEW to EDIT", async () => { await ownerPage.goto(`/projects/${projectId}/docs/${docId}`); await ownerPage.getByTitle("Manage limited viewer access").click(); - const dialog = ownerPage.getByRole("dialog", { name: "Document Access" }); + const dialog = ownerPage.getByRole("dialog", { name: "Document access" }); await expect(dialog).toBeVisible({ timeout: 5000 }); // Single existing share row - its permission combobox is the only diff --git a/e2e/tests/orgs.spec.ts b/e2e/tests/orgs.spec.ts index 398de34..e98a568 100644 --- a/e2e/tests/orgs.spec.ts +++ b/e2e/tests/orgs.spec.ts @@ -166,7 +166,7 @@ test("owner invites a member to the org", async () => { test("member sees and accepts the org invite", async () => { await memberPage.goto("/invites/pending"); - await expect(memberPage.getByRole("heading", { name: "Pending Invites" })).toBeVisible({ timeout: 5000 }); + await expect(memberPage.getByRole("heading", { name: "Pending invites" })).toBeVisible({ timeout: 5000 }); // The pending-invites fetch or the accept POST can get dropped by the local // wrangler chain under full-suite load - reload / re-click until it lands. await expect(async () => { diff --git a/e2e/tests/profile-card.spec.ts b/e2e/tests/profile-card.spec.ts index 6258a19..a4105c6 100644 --- a/e2e/tests/profile-card.spec.ts +++ b/e2e/tests/profile-card.spec.ts @@ -124,8 +124,8 @@ test("registers, grants Ink, and writes a bio + timezone", async () => { test("public profile page /u/:userId shows the saved bio and member-since date", async () => { await page.goto(`/u/${userId}`); - // The public profile uses UserProfileCard with forceViewAsPublic, so the - // dialog opens automatically and renders the public sections. + // Opened directly, /u/:userId renders the full profile page (the card + // modal is only used when opened over another in-app page). await expect(page.getByText(NAME).first()).toBeVisible({ timeout: 10000 }); await expect(page.getByText("Tester from the e2e suite.")).toBeVisible({ timeout: 5000 }); await expect(page.getByText(/Member since/)).toBeVisible({ timeout: 5000 }); diff --git a/packages/frontend/index.html b/packages/frontend/index.html index 3b34b68..5db4475 100644 --- a/packages/frontend/index.html +++ b/packages/frontend/index.html @@ -1,5 +1,5 @@ - + @@ -16,12 +16,12 @@ - + - + diff --git a/packages/frontend/src/components/AuthForm.tsx b/packages/frontend/src/components/AuthForm.tsx index ffdd79f..9f6084b 100644 --- a/packages/frontend/src/components/AuthForm.tsx +++ b/packages/frontend/src/components/AuthForm.tsx @@ -38,25 +38,30 @@ export function AuthForm({ devPanel, }: AuthFormProps) { return ( -
-
+ + {devPanel} +
+ )}>
{wordmark ? ( - // A wordmark logo is present: render it, and emit the page - // heading visually-hidden to keep the existing design while - // still giving every AuthForm screen a top-level

. + // Wordmark screens: a compact brand mark (links home) and the + // step itself ("Sign in to your account") as the visible

, + // so the form column reads as a form, not a logo with fields. <> - {wordmark} -

{title}

+ + {wordmark} + +

{subtitle}

) : ( <>
{header} @@ -78,16 +83,40 @@ export function AuthForm({

{footer}

- {devPanel && ( -
- {devPanel} -
- )} + + ); +} + +/** Split auth layout: form rail on the left, brand panel on wide screens. */ +export function AuthShell({ children, aside }: { children: React.ReactNode; aside?: React.ReactNode }) { + return ( +
+
+ {children} + {aside}
+ +
+ ); +} -