From 99bbce965098dda57cc8be149e80519ab89beef0 Mon Sep 17 00:00:00 2001 From: Benjamin Michaelis Date: Thu, 5 Nov 2026 21:06:27 -0800 Subject: [PATCH] test: remove unnecessary null-forgiving operators after IsNotNull asserts --- EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs | 6 +++--- EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs b/EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs index 0eb417bd..302a8685 100644 --- a/EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs +++ b/EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs @@ -45,7 +45,7 @@ public async Task CreateTokenAsync_WithoutExpiry_UsesSixMonthDefault() (_, var entity) = await tokenService.CreateTokenAsync(userId, "default-expiry"); await Assert.That(entity.ExpiresAt).IsNotNull(); - await Assert.That(entity.ExpiresAt!.Value) + await Assert.That(entity.ExpiresAt.Value) .IsEqualTo(McpApiTokenService.GetDefaultExpirationUtc(entity.CreatedAt)); } @@ -58,7 +58,7 @@ public async Task CreateTokenAsync_WithExpiryWithinSixMonths_UsesRequestedExpiry (_, var entity) = await tokenService.CreateTokenAsync(userId, "custom-expiry", requestedExpiry); await Assert.That(entity.ExpiresAt).IsNotNull(); - await Assert.That(entity.ExpiresAt!.Value).IsEqualTo(requestedExpiry); + await Assert.That(entity.ExpiresAt.Value).IsEqualTo(requestedExpiry); } [Test] @@ -83,7 +83,7 @@ public async Task CreateTokenAsync_WithExplicitCreatedAt_UsesReferenceTimeForDef await Assert.That(entity.CreatedAt).IsEqualTo(createdAtUtc); await Assert.That(entity.ExpiresAt).IsNotNull(); - await Assert.That(entity.ExpiresAt!.Value) + await Assert.That(entity.ExpiresAt.Value) .IsEqualTo(McpApiTokenService.GetDefaultExpirationUtc(createdAtUtc)); } diff --git a/EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs b/EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs index 891dbe53..d56c1c3d 100644 --- a/EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs +++ b/EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs @@ -107,7 +107,7 @@ public async Task ValidateAsync_SendsCorrectKAnonymityRequest() await validator.ValidateAsync(manager, new IdentityUser("testuser"), "password"); await Assert.That(capturedRequest).IsNotNull(); - await Assert.That(capturedRequest!.RequestUri!.PathAndQuery).IsEqualTo("/range/5BAA6"); + await Assert.That(capturedRequest.RequestUri!.PathAndQuery).IsEqualTo("/range/5BAA6"); await Assert.That(capturedRequest.Headers.Contains("Add-Padding")).IsTrue(); await Assert.That(capturedRequest.Headers.GetValues("Add-Padding").Single()).IsEqualTo("true"); }