From 533d5b5e3cb3a95f4ffe57a96361e6d121c13fe3 Mon Sep 17 00:00:00 2001 From: OmarAlex24 Date: Sun, 15 Nov 2026 20:36:10 +0000 Subject: [PATCH] fix(sandbox): a sandbox chat says it is starting the sandbox, not ACP Registry A sandbox chat's host thread runs on the sandbox bridge, which uses the generic ACP Registry driver, so a send after the session was released read "Starting ACP Registry". It now reads "Starting sandbox". Co-Authored-By: Claude Opus 5.5 --- .../src/state/threadExecution.test.ts | 15 +++++++++++++++ .../client-runtime/src/state/threadExecution.ts | 3 +++ 2 files changed, 18 insertions(+) diff --git a/packages/client-runtime/src/state/threadExecution.test.ts b/packages/client-runtime/src/state/threadExecution.test.ts index ea6de929b4cb7..8a72c48bf840c 100644 --- a/packages/client-runtime/src/state/threadExecution.test.ts +++ b/packages/client-runtime/src/state/threadExecution.test.ts @@ -10,6 +10,7 @@ import { RunAttemptId, RunId, RuntimeRequestId, + SANDBOX_BRIDGE_INSTANCE_ID, ThreadId, type OrchestrationV2ExecutionNode, type OrchestrationV2RunStatus, @@ -344,6 +345,20 @@ describe("thread execution presentation", () => { expect( deriveThreadActivityRun({ ...starting, providerSessions: [] })?.providerStartingLabel, ).toBe("Starting"); + const bridgeInstanceId = ProviderInstanceId.make(SANDBOX_BRIDGE_INSTANCE_ID); + expect( + deriveThreadActivityRun({ + ...starting, + runs: [{ ...openRun, providerInstanceId: bridgeInstanceId }], + providerSessions: [ + { + ...session, + driver: ProviderDriverKind.make("acpRegistry"), + providerInstanceId: bridgeInstanceId, + }, + ], + })?.providerStartingLabel, + ).toBe("Starting sandbox"); expect( deriveThreadActivityRun({ ...starting, diff --git a/packages/client-runtime/src/state/threadExecution.ts b/packages/client-runtime/src/state/threadExecution.ts index 622db98a2903a..f7b1830ba0719 100644 --- a/packages/client-runtime/src/state/threadExecution.ts +++ b/packages/client-runtime/src/state/threadExecution.ts @@ -10,6 +10,7 @@ import { isProviderNativeSubagentThread, latestProviderTurnForAttempt, PROVIDER_DISPLAY_NAMES, + SANDBOX_BRIDGE_INSTANCE_ID, type ModelSelection, type OrchestrationV2NotificationSource, type OrchestrationV2PendingBackgroundTask, @@ -110,6 +111,8 @@ function providerStartingLabel( projection: ThreadStructure, run: OrchestrationV2ThreadProjection["runs"][number], ): string { + // The sandbox bridge runs on the generic ACP Registry driver; name the machine it starts. + if (run.providerInstanceId === SANDBOX_BRIDGE_INSTANCE_ID) return "Starting sandbox"; const driver = projection.providerSessions.findLast( (session) => session.providerInstanceId === run.providerInstanceId, )?.driver;