update normalized reading notes

Author: chengtan9907

deployments/desktop/shared/agents.py

@@ -850,8 +850,18 @@ def _configured_reading_notes_git_branch() -> str:
     return _env_text("PAPERFLOW_READING_NOTES_GIT_BRANCH", "main") or "main"
 
 
+def _normalize_reading_notes_git_remote(remote_url: str) -> str:
+    """Prefer SSH for plain GitHub remotes so GUI sync can use the user's SSH key."""
+    remote = str(remote_url or "").strip()
+    match = re.fullmatch(r"https://github\.com/([^/\s]+)/([^/\s]+?)(?:\.git)?/?", remote)
+    if not match:
+        return remote
+    owner, repo = match.groups()
+    return f"git@github.com:{owner}/{repo}.git"
+
+
 def _configured_reading_notes_git_remote() -> str:
-    return _env_text("PAPERFLOW_READING_NOTES_GIT_REMOTE", "")
+    return _normalize_reading_notes_git_remote(_env_text("PAPERFLOW_READING_NOTES_GIT_REMOTE", ""))
 
 
 def _default_reading_notes_git_dir() -> Optional[Path]:

tests/test_desktop_gui.py

@@ -1267,7 +1267,7 @@ def test_desktop_save_settings_updates_env_file(tmp_path, monkeypatch: pytest.Mo
     assert result["paths"]["reading_reports_dir"] == str(tmp_path / "Daily Note")
     assert result["paths"]["wiki_dir"] == str(tmp_path / "Daily Note" / "wiki")
     assert result["paths"]["reading_notes_git_dir"] == str(tmp_path / "Daily Note" / "Daily Note 2026")
-    assert result["paths"]["reading_notes_git_remote"] == "https://github.com/example/notes.git"
+    assert result["paths"]["reading_notes_git_remote"] == "git@github.com:example/notes.git"
     assert result["paths"]["reading_notes_git_branch"] == "main"
     assert result["paths"]["reading_notes_git_llm_review"] is False
     assert "PAPERFLOW_CONFERENCE_ACCESS_MODE=credential" in text
@@ -1289,6 +1289,15 @@ def test_desktop_save_settings_updates_env_file(tmp_path, monkeypatch: pytest.Mo
     assert result["source_preferences"]["auth_status"]["semantic_scholar_api_key"] is True
 
 
+def test_desktop_normalizes_plain_github_notes_remote_to_ssh(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
+    env_path = tmp_path / ".env"
+    env_path.write_text("PAPERFLOW_READING_NOTES_GIT_REMOTE=https://github.com/example/notes\n", encoding="utf-8")
+    monkeypatch.setattr(agents, "ENV_PATH", env_path)
+    monkeypatch.delenv("PAPERFLOW_READING_NOTES_GIT_REMOTE", raising=False)
+
+    assert agents._configured_reading_notes_git_remote() == "git@github.com:example/notes.git"
+
+
 def test_desktop_settings_preserves_zero_relevance_threshold(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
     env_path = tmp_path / ".env"
     env_path.write_text("PAPERFLOW_RELEVANCE_THRESHOLD=60\n", encoding="utf-8")