Skip to content

Fails ungracefully when built from the tarball: AttributeError: 'NoneType' object has no attribute 'group' #198

Description

@yurivict

Build from the tarball fails with git executable present :

[ 10%] Building CXX object src/CMakeFiles/pcm-objlib.dir/green/AnisotropicLiquid.cpp.o
Traceback (most recent call last):
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 367, in <module>
    ans = reconcile_and_compute_version_output(quiet=args.formatonly)
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 150, in reconcile_and_compute_version_output
    res.update(collect_version_input_from_git())
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 95, in collect_version_input_from_git
    if mobj.group('tag'):
AttributeError: 'NoneType' object has no attribute 'group'

When git executable is missing - build succeeds.

Package builder isn't allowed to use git to download anything, so it should successfully build from the tarball w/ or w/out git present.

Python-3.8
FreeBSD 13

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions