diff --git a/Pinta.Core/Effects/BaseEffect.cs b/Pinta.Core/Effects/BaseEffect.cs index 1f6988e142..9cda64a24b 100644 --- a/Pinta.Core/Effects/BaseEffect.cs +++ b/Pinta.Core/Effects/BaseEffect.cs @@ -28,6 +28,7 @@ using System.ComponentModel; using System.Threading.Tasks; using Cairo; +using Mono.Addins.Localization; namespace Pinta.Core; @@ -188,6 +189,25 @@ public virtual BaseEffect Clone () } } +/// +/// Base class for configurable effects whose dialog is the standard SimpleEffectDialog +/// built from their +/// +public abstract class ConfigurableEffect : BaseEffect +{ + private readonly IAddinLocalizer? localizer; + + protected ConfigurableEffect (IAddinLocalizer? localizer = null) + { + this.localizer = localizer; + } + + public sealed override bool IsConfigurable => true; + + public override Task LaunchConfiguration (ILivePreviewSession session) + => session.LaunchSimpleEffectDialog (localizer); +} + /// /// Holds the user configurable data used by this effect. /// diff --git a/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs b/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs index f2e69ad68f..1af4a647a6 100644 --- a/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs +++ b/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs @@ -8,13 +8,12 @@ ///////////////////////////////////////////////////////////////////////////////// using System; -using System.Threading.Tasks; using Cairo; using Pinta.Core; namespace Pinta.Effects; -public sealed class BrightnessContrastEffect : BaseEffect +public sealed class BrightnessContrastEffect : ConfigurableEffect { const int DEFAULT_BRIGHTNESS = 0; const int DEFAULT_CONTRAST = 0; @@ -39,9 +38,6 @@ public override string Icon public override string Name => Translations.GetString ("Brightness / Contrast"); - public override bool IsConfigurable - => true; - public override string AdjustmentMenuKey => "B"; @@ -53,9 +49,6 @@ public BrightnessContrastEffect (IServiceProvider _) EffectData = new BrightnessContrastData (); } - public override Task LaunchConfiguration (ILivePreviewSession session) - => session.LaunchSimpleEffectDialog (); - private readonly record struct BrightnessContrastSettings (BrightnessContrastPixelOp PreRender, Size CanvasSize); private static BrightnessContrastSettings CreateSettings (ImageSurface destination, BrightnessContrastPixelOp pixelOp) => new (