From 4a6391126e77f2e9198cf20a222432360f4fcffe Mon Sep 17 00:00:00 2001 From: Lehonti Ramos <17771375+Lehonti@users.noreply.github.com> Date: Mon, 2 Nov 2026 00:11:09 -0600 Subject: [PATCH 1/2] Added `ConfigurableEffect` base class for configurable effects --- Pinta.Core/Effects/BaseEffect.cs | 16 ++++++++++++++++ .../Adjustments/BrightnessContrastEffect.cs | 9 +-------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/Pinta.Core/Effects/BaseEffect.cs b/Pinta.Core/Effects/BaseEffect.cs index 1f6988e142..f10dcb13a7 100644 --- a/Pinta.Core/Effects/BaseEffect.cs +++ b/Pinta.Core/Effects/BaseEffect.cs @@ -28,6 +28,7 @@ using System.ComponentModel; using System.Threading.Tasks; using Cairo; +using Mono.Addins.Localization; namespace Pinta.Core; @@ -188,6 +189,21 @@ public virtual BaseEffect Clone () } } +public abstract class ConfigurableEffect : BaseEffect +{ + private readonly IAddinLocalizer? localizer; + + protected ConfigurableEffect (IAddinLocalizer? localizer = null) + { + this.localizer = localizer; + } + + public sealed override bool IsConfigurable => true; + + public override Task LaunchConfiguration (ILivePreviewSession session) + => session.LaunchSimpleEffectDialog (localizer); +} + /// /// Holds the user configurable data used by this effect. /// diff --git a/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs b/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs index f2e69ad68f..1af4a647a6 100644 --- a/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs +++ b/Pinta.Effects/Adjustments/BrightnessContrastEffect.cs @@ -8,13 +8,12 @@ ///////////////////////////////////////////////////////////////////////////////// using System; -using System.Threading.Tasks; using Cairo; using Pinta.Core; namespace Pinta.Effects; -public sealed class BrightnessContrastEffect : BaseEffect +public sealed class BrightnessContrastEffect : ConfigurableEffect { const int DEFAULT_BRIGHTNESS = 0; const int DEFAULT_CONTRAST = 0; @@ -39,9 +38,6 @@ public override string Icon public override string Name => Translations.GetString ("Brightness / Contrast"); - public override bool IsConfigurable - => true; - public override string AdjustmentMenuKey => "B"; @@ -53,9 +49,6 @@ public BrightnessContrastEffect (IServiceProvider _) EffectData = new BrightnessContrastData (); } - public override Task LaunchConfiguration (ILivePreviewSession session) - => session.LaunchSimpleEffectDialog (); - private readonly record struct BrightnessContrastSettings (BrightnessContrastPixelOp PreRender, Size CanvasSize); private static BrightnessContrastSettings CreateSettings (ImageSurface destination, BrightnessContrastPixelOp pixelOp) => new ( From 8e7b3170e2a78977baabb43a7bfd91caddb45ed6 Mon Sep 17 00:00:00 2001 From: Lehonti Ramos <17771375+Lehonti@users.noreply.github.com> Date: Fri, 6 Nov 2026 02:35:05 -0600 Subject: [PATCH 2/2] Add XML summary documentation to ConfigurableEffect Added XML documentation for the ConfigurableEffect class. --- Pinta.Core/Effects/BaseEffect.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Pinta.Core/Effects/BaseEffect.cs b/Pinta.Core/Effects/BaseEffect.cs index f10dcb13a7..9cda64a24b 100644 --- a/Pinta.Core/Effects/BaseEffect.cs +++ b/Pinta.Core/Effects/BaseEffect.cs @@ -189,6 +189,10 @@ public virtual BaseEffect Clone () } } +/// +/// Base class for configurable effects whose dialog is the standard SimpleEffectDialog +/// built from their +/// public abstract class ConfigurableEffect : BaseEffect { private readonly IAddinLocalizer? localizer;