fix: initialize gui logging output

Author: mastwet

agent-diva-gui/src-tauri/src/lib.rs

@@ -7,14 +7,20 @@ mod process_utils;
 mod shutdown_manager;
 mod tray;
 
+use agent_diva_core::config::schema::LoggingConfig;
+use agent_diva_core::config::ConfigLoader;
 use app_state::AgentState;
 use embedded_server::EmbeddedGatewayHandle;
 use gateway_status::GatewayStatus;
 use shutdown_manager::ShutdownManager;
+use std::path::{Path, PathBuf};
+use std::sync::OnceLock;
 use std::sync::{Arc, Mutex};
 use tauri::Manager;
 use tokio::sync::Mutex as AsyncMutex;
 
+static LOGGING_INITIALIZED: OnceLock<()> = OnceLock::new();
+
 /// Tracks completion of frontend/backend setup for splash screen.
 struct SplashState {
     frontend_done: bool,
@@ -29,8 +35,50 @@ fn should_manage_gateway_lifecycle() -> bool {
     !cfg!(debug_assertions)
 }
 
+fn config_loader() -> ConfigLoader {
+    match std::env::var("AGENT_DIVA_CONFIG_DIR") {
+        Ok(path) if !path.trim().is_empty() => ConfigLoader::with_dir(expand_user_path(&path)),
+        _ => ConfigLoader::new(),
+    }
+}
+
+fn expand_user_path(path: &str) -> PathBuf {
+    if let Some(rest) = path.strip_prefix("~/") {
+        if let Some(home) = dirs::home_dir() {
+            return home.join(rest);
+        }
+    }
+    PathBuf::from(path)
+}
+
+fn resolve_configured_path(path: &str, config_dir: &Path) -> PathBuf {
+    let expanded = expand_user_path(path);
+    if expanded.is_absolute() {
+        expanded
+    } else {
+        config_dir.join(expanded)
+    }
+}
+
+fn resolve_logging_config(mut config: LoggingConfig, config_dir: &Path) -> LoggingConfig {
+    config.dir = resolve_configured_path(&config.dir, config_dir)
+        .to_string_lossy()
+        .to_string();
+    config
+}
+
+fn init_gui_logging() {
+    LOGGING_INITIALIZED.get_or_init(|| {
+        let loader = config_loader();
+        let config = loader.load().unwrap_or_default();
+        let logging = resolve_logging_config(config.logging, loader.config_dir());
+        let guard = agent_diva_core::logging::init_logging_with_terminal_output(&logging, false);
+        Box::leak(Box::new(guard));
+    });
+}
+
 fn build_gateway_runtime_config() -> agent_diva_manager::GatewayRuntimeConfig {
-    let loader = agent_diva_core::config::ConfigLoader::new();
+    let loader = config_loader();
     let config = loader.load().unwrap_or_default();
     let runtime = agent_diva_cli::cli_runtime::CliRuntime::from_paths(
         None,
@@ -155,6 +203,8 @@ fn set_splash_complete(
 
 #[cfg_attr(mobile, tauri::mobile_entry_point)]
 pub fn run() {
+    init_gui_logging();
+
     tauri::Builder::default()
         .plugin(tauri_plugin_opener::init())
         .plugin(tauri_plugin_store::Builder::new().build())
@@ -319,8 +369,13 @@ pub fn run() {
 
 #[cfg(test)]
 mod tests {
-    use super::{close_action, should_manage_gateway_lifecycle, CloseAction, ExitTrigger};
+    use super::{
+        close_action, resolve_configured_path, resolve_logging_config,
+        should_manage_gateway_lifecycle, CloseAction, ExitTrigger,
+    };
     use crate::shutdown_manager::ShutdownManager;
+    use agent_diva_core::config::schema::LoggingConfig;
+    use tempfile::TempDir;
 
     #[test]
     fn gateway_lifecycle_is_disabled_in_debug_mode() {
@@ -370,4 +425,37 @@ mod tests {
         assert!(manager.begin_shutdown());
         assert!(!manager.begin_shutdown());
     }
+
+    #[test]
+    fn relative_log_dir_resolves_under_config_dir() {
+        let config_dir = TempDir::new().unwrap();
+
+        let path = resolve_configured_path("logs", config_dir.path());
+
+        assert_eq!(path, config_dir.path().join("logs"));
+    }
+
+    #[test]
+    fn absolute_log_dir_is_preserved() {
+        let config_dir = TempDir::new().unwrap();
+        let absolute = config_dir.path().join("custom-logs");
+
+        let path = resolve_configured_path(&absolute.to_string_lossy(), config_dir.path());
+
+        assert_eq!(path, absolute);
+    }
+
+    #[test]
+    fn logging_config_uses_resolved_log_dir() {
+        let config_dir = TempDir::new().unwrap();
+        let mut logging = LoggingConfig::default();
+        logging.dir = "logs".to_string();
+
+        let resolved = resolve_logging_config(logging, config_dir.path());
+
+        assert_eq!(
+            resolved.dir,
+            config_dir.path().join("logs").to_string_lossy().to_string()
+        );
+    }
 }

docs/logs/2026-04-gui-logging/v0.4.11-gui-log-output/acceptance.md

@@ -0,0 +1,14 @@
+# Acceptance
+
+## User Steps
+
+1. Launch `agent-diva-gui`.
+2. Open Settings > General.
+3. Wait for the embedded gateway to start.
+4. Refresh the Gateway Logs panel.
+
+## Expected Result
+
+- The configured logs directory contains a current `gateway.log.<date>` file.
+- The Gateway Logs panel displays recent embedded gateway log lines instead of staying empty.
+- Existing CLI log output behavior is unchanged.

docs/logs/2026-04-gui-logging/v0.4.11-gui-log-output/release.md

@@ -0,0 +1,10 @@
+# Release
+
+## Method
+
+Ship with the next GUI build. No migration is required because the existing `logging` config schema is unchanged.
+
+## Notes
+
+- Relative `logging.dir` values continue to be interpreted relative to the Agent Diva config directory in the GUI log viewer.
+- The GUI logger now writes to the same resolved directory.

docs/logs/2026-04-gui-logging/v0.4.11-gui-log-output/summary.md

@@ -0,0 +1,17 @@
+# Summary
+
+## What Changed
+
+- Initialized GUI process logging before the Tauri builder starts.
+- Resolved the GUI log directory with the same config-relative rules used by the log viewer.
+- Kept the tracing non-blocking worker guard alive for the full GUI process lifetime.
+
+## Impact
+
+- Embedded gateway logs can be written to the configured file directory.
+- Settings > General > Gateway Logs can read the same files created by the embedded gateway.
+- CLI logging behavior is unchanged.
+
+## Root Cause
+
+The GUI embedded gateway bypassed the CLI entrypoint, so it never called the shared tracing initialization used by `agent-diva-cli`. The log viewer also reads config-relative log paths, so GUI logging must initialize with the same resolved directory.

docs/logs/2026-04-gui-logging/v0.4.11-gui-log-output/verification.md

@@ -0,0 +1,25 @@
+# Verification
+
+## Commands
+
+- `cargo fmt --check -p agent-diva-gui`
+- `cargo check -p agent-diva-gui`
+- `cargo test -p agent-diva-gui`
+- `cargo test -p agent-diva-gui embedded_gateway_serves_health_endpoint -- --nocapture`
+- `cargo test -p agent-diva-gui log_dir`
+
+## Result
+
+- `cargo fmt --check -p agent-diva-gui`: passed.
+- `cargo check -p agent-diva-gui`: passed.
+- `cargo test -p agent-diva-gui`: failed because existing `embedded_server::tests::embedded_gateway_serves_health_endpoint` did not become ready and returned Windows TCP connection refused. 20 tests passed, including the new logging path tests.
+- `cargo test -p agent-diva-gui embedded_gateway_serves_health_endpoint -- --nocapture`: failed with the same connection refused health check result.
+- `cargo test -p agent-diva-gui log_dir`: passed, 3 logging directory tests passed.
+
+## Manual Smoke
+
+1. Start the GUI in Tauri runtime.
+2. Confirm the embedded gateway starts.
+3. Confirm `gateway.log.<date>` appears under the configured logging directory.
+4. Open Settings > General > Gateway Logs and refresh.
+5. Confirm recent embedded gateway log lines are visible.