Skip to content

Commit 4c518ba

Browse files
committed
fix: correct float rounding in num_digits_fast for large integers
1 parent 30507bb commit 4c518ba

1 file changed

Lines changed: 18 additions & 1 deletion

File tree

‎maths/number_of_digits.py‎

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,14 @@ def num_digits_fast(n: int) -> int:
4747
4
4848
>>> num_digits_fast(10**15)
4949
16
50+
>>> num_digits_fast(10**16 - 1)
51+
16
52+
>>> num_digits_fast(10**16)
53+
17
54+
>>> num_digits_fast(10**50 - 1)
55+
50
56+
>>> num_digits_fast(-(10**16 - 1))
57+
16
5058
>>> num_digits_fast(0)
5159
1
5260
>>> num_digits_fast(-1)
@@ -60,7 +68,16 @@ def num_digits_fast(n: int) -> int:
6068
"""
6169
if not isinstance(n, int):
6270
raise TypeError("Input must be an integer")
63-
return 1 if n == 0 else math.floor(math.log10(abs(n)) + 1)
71+
if n == 0:
72+
return 1
73+
74+
abs_n = abs(n)
75+
digits = math.floor(math.log10(abs_n) + 1)
76+
if abs_n < 10 ** (digits - 1):
77+
digits -= 1
78+
elif abs_n >= 10**digits:
79+
digits += 1
80+
return digits
6481

6582

6683
def num_digits_faster(n: int) -> int:

0 commit comments

Comments
 (0)