diff --git a/agentdescent/cli.py b/agentdescent/cli.py index 37f0b36f..41aba6f1 100644 --- a/agentdescent/cli.py +++ b/agentdescent/cli.py @@ -799,11 +799,13 @@ def demo_payload( target = {"text": "", "skill_library": ""}.get(used_kind, "") if algo: + # #1145: do not point at evolve agentdescent.{algo}.spec.json — that + # file is only written when `algorithms run` succeeds, and that + # command already prints `evolve` with the absolute path it wrote. own_steps = [ f"agentdescent algorithms run {algo} {target} " f"--model [--base-url ] --rounds 1 --workers 1", "agentdescent doctor", - f"agentdescent evolve agentdescent.{algo}.spec.json", ] elif used_kind == "text": own_steps = [ diff --git a/changelog.d/1145-demo-algorithm-next-evolve.md b/changelog.d/1145-demo-algorithm-next-evolve.md new file mode 100644 index 00000000..b18bda2b --- /dev/null +++ b/changelog.d/1145-demo-algorithm-next-evolve.md @@ -0,0 +1,6 @@ +Fixed +`demo --algorithm NAME` no longer ends with `evolve agentdescent.NAME.spec.json`. +That file does not exist until `algorithms run` writes it, so following the +footer (or `--json` / MCP `next`) failed with exit 2. The footer still points +at `algorithms run NAME ...`, which plans and then prints `evolve` with the +absolute path it just wrote (#1145). diff --git a/tests/test_demo.py b/tests/test_demo.py index 30d6476f..6f9ad05a 100644 --- a/tests/test_demo.py +++ b/tests/test_demo.py @@ -255,6 +255,7 @@ def test_demo_algorithm_evoskill_runs_offline(tmp_path, monkeypatch): assert "evoskill-select" in out, out assert "algorithm: evoskill" in out assert "SKILL.md" in out and "COLUMN: amount" in out + assert "agentdescent evolve agentdescent.evoskill.spec.json" not in out spec = json.loads((tmp_path / "work" / "spec.json").read_text()) assert spec["kind"] == "skill_library" assert spec["algorithm"]["name"] == "evoskill" @@ -283,6 +284,7 @@ def test_demo_algorithm_evoskill_json(tmp_path, monkeypatch): assert payload["learned"].lstrip().startswith("column-amount/SKILL.md") or "/SKILL.md" in payload["learned"] assert any("show" in step for step in payload["next"]) assert any(s.startswith("agentdescent algorithms run evoskill ") for s in payload["next"]) + assert "agentdescent evolve agentdescent.evoskill.spec.json" not in payload["next"] assert "A two-skill library" not in out @@ -459,8 +461,9 @@ def test_demo_algorithm_next_steps_keep_the_algorithm(tmp_path, monkeypatch, nam out = buf.getvalue() assert code == 0, out assert f"agentdescent algorithms run {name} " in out, out - assert f"agentdescent evolve agentdescent.{name}.spec.json" in out assert "agentdescent doctor" in out + # #1145: that spec is not on disk yet; algorithms run prints evolve later. + assert f"agentdescent evolve agentdescent.{name}.spec.json" not in out assert "--out spec.json" not in out buf = io.StringIO() @@ -470,6 +473,6 @@ def test_demo_algorithm_next_steps_keep_the_algorithm(tmp_path, monkeypatch, nam payload = json.loads(buf.getvalue()) assert code == 0 assert any(s.startswith(f"agentdescent algorithms run {name} ") for s in payload["next"]) - assert f"agentdescent evolve agentdescent.{name}.spec.json" in payload["next"] + assert f"agentdescent evolve agentdescent.{name}.spec.json" not in payload["next"] target = "" if payload["kind"] != "text" else "" assert any(target in s for s in payload["next"]) diff --git a/tests/test_mcp.py b/tests/test_mcp.py index 97fb99d4..59bc2134 100644 --- a/tests/test_mcp.py +++ b/tests/test_mcp.py @@ -150,6 +150,8 @@ def test_demo_is_on_path_a_and_runs_offline_without_provider_keys(store, monkeyp assert out["run_id"] assert "COLUMN: amount" in out["learned"] assert any("show" in step for step in out["next"]) + assert any(s.startswith("agentdescent algorithms run gepa ") for s in out["next"]) + assert "agentdescent evolve agentdescent.gepa.spec.json" not in out["next"] def test_demo_refuses_unknown_cards_like_cli(store, capsys): @@ -178,6 +180,7 @@ def test_demo_evoskill_runs_offline_like_cli(store): assert out["outcomes"].get("evoskill-select", 0) >= 1 assert "SKILL.md" in out["learned"] and "COLUMN: amount" in out["learned"] assert any(s.startswith("agentdescent algorithms run evoskill ") for s in out["next"]) + assert "agentdescent evolve agentdescent.evoskill.spec.json" not in out["next"] def test_demo_tool_description_lists_evoskill_as_offline():