Polish Admin Notes legend layout and root return link - PR_26156_188-admin-notes-legend-and-return-polish

Author: ToolboxAid

admin/notes.html

@@ -50,15 +50,17 @@ <h2 id="admin-notes-title" data-admin-notes-title>index.txt</h2>
                                 <span class="status" role="status" data-admin-notes-status>Loading admin notes.</span>
                             </div>
                         </div>
-                        <a href="admin/notes.html" data-admin-notes-return hidden>Return to index.txt</a>
                         <div class="content-stack" data-admin-notes-content aria-live="polite"></div>
-                        <nav class="callout" aria-labelledby="admin-notes-directory-title" data-admin-notes-directory hidden>
-                            <h3 id="admin-notes-directory-title">Current Folder</h3>
+                        <nav class="callout" aria-labelledby="admin-notes-directory-title" data-admin-notes-directory>
+                            <div class="content-cluster">
+                                <h3 id="admin-notes-directory-title">Current Folder</h3>
+                                <a class="btn btn--compact primary" href="admin/notes.html" data-admin-note-link="index" data-admin-notes-root-link>Return to root index</a>
+                            </div>
                             <div class="action-group action-group--tight" data-admin-notes-directory-links></div>
                         </nav>
-                        <section class="callout content-stack" aria-labelledby="admin-notes-legend-title" data-admin-notes-legend>
-                            <h3 id="admin-notes-legend-title">Status Legend</h3>
-                            <ul data-admin-notes-legend-list></ul>
+                        <section class="callout action-group action-group--tight" aria-label="Status Legend" data-admin-notes-legend>
+                            <strong>Status Legend</strong>
+                            <span class="action-group action-group--tight" data-admin-notes-legend-list></span>
                         </section>
                     </div>
                 </article>

admin/notes.js

@@ -44,7 +44,6 @@ class AdminNotesViewer {
     this.historyRef = historyRef;
     this.surface = documentRef.querySelector("[data-admin-notes-viewer]");
     this.title = documentRef.querySelector("[data-admin-notes-title]");
-    this.returnLink = documentRef.querySelector("[data-admin-notes-return]");
     this.status = documentRef.querySelector("[data-admin-notes-status]");
     this.content = documentRef.querySelector("[data-admin-notes-content]");
     this.directory = documentRef.querySelector("[data-admin-notes-directory]");
@@ -67,11 +66,6 @@ class AdminNotesViewer {
       }
       this.openNote(link.dataset.adminNoteLink || DEFAULT_NOTE, true);
     });
-
-    this.returnLink?.addEventListener("click", (event) => {
-      event.preventDefault();
-      this.openNote(DEFAULT_NOTE, true);
-    });
   }
 
   start() {
@@ -113,12 +107,12 @@ class AdminNotesViewer {
     this.clearContent();
     const title = NOTE_INDEX_FILE;
     this.setTitle(title);
-    this.setReturnVisible(normalizedNoteName !== DEFAULT_NOTE);
 
     if (!this.validNoteName(normalizedNoteName)) {
       this.renderError(
         `Rejected note path "${noteName}". Use a bracket note name containing only letters, numbers, underscores, or hyphens.`
       );
+      await this.renderDirectoryLinks(NOTES_DIRECTORY, "");
       return;
     }
 
@@ -138,12 +132,12 @@ class AdminNotesViewer {
     const normalizedFilePath = this.rootRelativeTextPathFromValue(filePath);
     this.clearContent();
     this.setTitle(normalizedFilePath ? this.fileNameForPath(normalizedFilePath) : "linked file");
-    this.setReturnVisible(true);
 
     if (!normalizedFilePath) {
       this.renderError(
         `Rejected linked file path "${filePath}". Use a repository-root text file path without traversal.`
       );
+      await this.renderDirectoryLinks(NOTES_DIRECTORY, "");
       return;
     }
 
@@ -163,6 +157,7 @@ class AdminNotesViewer {
       const response = await fetch(filePath, { cache: "no-store" });
       if (!response.ok) {
         this.renderError(missingMessage);
+        await this.renderDirectoryLinks(this.folderPathForFile(currentFilePath), currentFilePath);
         return;
       }
       const text = await response.text();
@@ -226,9 +221,6 @@ class AdminNotesViewer {
   clearContent() {
     this.content?.replaceChildren();
     this.directoryLinks?.replaceChildren();
-    if (this.directory) {
-      this.directory.hidden = true;
-    }
   }
 
   setTitle(value) {
@@ -243,12 +235,6 @@ class AdminNotesViewer {
     }
   }
 
-  setReturnVisible(visible) {
-    if (this.returnLink) {
-      this.returnLink.hidden = !visible;
-    }
-  }
-
   renderError(message) {
     this.setStatus("Admin note error.");
     const errorMessage = this.documentRef.createElement("p");
@@ -267,19 +253,9 @@ class AdminNotesViewer {
       .sort((left, right) => left.label.localeCompare(right.label));
 
     this.directoryLinks?.replaceChildren();
-    if (!safeEntries.length) {
-      if (this.directory) {
-        this.directory.hidden = true;
-      }
-      return;
-    }
-
     safeEntries.forEach((entry) => {
       this.directoryLinks?.append(this.directoryLink(entry));
     });
-    if (this.directory) {
-      this.directory.hidden = false;
-    }
   }
 
   async directoryEntriesForFolder(folderPath) {
@@ -352,11 +328,10 @@ class AdminNotesViewer {
   renderLegend() {
     this.legendList?.replaceChildren();
     Object.values(STATUS_MARKERS).forEach((marker) => {
-      const item = this.documentRef.createElement("li");
-      item.title = marker.title;
+      const item = this.documentRef.createElement("span");
+      item.dataset.adminNotesLegendItem = marker.name;
       const icon = this.documentRef.createElement("span");
       icon.dataset.adminNotesLegendIcon = marker.name;
-      icon.title = marker.title;
       icon.textContent = marker.icon;
       item.append(icon);
       item.append(this.documentRef.createTextNode(` ${marker.label}`));

docs_build/dev/reports/admin-notes-legend-and-return-polish-report.md

@@ -0,0 +1,37 @@
+# PR_26156_188 Admin Notes Legend And Return Polish Report
+
+## Result
+PASS
+
+## Summary
+- Changed Status Legend from a vertical list to one side-by-side Theme V2 action row.
+- Removed legend hover/title attributes while preserving status marker icon rendering.
+- Removed the old top `Return to index.txt` link.
+- Added `Return to root index` to the Current Folder header row.
+- Kept Current Folder file/folder links below the rendered note content.
+
+## Scope Controls
+- No archived V1/V2 files changed.
+- No `start_of_day` files changed.
+- No page-local CSS, inline styles, `<style>` blocks, inline event handlers, or inline `<script>` blocks added.
+- No new CSS was added; existing Theme V2/Admin classes are used.
+- No full samples smoke was run.
+
+## Latest Admin Notes Context
+- Built on the current Admin Notes directory-link and legend implementation from PR_26156_187.
+- Preserved simple subnote links, labeled root-relative file links, orange note links, current-folder links, traversal rejection, and visible missing-file errors.
+
+## Runtime Behavior Verified
+- Status Legend appears side by side on one row: PASS.
+- Legend has no hover/title behavior: PASS.
+- Old top `Return to index.txt` element is removed: PASS.
+- `Return to root index` appears to the right of the Current Folder H3: PASS.
+- `Return to root index` appears on root, subnote, linked-file, missing-file, and rejected-path views: PASS.
+- `Return to root index` opens the root `docs_build/dev/admin-notes/index.txt`: PASS.
+- Status markers `[ ]`, `[.]`, `[x]`, `[!]`, and `[?]` still render as icons: PASS.
+- Current-folder links still render and open folder/text targets: PASS.
+- Traversal attempts are rejected before fetch: PASS.
+
+## Notes
+- Parser status icons retain their existing title/ARIA behavior; only legend hover/title behavior was removed per BUILD.
+- The Current Folder section remains visible even when a folder has no additional file/folder links so the root return is always available.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -17,11 +17,11 @@ Exercised tool entry points detected:
 (80%) Theme V2 Shared JS - exercised 1 runtime JS files
 
 Changed runtime JS files covered:
-(100%) admin/notes.js - executed lines 452/452; executed functions 46/46
+(100%) admin/notes.js - executed lines 430/430; executed functions 44/44
 
 Files with executed line/function counts where available:
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 206/206; executed functions 16/20
-(100%) admin/notes.js - executed lines 452/452; executed functions 46/46
+(100%) admin/notes.js - executed lines 430/430; executed functions 44/44
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,4 +1,4 @@
-# PR_26156_187 Testing Lane Execution Report
+# PR_26156_188 Testing Lane Execution Report
 
 ## Result
 PASS
@@ -8,33 +8,32 @@ PASS
   - PASS
 - `node --check tests/playwright/tools/AdminNotesViewer.spec.mjs`
   - PASS
-- `node -e "JSON.parse(require('fs').readFileSync('docs_build/dev/admin-notes/directory-index.json','utf8'))"`
-  - PASS
 - `Select-String -Path admin/notes.html -Pattern '<style|\sstyle\s*=|\son[a-zA-Z]+\s*=|<script(?![^>]*\bsrc=)'`
   - PASS, no matches
 - `node node_modules/@playwright/test/cli.js test tests/playwright/tools/AdminNotesViewer.spec.mjs --project=playwright --workers=1 --reporter=list`
   - PASS, 3 tests
 - `npm run test:playwright:static`
   - PASS
-- `git diff --check -- admin/notes.html admin/notes.js docs_build/dev/admin-notes/index.txt docs_build/dev/admin-notes/quick-reference.txt docs_build/dev/admin-notes/directory-index.json docs_build/dev/reports/playwright_v8_coverage_report.txt docs_build/dev/reports/testing_lane_execution_report.md tests/playwright/tools/AdminNotesViewer.spec.mjs`
+- `git diff --check -- admin/notes.html admin/notes.js docs_build/dev/reports/playwright_v8_coverage_report.txt docs_build/dev/reports/testing_lane_execution_report.md tests/playwright/tools/AdminNotesViewer.spec.mjs`
   - PASS with Git line-ending warnings for touched files
-- `node -e "<trailing whitespace and merge marker check for new PR files>"`
+- `node -e "<trailing whitespace and merge marker check for PR188 files>"`
   - PASS
 
 ## Runtime/UI Coverage
 - Admin Notes page loads `docs_build/dev/admin-notes/index.txt`: PASS.
-- Placeholder sections Ideas, Things to Fix, and Undecided Questions render: PASS.
-- Status markers `[ ]`, `[.]`, `[!]`, `[?]`, and `[x]` parse into the requested emoji icons: PASS.
+- Status markers `[ ]`, `[.]`, `[!]`, `[?]`, and `[x]` still parse into emoji icons: PASS.
 - Top-level bullets and nested sub-bullets render as lists: PASS.
 - `[other]` opens `docs_build/dev/admin-notes/other/index.txt`: PASS.
-- Subnote Return to `index.txt` link returns to the main index note: PASS.
-- Current-folder directory links render below note content: PASS.
+- Old top `Return to index.txt` link is removed: PASS.
+- `Return to root index` appears to the right of H3 Current Folder: PASS.
+- `Return to root index` appears on all exercised Admin Notes page states and opens root `index.txt`: PASS.
+- Current-folder directory links remain below note content: PASS.
 - Folder directory links open folder `index.txt` files: PASS.
 - Supported text file directory links open and display the linked file: PASS.
 - The current `index.txt` is not duplicated in directory links: PASS.
 - H2 shows `index.txt`, and the loaded path appears to the right on the same header row: PASS.
-- Bottom status legend displays `⬜ Not Started`, `🟡 In Progress`, `✅ Complete`, `⛔ Blocker`, and `❓ Decide`: PASS.
-- `[?]` parser and legend hover/title text matches the requested Decide description: PASS.
+- Status Legend displays side by side in one row: PASS.
+- Legend has no hover/title attributes: PASS.
 - `[HERE, docs_build\tools-images-generated\achievements.txt]` displays `HERE` and opens the target file: PASS.
 - Forward slash and backslash custom file paths both resolve: PASS.
 - Missing note and linked text files display visible actionable errors: PASS.
@@ -48,13 +47,13 @@ PASS
 
 ## Skipped Lanes
 - Full samples smoke: SKIP by BUILD instruction.
-- Broader tool lanes: SKIP because PR_26156_187 changes are confined to Admin Notes page/parser runtime/UI, note fixtures, directory manifest data, and the targeted Admin Notes spec.
+- Broader tool lanes: SKIP because PR_26156_188 changes are confined to Admin Notes page/parser runtime/UI, return navigation placement, legend rendering, and the targeted Admin Notes spec.
 - Engine lane: SKIP because no engine/core files changed.
 
 ## Notes
 - Static validation generated companion reports during execution. Non-required companion report updates were restored so the PR remains scoped to requested artifacts.
 - The missing-path tests intentionally trigger 404 fetches for missing text files and verify the page renders actionable errors.
-- Directory links are manifest-backed because browser JavaScript cannot enumerate static repo folders from the existing test server.
+- Parser status icons retain existing title/ARIA behavior; legend hover/title behavior was removed.
 
 ## Coverage Artifact
 - `docs_build/dev/reports/playwright_v8_coverage_report.txt`