Skip to content

Commit 1b474ef

Browse files
ToolboxAidToolboxAid
committed
BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY
- Removed bad preview-to-Workspace-Manager redirect hook - Restored direct game launch behavior - Preserved explicit Workspace Manager action - Continued Asteroids parity tracking PR Details: - Fixes Bouncing Ball and other games redirecting to Workspace Manager - No validators - No start_of_day changes
1 parent 676531d commit 1b474ef

9 files changed

Lines changed: 305 additions & 73 deletions

‎docs/dev/reports/expected_delta_template.md‎

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
11
# Expected Codex Return / Delta Template
22

3-
## Expected Changed/Added Files
4-
- `games/Asteroids/game.manifest.json`
5-
- `docs/dev/reports/level_8_31_asteroids_json_cleanup_report.md`
3+
## Expected Changed Files
4+
- Source file(s) owning game preview/direct launch routing
5+
- `docs/dev/reports/level_8_32_direct_launch_hook_and_asteroids_parity_report.md`
66
- `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md` if status update needed
77

8-
## Possible Deleted Files
9-
Only if proven safe:
10-
- `games/Asteroids/assets/palettes/hud.json`
11-
- `games/Asteroids/assets/tools.manifest.json`
12-
- `games/Asteroids/assets/workspace.asset-catalog.json`
13-
148
## Expected Validation Summary
15-
- `asteroids_json_files_before=21`
16-
- `asteroids_json_files_after=<count>`
17-
- `game_manifest_referenced_json=<count>`
18-
- `deleted_files=<count>`
19-
- `legacy_files_retained=<count>`
20-
- `deferred_cleanup_items=<count>`
21-
- `unreferenced_json_final=<count>`
22-
- `runtime_changes=0`
9+
- `redirect_hook_found=true`
10+
- `preview_routes_to_workspace_manager=false`
11+
- `bouncing_ball_direct_launch=true`
12+
- `asteroids_direct_launch=true`
13+
- `space_invaders_direct_launch=true`
14+
- `workspace_manager_explicit_action_preserved=true`
15+
- `uses_game_query_for_workspace_manager=false`
16+
- `uses_gameId_query_for_workspace_manager=true`
2317
- `validators_added=0`
2418
- `start_of_day_changes=0`
2519

2620
## Expected Delta ZIP
2721
Codex must create:
2822

29-
`tmp/BUILD_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING_delta.zip`
23+
`tmp/BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY_delta.zip`

‎docs/dev/reports/level_8_32_direct_launch_hook_and_asteroids_parity_report.md‎

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
# Level 8.32 Direct Launch Hook and Asteroids Parity Report
2+
3+
## Redirect Hook Found
4+
- Source file: `games/shared/workspaceGameLaunchGuard.js`
5+
- Hook: `enforceWorkspaceGameLaunch(gameId)`
6+
7+
### Old Behavior
8+
- Normal direct game launches (non-hosted) were redirected to Workspace Manager:
9+
- `/tools/Workspace%20Manager/index.html?game=<id>&mount=game`
10+
- This broke preview/direct launches and used the wrong query key (`game`).
11+
12+
### New Behavior
13+
- `enforceWorkspaceGameLaunch(gameId)` now:
14+
- loads Workspace-hosted context only when launch is hosted from Workspace Manager
15+
- returns without redirect for normal direct launches
16+
- Added explicit helper:
17+
- `openGameInWorkspaceManager(gameId)`
18+
- uses canonical query: `?gameId=<id>&mount=game`
19+
20+
## Query Name Correction (`gameId`)
21+
- Updated Workspace Manager URL generation in:
22+
- `games/shared/workspaceGameLaunchGuard.js`
23+
- `tools/shared/platformShell.js`
24+
- Verified no runtime code path still generates `?game=` URLs for explicit Workspace Manager links.
25+
26+
## Direct-Launch Smoke Check
27+
Static smoke check performed against game metadata/direct paths and launch guard behavior.
28+
29+
| Game | Direct Path | Path Exists | Redirect Hook Status | Result |
30+
|---|---|---|---|---|
31+
| SpaceInvaders | `/games/SpaceInvaders/index.html` | yes | no non-hosted redirect | pass |
32+
| Bouncing Ball | `/games/Bouncing-ball/index.html` | yes | no non-hosted redirect | pass |
33+
| Asteroids | `/games/Asteroids/index.html` | yes | direct path preserved | pass |
34+
| Pong | `/games/Pong/index.html` | yes | no non-hosted redirect | pass |
35+
| Breakout | `/games/Breakout/index.html` | yes | no non-hosted redirect | pass |
36+
37+
## Workspace Manager Explicit-Only Status
38+
- Games hub preview links continue to use direct game href (`/games/.../index.html`).
39+
- Workspace Manager remains a separate explicit action:
40+
- `Open with Workspace Manager`
41+
- generated by `resolveGameWorkspaceLaunchHref(...)`
42+
- format: `/tools/Workspace%20Manager/index.html?gameId=<id>&mount=game`
43+
44+
## Asteroids Parity Status (8.31 Continuation)
45+
- Revalidated Asteroids JSON parity from 8.31:
46+
- non-manifest Asteroids JSON files: `21`
47+
- manifest-wired files: `21`
48+
- final unreferenced count: `0`
49+
- Legacy/deferred status remains unchanged and documented:
50+
- `assets/palettes/hud.json` retained (active compatibility references)
51+
- `assets/tools.manifest.json` retained (runtime/tooling/test references)
52+
- `assets/workspace.asset-catalog.json` retained (runtime/tooling conventions)
53+
- `assets/*/data/*` move remains deferred
54+
55+
## Constraints Check
56+
- `validators_added=0`
57+
- `start_of_day_changes=0`
58+
- runtime changes limited to launch-hook behavior only
59+
60+
## Delta ZIP
61+
- `tmp/BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY_delta.zip`

‎docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,10 +881,12 @@
881881
- [.] Verify workspace schema has no sample-only concepts.
882882
- [x] Manifest SSoT audit across game workspace catalogs/tool manifests is complete.
883883
- [x] Asteroids-first `game.manifest.json` SSoT example implemented (palette + HUD typing + bezel override wiring).
884-
- [.] Asteroids JSON cleanup and manifest wiring audit is in progress.
884+
- [x] Asteroids JSON cleanup and manifest wiring audit is complete (manifest coverage + deferred legacy rationale documented).
885885
- [.] Asteroids legacy catalog parity verification is in progress.
886886
- [x] All-games `game.manifest.json` SSoT rollout completed with legacy catalogs retained.
887887
- [x] Asteroids preview direct launch separation from Workspace Manager remains valid.
888+
- [x] Direct game launch hook removal prevents normal preview redirects to Workspace Manager.
889+
- [x] Explicit Workspace Manager game-launch paths use `gameId` query naming.
888890
- [.] Unused JSON cleanup audit (tools + explicit deletion candidates) is in progress.
889891
- [.] Palette opaque alpha normalization (`#RRGGBBFF` -> `#RRGGBB`) is in progress.
890892
- [x] Code-defined asset extraction audit across games/samples is complete.

‎docs/operations/dev/codex_commands.md‎

Lines changed: 33 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2,41 +2,45 @@ MODEL: GPT-5.3-codex
22
REASONING: high
33

44
TASK:
5-
Apply BUILD_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING.
5+
Apply BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY.
66

77
STEPS:
8-
1. Read docs/pr/PLAN_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING.md.
9-
2. Read docs/pr/BUILD_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING.md.
10-
3. Inventory all `games/Asteroids/**/*.json`.
11-
4. Treat `games/Asteroids/game.manifest.json` as SSoT.
12-
5. Ensure game.manifest.json references every Asteroids JSON asset that is still intended for game/workspace use.
13-
6. Audit duplicate HUD data:
14-
- compare `assets/palettes/hud.json`
15-
- compare `assets/palettes/asteroids-hud.palette.json`
16-
- delete hud.json only if converted and unreferenced
17-
7. Audit legacy catalogs:
18-
- assets/tools.manifest.json
19-
- assets/workspace.asset-catalog.json
20-
Delete only if no runtime/scripts/docs reference them and manifest parity is proven.
21-
8. Audit generic data folders:
22-
- assets/parallax/data/*
23-
- assets/sprites/data/*
24-
- assets/tilemaps/data/*
25-
- assets/vectors/data/*
26-
Move only if safe and manifest updates are clear; otherwise report deferred.
27-
9. Ensure `assets/tilesets/ui.json` is wired or documented/deleted if safe.
28-
10. Update docs/dev/reports/level_8_31_asteroids_json_cleanup_report.md.
29-
11. Update docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md status only:
8+
1. Read docs/pr/PLAN_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY.md.
9+
2. Read docs/pr/BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY.md.
10+
3. Search for the redirect hook using:
11+
- "Workspace Manager/index.html"
12+
- "mount=game"
13+
- "?game="
14+
- "gameId"
15+
- "open with workspace"
16+
- "launchGame"
17+
- "preview"
18+
4. Find why direct preview launches redirect to Workspace Manager.
19+
5. Remove/disable that redirect for normal game preview clicks.
20+
6. Preserve explicit Workspace Manager action only.
21+
7. If shared helper mixes concerns, split behavior:
22+
- direct game launch helper
23+
- workspace manager launch helper
24+
8. Correct Workspace Manager query name to gameId wherever explicit Workspace Manager action remains.
25+
9. Smoke check:
26+
- SpaceInvaders direct launch remains working
27+
- Bouncing Ball direct launch works
28+
- Asteroids direct launch works
29+
- Pong direct launch works if present
30+
- Breakout direct launch works if present
31+
10. Continue Asteroids parity cleanup only if safe and already scoped by 8.31.
32+
11. Update docs/dev/reports/level_8_32_direct_launch_hook_and_asteroids_parity_report.md.
33+
12. Update docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md status only:
3034
- [ ] -> [.]
3135
- [.] -> [x]
3236
- no prose rewrite/delete
33-
12. Do not add validators.
34-
13. Do not modify start_of_day.
35-
14. Avoid runtime code changes.
37+
13. Do not add validators.
38+
14. Do not modify start_of_day.
3639
15. Create Codex delta ZIP:
37-
tmp/BUILD_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING_delta.zip
40+
tmp/BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY_delta.zip
3841

3942
ACCEPTANCE:
40-
- Every remaining Asteroids JSON file is manifest-wired, runtime-required legacy, or documented deferred cleanup.
41-
- Duplicate HUD JSON is removed if safe.
43+
- Game preview click launches game directly.
44+
- No normal preview sends browser to Workspace Manager.
45+
- Explicit Workspace Manager action still works with gameId.
4246
- Delta ZIP exists.

‎docs/operations/dev/commit_comment.txt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
BUILD_PR_LEVEL_8_31_ASTEROIDS_JSON_CLEANUP_AND_MANIFEST_WIRING
1+
BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY
22

3-
- Cleaned Asteroids JSON layout around game.manifest.json SSoT
4-
- Audited duplicate HUD palette data and legacy catalogs
5-
- Wired or documented remaining Asteroids JSON files
3+
- Removed bad preview-to-Workspace-Manager redirect hook
4+
- Restored direct game launch behavior
5+
- Preserved explicit Workspace Manager action
6+
- Continued Asteroids parity tracking
67

78
PR Details:
8-
- Asteroids-only cleanup
9-
- No all-games rollout
9+
- Fixes Bouncing Ball and other games redirecting to Workspace Manager
1010
- No validators
1111
- No start_of_day changes

‎docs/pr/BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY.md‎

Lines changed: 106 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,106 @@
1+
# BUILD_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY
2+
3+
## Objective
4+
Fix the direct game launch path globally.
5+
6+
## Required Behavior
7+
8+
### Game Preview
9+
Clicking a game preview/card must launch the game directly.
10+
11+
Example:
12+
```text
13+
games/BouncingBall.index.html
14+
```
15+
16+
or the correct canonical direct launch path.
17+
18+
### Workspace Manager
19+
Workspace Manager should only open from an explicit Workspace Manager action:
20+
21+
```text
22+
tools/Workspace Manager/index.html?gameId=<id>&mount=game
23+
```
24+
25+
Not from normal preview click.
26+
27+
## Current Broken Behavior
28+
Some game launches redirect to Workspace Manager using:
29+
30+
```text
31+
?game=<id>&mount=game
32+
```
33+
34+
This is wrong for two reasons:
35+
1. Preview should not route through Workspace Manager.
36+
2. Workspace Manager expects `gameId`, not `game`.
37+
38+
## Required Fix
39+
Find the hook that rewrites or redirects direct game launches to Workspace Manager.
40+
41+
Likely search targets:
42+
- game index/cards/list renderers
43+
- preview click handlers
44+
- launch helper functions
45+
- workspace manager launch adapters
46+
- redirect guards
47+
- `mount=game`
48+
- `?game=`
49+
- `Workspace Manager/index.html`
50+
- `open with workspace`
51+
- game registry launch URL generation
52+
53+
## Fix Rules
54+
- Delete or disable the redirect only for normal preview/direct game launch.
55+
- Preserve a separate Workspace Manager action if already present.
56+
- If a shared helper mixes both behaviors, split into:
57+
- `launchGameDirect(game)`
58+
- `openGameInWorkspaceManager(game)`
59+
- Do not require query params for normal game launch.
60+
- Do not rewrite unrelated runtime behavior.
61+
62+
## Games to Smoke Check
63+
At minimum:
64+
- SpaceInvaders direct launch remains working.
65+
- Bouncing Ball direct launch works.
66+
- Asteroids direct launch works.
67+
- Pong direct launch works if present.
68+
- Breakout direct launch works if present.
69+
70+
## Asteroids Parity Continuation
71+
After launch hook is fixed, continue Asteroids-only cleanup from Level 8.31:
72+
- confirm every remaining Asteroids JSON is manifest-wired, legacy-required, or deferred
73+
- preserve legacy catalogs unless parity is proven
74+
- do not delete runtime-required catalogs yet
75+
76+
## Required Report
77+
Create:
78+
79+
```text
80+
docs/dev/reports/level_8_32_direct_launch_hook_and_asteroids_parity_report.md
81+
```
82+
83+
Report must include:
84+
- hook/source file found
85+
- old behavior
86+
- new behavior
87+
- direct-launch smoke check results
88+
- Workspace Manager explicit-action status
89+
- Asteroids parity status
90+
- delta ZIP creation confirmation
91+
92+
## Roadmap Movement
93+
Update `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md` status only:
94+
- advance direct game launch hook removal `[ ] -> [.]` or `[.] -> [x]`
95+
- advance Asteroids parity cleanup if execution-backed
96+
- no prose rewrite/delete
97+
98+
## Acceptance
99+
- Normal preview clicks no longer redirect to Workspace Manager.
100+
- Bouncing Ball launches directly.
101+
- Asteroids launches directly.
102+
- Space Invaders still launches directly.
103+
- Workspace Manager remains available only as explicit action.
104+
- No validators added.
105+
- No `start_of_day` changes.
106+
- Codex returns delta ZIP.

‎docs/pr/PLAN_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY.md‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# PLAN_PR_LEVEL_8_32_DIRECT_GAME_LAUNCH_HOOK_REMOVAL_AND_ASTEROIDS_PARITY
2+
3+
## Purpose
4+
Remove the global hook/redirect that sends game preview launches through Workspace Manager, and continue Asteroids cleanup/parity only after direct game launch is restored.
5+
6+
## User-Reported Failure
7+
Only Space Invaders launches directly.
8+
9+
Clicking Bouncing Ball and other games appears to target the correct direct game URL, for example:
10+
11+
```text
12+
games/BouncingBall.index.html
13+
```
14+
15+
But the browser redirects to:
16+
17+
```text
18+
http://127.0.0.1:5500/tools/Workspace%20Manager/index.html?game=Bouncing-ball&mount=game
19+
```
20+
21+
Workspace Manager then shows:
22+
23+
```text
24+
Workspace Manager Diagnostic
25+
Workspace Manager game launch requires a valid gameId.
26+
27+
Expected query: ?gameId=<id>&mount=game
28+
```
29+
30+
## Scope
31+
- Find and remove/disable the redirect hook that reroutes normal game previews to Workspace Manager.
32+
- Ensure game preview click launches the game directly for all games.
33+
- Keep Workspace Manager as a separate explicit action only.
34+
- Keep Asteroids JSON cleanup/parity work from 8.31 moving forward.
35+
- Advance roadmap status only.
36+
37+
## Non-Goals
38+
- No Workspace Manager redesign.
39+
- No broad runtime rewrite beyond removing the bad redirect hook.
40+
- No validators.
41+
- No `start_of_day` changes.

0 commit comments

Comments
 (0)