Skip to content

Commit a9f8540

Browse files
ToolboxAidToolboxAid
committed
Fix Parallax Scene Studio header metadata and toggle labels
- Add required Parallax Scene Studio header/intro metadata - Remove configuration error for complete tool metadata - Replace generic header/details toggle labels with tool-specific text - Preserve actionable errors for genuinely missing metadata
1 parent 9414d6a commit a9f8540

11 files changed

Lines changed: 501 additions & 43 deletions

‎docs/dev/codex_commands.md‎

Lines changed: 55 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,59 @@
1-
# CODEX COMMANDS
1+
MODEL: GPT-5.3-codex
2+
REASONING: low
23

3-
model: gpt-5.3-codex
4-
reasoning: medium
4+
PR purpose:
5+
Fix remaining shared-shell header issues:
6+
1. Parallax Scene Studio shows configuration error because required metadata is missing.
7+
2. After exiting fullscreen, generic toggle text says "Hide Header and Details".
58

6-
Apply PR_10_14_FULLSCREEN_HEADER_SUMMARY_LINE_FIX.
9+
Do not modify KOTI files.
10+
Do not modify sample games.
11+
Do not modify runtime engine files.
12+
Do not modify start_of_day folders.
13+
Do not run long samples suite.
714

8-
Use a surgical shared-platform fix only.
15+
Fix Parallax Scene Studio metadata:
16+
- Find actual tool id in toolRegistry.js.
17+
- Add/verify:
18+
name
19+
shortDescription
20+
intro or equivalent one-line help text
21+
- Suggested:
22+
name: "Parallax Scene Studio"
23+
shortDescription: "Layered Scene & Depth Composition"
24+
intro: "Parallax Scene Studio: compose layered backgrounds, midgrounds, and foreground scene depth."
925

10-
Required:
11-
- Fix fullscreen header summary so caret + tool name/description remain on one line.
12-
- Prevent fullscreen-only platform summary/error presentation from affecting normal screen.
13-
- Preserve diagnostics without creating a multi-line visible error header in normal screen.
14-
- Do not change tool data, manifests, registry entries, or start_of_day folders.
15-
- Add validation report at docs/dev/reports/PR_10_14_FULLSCREEN_HEADER_SUMMARY_LINE_FIX_report.md.
16-
- Return ZIP artifact at tmp/PR_10_14_FULLSCREEN_HEADER_SUMMARY_LINE_FIX_delta.zip.
26+
Fix toggle text:
27+
- Replace generic "Hide Header and Details" / "Show Header and Details" with tool-specific text:
28+
Hide <Tool Name> Details
29+
Show <Tool Name> Details
30+
- Ensure it updates on page load, metadata bind, enter fullscreen, exit fullscreen, collapse/expand.
31+
- Do not use CSS-only masking.
32+
- Shared shell remains source of truth.
33+
34+
Missing metadata:
35+
- Keep actionable configuration error for genuinely incomplete metadata.
36+
- Error must name tool id and missing field.
37+
38+
Validation:
39+
- node --check tools/shared/platformShell.js
40+
- node --check tools/toolRegistry.js
41+
- browser validate Parallax Scene Studio normal mode, fullscreen, exit fullscreen.
42+
- Search visible DOM/text for:
43+
Header and Intro
44+
Hide Header and Details
45+
Show Header and Details
46+
47+
Create evidence:
48+
tmp/pr_tool_fix_parallax_header_metadata_validation.json
49+
50+
Create report:
51+
docs/dev/reports/PR_tool_fix_parallax_header_metadata_report.md
52+
53+
Report:
54+
- PASS/FAIL
55+
- changed files
56+
- metadata fixed
57+
- toggle text after exit fullscreen
58+
- validation commands/results
59+
- remaining issues

‎docs/dev/commit_comment.txt‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
Fix fullscreen header summary line layout without changing normal-screen tool headers - PR 10.14
1+
Fix Parallax Scene Studio header metadata and toggle labels
2+
3+
- Add required Parallax Scene Studio header/intro metadata
4+
- Remove configuration error for complete tool metadata
5+
- Replace generic header/details toggle labels with tool-specific text
6+
- Preserve actionable errors for genuinely missing metadata

‎docs/dev/pr_tool_fix_parallax_header_metadata.md‎

Lines changed: 223 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,223 @@
1+
# PR — Fix Parallax Header Metadata and Toggle Label
2+
3+
## Purpose
4+
5+
Fix the remaining shared-shell header issues found after removing static `Header and Intro` labels.
6+
7+
This PR is tools-only.
8+
9+
---
10+
11+
## Observed Issues
12+
13+
### 1. Parallax Scene Studio configuration error
14+
15+
On page load:
16+
17+
```txt
18+
Parallax Scene Studio — Configuration error (open title for details)
19+
```
20+
21+
In fullscreen:
22+
23+
```txt
24+
Parallax Scene Studio — Configuration error (open title for details)
25+
```
26+
27+
This means the new no-fallback metadata rule is working, but Parallax Scene Studio is missing required metadata.
28+
29+
### 2. Exit fullscreen generic toggle text
30+
31+
After exiting fullscreen, the visible control text says:
32+
33+
```txt
34+
Hide Header and Details
35+
```
36+
37+
This is still generic and does not include the tool name.
38+
39+
---
40+
41+
## Scope
42+
43+
Target only:
44+
45+
- Parallax Scene Studio tool registry metadata
46+
- Shared platform shell header/intro/toggle rendering
47+
- Shared platform shell CSS if needed
48+
49+
Do not modify:
50+
51+
- King of the Iceberg files
52+
- sample games
53+
- runtime engine files
54+
- `start_of_day` folders
55+
56+
---
57+
58+
## Required Behavior
59+
60+
### Parallax Scene Studio
61+
62+
On normal page load, visible header must show:
63+
64+
```txt
65+
Parallax Scene Studio — <Short Description>
66+
```
67+
68+
Visible intro must show:
69+
70+
```txt
71+
Parallax Scene Studio: <one-line usage/help text>
72+
```
73+
74+
In fullscreen, the same tool-specific header/intro must be visible.
75+
76+
No configuration error should appear when metadata is complete.
77+
78+
---
79+
80+
## Required Metadata
81+
82+
Add or verify registry fields for `parallax-scene-studio` or its actual tool id:
83+
84+
- `name`
85+
- `shortDescription`
86+
- `intro` or equivalent one-line usage/help text
87+
88+
Suggested values:
89+
90+
```js
91+
name: "Parallax Scene Studio",
92+
shortDescription: "Layered Scene & Depth Composition",
93+
intro: "Parallax Scene Studio: compose layered backgrounds, midgrounds, and foreground scene depth."
94+
```
95+
96+
Use existing naming conventions in `toolRegistry.js`.
97+
98+
---
99+
100+
## Toggle Label Requirement
101+
102+
Generic toggle text must not say:
103+
104+
```txt
105+
Hide Header and Details
106+
```
107+
108+
Instead, it must include the active tool name.
109+
110+
Preferred:
111+
112+
```txt
113+
Hide <Tool Name> Details
114+
Show <Tool Name> Details
115+
```
116+
117+
The toggle label must update when:
118+
119+
- page loads
120+
- tool metadata binds
121+
- entering fullscreen
122+
- exiting fullscreen
123+
- collapse/expand changes
124+
125+
---
126+
127+
## Missing Metadata Rule
128+
129+
If any tool still lacks required metadata:
130+
131+
- show actionable configuration error
132+
- identify the missing field
133+
- include the tool id
134+
- do not silently fall back to generic text
135+
136+
Example:
137+
138+
```txt
139+
Parallax Scene Studio configuration error: missing shortDescription for tool id parallax-scene-studio.
140+
```
141+
142+
---
143+
144+
## Acceptance Criteria
145+
146+
- Parallax Scene Studio no longer shows configuration error on page load.
147+
- Parallax Scene Studio no longer shows configuration error in fullscreen.
148+
- Parallax Scene Studio normal header includes tool name.
149+
- Parallax Scene Studio fullscreen header includes tool name.
150+
- Parallax Scene Studio intro includes tool name.
151+
- Exiting fullscreen does not show generic `Hide Header and Details`.
152+
- Toggle text includes active tool name.
153+
- Missing metadata still produces actionable errors for genuinely incomplete tools.
154+
- No CSS-only masking of stale generic labels.
155+
- No KOTI/sample/runtime/start_of_day files change.
156+
157+
---
158+
159+
## Targeted Validation
160+
161+
Do not run long sample suites.
162+
163+
Run only relevant checks:
164+
165+
```powershell
166+
node --check tools/shared/platformShell.js
167+
node --check tools/toolRegistry.js
168+
```
169+
170+
If another JS file changes, run `node --check` on that file only.
171+
172+
Browser validation:
173+
174+
- Open Parallax Scene Studio.
175+
- Confirm normal header/intro text.
176+
- Enter fullscreen.
177+
- Confirm fullscreen header/intro text.
178+
- Exit fullscreen.
179+
- Confirm toggle label includes tool name.
180+
- Search DOM/text for visible generic labels:
181+
- `Header and Intro`
182+
- `Hide Header and Details`
183+
- `Show Header and Details`
184+
185+
---
186+
187+
## Required Evidence
188+
189+
Create:
190+
191+
```txt
192+
tmp/pr_tool_fix_parallax_header_metadata_validation.json
193+
```
194+
195+
Include:
196+
197+
- tool id
198+
- normal header text
199+
- normal intro text
200+
- fullscreen header text
201+
- fullscreen intro text
202+
- post-exit toggle text
203+
- generic labels found/not found
204+
- PASS/FAIL
205+
206+
---
207+
208+
## Required Report
209+
210+
Create:
211+
212+
```txt
213+
docs/dev/reports/PR_tool_fix_parallax_header_metadata_report.md
214+
```
215+
216+
Include:
217+
218+
- PASS/FAIL
219+
- changed files
220+
- metadata fields added/fixed
221+
- toggle label behavior
222+
- validation commands/results
223+
- remaining issues

‎docs/dev/reports/PR_10_15_FULLSCREEN_HEADER_STATE_TEXT_FIX_report.md‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# PR 10.15 Fullscreen Header State Text Fix Report
2+
3+
- Generated: 2026-04-28T18:09:08.972Z
4+
- PASS/FAIL: PASS
5+
6+
## Changed Files
7+
- tools/shared/platformShell.js
8+
- tools/shared/platformShell.css
9+
- docs/dev/reports/PR_10_15_FULLSCREEN_HEADER_STATE_TEXT_FIX_report.md
10+
- tmp/PR_10_15_FULLSCREEN_HEADER_STATE_TEXT_FIX_validation.json
11+
12+
## Exact State Behavior Verified
13+
- Fullscreen expanded/open summary text is exactly: `Hide Header and Details`.
14+
- Fullscreen collapsed summary text is exactly: `<tool name> ? <tool shortDescription>` for validated tools.
15+
- Collapsed fullscreen summary is rendered as a single inline text node (no stacked span layout, no CR/NL).
16+
- Fullscreen collapsed summary uses constrained width + truncation (`nowrap`, `overflow: hidden`, `text-overflow: ellipsis`) so caret and text remain on one line.
17+
18+
## Normal Mode Validation
19+
1. Loaded each validated tool in normal mode.
20+
2. Confirmed summary title/diagnostic remains available (`title` attribute present).
21+
3. Confirmed change scope stays in shared platform shell only (no tool data/manifest/registry edits).
22+
23+
## Fullscreen Expanded Validation
24+
1. Entered fullscreen header mode for each validated tool.
25+
2. Expanded header/details while remaining in fullscreen.
26+
3. Verified summary text equals `Hide Header and Details` exactly.
27+
28+
## Fullscreen Collapsed Validation
29+
1. Collapsed header/details in fullscreen.
30+
2. Verified summary text equals expected compact tool identity line exactly.
31+
3. Verified no CR/NL in summary text, no child elements in summary text container, and truncation-safe inline style is active.
32+
33+
## Validation Commands and Evidence
34+
- `node --check tools/shared/platformShell.js`
35+
- `node tmp/PR_10_15_FULLSCREEN_HEADER_STATE_TEXT_FIX_validation.mjs`
36+
- Evidence JSON: tmp/PR_10_15_FULLSCREEN_HEADER_STATE_TEXT_FIX_validation.json
37+
- Vector Map Editor: PASS | collapsed="Vector Map Editor — Map layout and collision authoring" | expanded="Hide Header and Details"
38+
- Vector Asset Studio: PASS | collapsed="Vector Asset Studio — SVG asset authoring and export" | expanded="Hide Header and Details"
39+
- Sprite Editor: PASS | collapsed="Sprite Editor — Palette-locked sprite and frame editing" | expanded="Hide Header and Details"
40+
- State Inspector: PASS | collapsed="State Inspector — Host/runtime state snapshot inspection" | expanded="Hide Header and Details"
41+
42+
## Scope Confirmation
43+
- No tool data files modified.
44+
- No manifest files modified.
45+
- No registry entries modified.
46+
- No `start_of_day` folders modified.

‎docs/dev/reports/PR_tool_fix_parallax_header_metadata_report.md‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# PR Tool Fix Parallax Header Metadata Report
2+
3+
- Generated: 2026-04-28T18:20:58.778Z
4+
- PASS/FAIL: PASS
5+
6+
## Changed Files
7+
- tools/toolRegistry.js
8+
- tools/shared/platformShell.js
9+
- tmp/pr_tool_fix_parallax_header_metadata_validation.json
10+
- docs/dev/reports/PR_tool_fix_parallax_header_metadata_report.md
11+
12+
## Metadata Fixed
13+
- Tool id: `parallax-editor`
14+
- name: Parallax Scene Studio
15+
- shortDescription: Layered Scene & Depth Composition
16+
- intro equivalent (description): Parallax Scene Studio: compose layered backgrounds, midgrounds, and foreground scene depth.
17+
18+
## Toggle Text After Exit Fullscreen
19+
- Observed: Hide Parallax Scene Studio Details
20+
21+
## Validation Commands and Results
22+
- `node --check tools/shared/platformShell.js` -> PASS
23+
- `node --check tools/toolRegistry.js` -> PASS
24+
- Browser validation (Parallax Scene Studio: normal mode, fullscreen, exit fullscreen) -> PASS
25+
- Visible text scan for `Header and Intro`, `Hide Header and Details`, `Show Header and Details` -> PASS (no hits)
26+
- Evidence file: tmp/pr_tool_fix_parallax_header_metadata_validation.json
27+
28+
## Verified State Text
29+
- Normal open: Hide Parallax Scene Studio Details
30+
- Fullscreen collapsed: Parallax Scene Studio — Layered Scene & Depth Composition
31+
- Fullscreen open: Hide Parallax Scene Studio Details
32+
- Normal after fullscreen exit: Hide Parallax Scene Studio Details
33+
34+
## Remaining Issues
35+
- None identified in this scoped validation.
36+
37+
## Scope Confirmation
38+
- No KOTI files modified.
39+
- No sample game files modified.
40+
- No runtime engine files modified.
41+
- No start_of_day folders modified.

0 commit comments

Comments
 (0)