Skip to content

Commit b97104f

Browse files
ToolboxAidToolboxAid
committed
Complete Asset Manager V2 schema naming, layout, status, and undo redo polish - PR_26126_088-asset-manager-v2-schema-ui-complete-pass
1 parent 5539765 commit b97104f

18 files changed

Lines changed: 1861 additions & 325 deletions

‎docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# PR_26126_088 Asset Manager V2 Manual Validation Notes
2+
3+
Date: 2026-05-06
4+
5+
## Validation Performed
6+
7+
- Ran `npm run test:workspace-v2`.
8+
- Ran JS syntax checks on touched Asset Manager V2 modules and the Playwright baseline.
9+
- Ran `git diff --check`.
10+
- Confirmed no JSON files changed.
11+
12+
## Results
13+
14+
- `npm run test:workspace-v2`: passed, 10 tests.
15+
- Schema naming consistency: passed. UI/output tests validate `id`, `type`, `kind`, `role`, and `path`, while Workspace V2 insertion remains schema-valid.
16+
- Radio alignment: passed. Kind radios align left.
17+
- Localization label fit: passed.
18+
- Fullscreen layout: passed. Left and right panels align to shell edges and center expands between them.
19+
- Tile wrapping: passed under fullscreen-expanded center width, while normal width stacks vertically.
20+
- Delete placement: passed. Delete is left of `type:role`.
21+
- Tooltip details: passed. Tile tooltip contains `id`, `type`, `kind`, `role`, and `path`.
22+
- Status-only add/delete/update messages: passed.
23+
- Pick Asset File role reset: passed. Role resets to the selected kind default before filename background/bezel logic.
24+
- Undo/Redo: passed for update and delete flows.
25+
- Workspace V2 insertion: passed. Audio asset inserts only into `tools.asset-browser.assets`.
26+
- Sample JSON: passed. No JSON files were modified.
27+
28+
## Reports
29+
30+
- `docs/dev/reports/playwright_v8_coverage_report.txt`
31+
- `docs/dev/reports/coverage_changed_js_guardrail.txt`
32+
- `docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md`
33+
- `docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md`
34+
- `docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md`
35+
- `docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md`
36+

‎docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26126_088 Asset Manager V2 Schema Consistency Notes
2+
3+
Date: 2026-05-06
4+
5+
## Scope
6+
7+
- Asset Manager V2 keeps the persisted Workspace V2 asset schema contract strict.
8+
- Stored Workspace entries continue to use schema fields `path`, `kind`, `role`, and `source`.
9+
- The visible Assets list and default Output Summary now expose compact display fields `id`, `type`, `kind`, `role`, and `path`.
10+
- `type` is the display alias for the schema `kind` value; both are shown in Output Summary and tile tooltips so the UI naming is explicit.
11+
12+
## Naming Changes
13+
14+
- Removed remaining visible "approved asset" wording from the Asset Manager V2 surface and current tools index planned text.
15+
- Replaced visible load messaging with `Kinds` and `Roles`.
16+
- Replaced validation wording that referenced "asset id" with `id`.
17+
- Kept Workspace V2 insertion at `workspaceManifest.tools["asset-browser"].assets`, using schema-valid entries with `kind`, `role`, `path`, and `source`.
18+
- Default Output Summary is a compact display summary and does not include add, delete, or update status messages.
19+
20+
## Validation
21+
22+
- `npm run test:workspace-v2`: passed, 10 tests.
23+
- Playwright validates the first selected image output includes `id`, `type`, `kind`, `role`, and `path`.
24+
- Playwright validates Workspace V2 insertion still writes the schema-valid audio asset entry to `tools.asset-browser.assets`.
25+
- `git diff --name-only -- "*.json"` returned no changed JSON files, so sample JSON was not modified.
26+

‎docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26126_088 Asset Manager V2 UI Layout Notes
2+
3+
Date: 2026-05-06
4+
5+
## Layout Changes
6+
7+
- Asset kind radio labels align their radio inputs to the left.
8+
- The Localization radio label uses a smaller font size so it fits cleanly.
9+
- Fullscreen-active Asset Manager V2 uses a full-width app shell, left panel aligned to the left edge, right panel aligned to the right edge, and a center panel that expands between them.
10+
- Assets tiles use a responsive grid with `repeat(auto-fit, minmax(220px, 1fr))`, allowing horizontal wrapping when width is available and vertical stacking when it is not.
11+
- Each asset tile places Delete to the left of the `type:role` display.
12+
- Asset detail text moved from the visible preview area into each tile tooltip.
13+
- Visible tile content stays compact: Delete, `type:role`, and ID only.
14+
15+
## Status-Only Messages
16+
17+
- Add, delete, and update action messages are written only to Status.
18+
- Asset Controls form messaging does not echo `Added`, `Deleted`, or `Updated` messages.
19+
- Output Summary does not display those action messages.
20+
- Asset tiles do not display those action messages.
21+
22+
## Validation
23+
24+
- `npm run test:workspace-v2`: passed, 10 tests.
25+
- Playwright validates radio alignment, Localization label fit, fullscreen panel edge alignment, center panel expansion, tile wrapping, Delete placement, tooltip details, and compact tile text.
26+

‎docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# PR_26126_088 Asset Manager V2 Undo Redo Behavior Notes
2+
3+
Date: 2026-05-06
4+
5+
## Behavior
6+
7+
- Asset Manager V2 now tracks local asset-state history for add, delete, and update operations.
8+
- Undo restores the previous validated asset map and selected asset.
9+
- Redo reapplies the undone validated asset map and selected asset.
10+
- Undo and Redo update:
11+
- Assets display
12+
- Output Summary
13+
- Status
14+
- Asset Controls history button state
15+
- New add, delete, or update operations clear the redo stack.
16+
17+
## Edit Operation
18+
19+
- Selecting an asset tile loads its `id`, `kind`, `role`, and `path` into Asset Controls.
20+
- Update Asset validates the edited entry through the same schema validator used by Add.
21+
- Renaming an ID during update is allowed only when the target ID is not already present.
22+
23+
## Validation
24+
25+
- `npm run test:workspace-v2`: passed, 10 tests.
26+
- Playwright validates Update Asset by changing an audio asset path.
27+
- Playwright validates Undo restores the previous path and Redo reapplies the updated path.
28+
- Playwright validates deleting an image asset, Undo restoring it, and Redo deleting it again.
29+

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 27 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,37 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5+
M tools/asset-manager-v2/README.md
56
M tools/asset-manager-v2/index.html
6-
M tools/asset-manager-v2/js/controls/AccordionSection.js
7+
M tools/asset-manager-v2/js/AssetManagerV2App.js
8+
M tools/asset-manager-v2/js/bootstrap.js
9+
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
10+
M tools/asset-manager-v2/js/controls/AssetFormControl.js
11+
M tools/asset-manager-v2/js/services/AssetSchemaValidator.js
712
M tools/asset-manager-v2/styles/assetManager.css
813
M tools/index.html
9-
?? docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md
10-
?? docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md
14+
?? docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md
15+
?? docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md
16+
?? docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md
17+
?? docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md
1118

1219
# git ls-files --others --exclude-standard
13-
docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md
14-
docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md
20+
docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md
21+
docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md
22+
docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md
23+
docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md
1524

1625
# git diff --stat
17-
docs/dev/reports/coverage_changed_js_guardrail.txt | 1 +
18-
docs/dev/reports/playwright_v8_coverage_report.txt | 4 +-
19-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 62 ++++++++++++++++++++++
20-
tools/asset-manager-v2/index.html | 6 +--
21-
.../js/controls/AccordionSection.js | 7 +++
22-
tools/asset-manager-v2/styles/assetManager.css | 13 ++++-
23-
tools/index.html | 8 +++
24-
7 files changed, 95 insertions(+), 6 deletions(-)
26+
docs/dev/reports/coverage_changed_js_guardrail.txt | 10 +-
27+
docs/dev/reports/playwright_v8_coverage_report.txt | 26 +--
28+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 155 ++++++++++++++++--
29+
tools/asset-manager-v2/README.md | 4 +-
30+
tools/asset-manager-v2/index.html | 23 +--
31+
tools/asset-manager-v2/js/AssetManagerV2App.js | 181 +++++++++++++++++++--
32+
tools/asset-manager-v2/js/bootstrap.js | 3 +
33+
.../js/controls/AssetCatalogControl.js | 28 ++--
34+
.../js/controls/AssetFormControl.js | 54 +++++-
35+
.../js/services/AssetSchemaValidator.js | 14 +-
36+
tools/asset-manager-v2/styles/assetManager.css | 112 ++++++++++++-
37+
tools/index.html | 2 +-
38+
12 files changed, 525 insertions(+), 87 deletions(-)

0 commit comments

Comments
 (0)