Skip to content

Commit d612109

Browse files
ToolboxAidToolboxAid
committed
Activate Sprites toolbox entry
1 parent 1b49270 commit d612109

13 files changed

Lines changed: 573 additions & 161 deletions

‎docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active.md‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# PR_26177_CHARLIE_017-sprites-toolbox-entry-active
2+
3+
## Summary
4+
5+
Team Charlie activated the Sprites entry on the Toolbox landing page.
6+
7+
This PR keeps the change scoped to Toolbox entry state and targeted coverage:
8+
9+
- Sprites now publishes the source-controlled Toolbox release channel as `wireframe`.
10+
- The Local API Toolbox metadata sync now treats Sprites as source-controlled so the API-backed landing page receives the active state.
11+
- Toolbox landing coverage verifies Sprites is visible, not planned, and links to `/toolbox/sprites/index.html`.
12+
- Toolbox route coverage verifies the Sprites card opens the Sprites route.
13+
- No Sprites API, database, CRUD, import, preview, palette, tags, or reference behavior changed.
14+
15+
## Changed Files
16+
17+
- `src/dev-runtime/server/local-api-router.mjs`
18+
- `src/shared/toolbox/tool-metadata-inventory.js`
19+
- `tests/playwright/tools/ToolNavigationPrevNext.spec.mjs`
20+
- `tests/playwright/tools/ToolboxRoutePages.spec.mjs`
21+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
22+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
23+
- `docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active.md`
24+
- `docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_branch-validation.md`
25+
- `docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_manual-validation-notes.md`
26+
- `docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_requirements-checklist.md`
27+
- `docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_validation-lane.md`
28+
- `docs_build/dev/reports/codex_changed_files.txt`
29+
- `docs_build/dev/reports/codex_review.diff`
30+
31+
## Implementation Notes
32+
33+
- `/toolbox/index.html` required no direct markup edit because the landing page renders cards from the API-backed Toolbox registry contract.
34+
- Added `releaseChannel: "wireframe"` to the Sprites registry entry so it is active/clickable while still labeled as a wireframe.
35+
- Added Sprites to the Local API source-controlled Toolbox metadata set so stale persisted metadata rows cannot keep the card in the planned bucket.
36+
- Preserved existing Toolbox card order, routes, Theme V2 rendering, and Sprites route behavior.
37+
38+
## Validation
39+
40+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
41+
- PASS: `node --check src/shared/toolbox/tool-metadata-inventory.js`
42+
- PASS: `node --check tests/playwright/tools/ToolNavigationPrevNext.spec.mjs`
43+
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
44+
- PASS: `npx playwright test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs -g "Toolbox card names link" --workers=1 --reporter=list`
45+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index|toolbox status kickers|Build Path status" --workers=1 --reporter=list`
46+
- PASS: direct Local API `/api/toolbox/registry/snapshot` probe confirmed Sprites route `toolbox/sprites/index.html` and release channel `wireframe`.
47+
- PASS: `git diff --check`
48+
- PASS: no `start_of_day` files changed.
49+
50+
## Validation Note
51+
52+
- BLOCKED unrelated adjacent check: `npx playwright test tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs -g "share the same DB-backed metadata" --workers=1 --reporter=list` fails before Toolbox assertions because `GET /api/local-db/snapshot` returns `Unknown API route`. The failure is outside this PR's Sprites Toolbox entry scope.
53+
54+
## ZIP
55+
56+
- `tmp/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_delta.zip`

‎docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_branch-validation.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26177_CHARLIE_017 Branch Validation
2+
3+
## Branch
4+
5+
- Branch: `PR_26177_CHARLIE_017-sprites-toolbox-entry-active`
6+
- Start branch: `main`
7+
- Main start commit: `1b49270c469d12a107823e9b0a85c9300c09fea5`
8+
9+
## Checks
10+
11+
| Check | Result | Notes |
12+
| --- | --- | --- |
13+
| Started from `main` | PASS | Main was fetched and fast-forwarded before branch recreation. |
14+
| Main/local sync before branch work | PASS | `git rev-list --left-right --count main...origin/main` returned `0 0`. |
15+
| Worktree clean before branch work | PASS | Startup status check returned no changes. |
16+
| One PR purpose only | PASS | Only the Sprites Toolbox entry state and targeted coverage changed. |
17+
| No `start_of_day` changes | PASS | Changed-file list contains no `start_of_day` paths. |
18+
| No Sprites API/DB/CRUD behavior change | PASS | No Sprites implementation files were changed. |
19+
| Theme V2 patterns preserved | PASS | Existing Toolbox registry and landing page rendering remain in use. |
20+
| Repo-structured ZIP created | PASS | `tmp/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_delta.zip`. |
21+
22+
## Result
23+
24+
PASS

‎docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_manual-validation-notes.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26177_CHARLIE_017 Manual Validation Notes
2+
3+
## Manual Checks
4+
5+
- PASS: Confirmed the Local API Toolbox registry snapshot returns Sprites with `releaseChannel: "wireframe"`.
6+
- PASS: Confirmed the Local API Toolbox registry snapshot returns Sprites route `toolbox/sprites/index.html`.
7+
- PASS: Confirmed the Toolbox landing page renders a visible Sprites card in the default active set.
8+
- PASS: Confirmed the Sprites card action label is `Open Tool`, not `Planned Details`.
9+
- PASS: Confirmed targeted Playwright clicks the Sprites card from `/toolbox/index.html` and lands on `/toolbox/sprites/index.html`.
10+
- PASS: Confirmed `toolbox/index.html` static markup did not require a direct edit because the page is registry/API-driven.
11+
- PASS: Confirmed no `start_of_day` paths were changed.
12+
13+
## Notes
14+
15+
- Sprites remains a wireframe tool; this PR only activates the Toolbox landing entry and route clickability.
16+
- No Sprites implementation behavior changed.

‎docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_requirements-checklist.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26177_CHARLIE_017 Requirement Checklist
2+
3+
| Requirement | Result | Notes |
4+
| --- | --- | --- |
5+
| Use main branch only for startup | PASS | Main was checked out, fetched, fast-forwarded, and verified synced before branch creation. |
6+
| Hard stop if worktree not clean | PASS | Worktree was clean before branch work. |
7+
| Recreate `PR_26177_CHARLIE_017-sprites-toolbox-entry-active` from updated main | PASS | Stale empty local branch was deleted and recreated from updated main. |
8+
| Update `/toolbox/index.html` only as needed | PASS | No direct static edit was needed because the page is registry/API-driven. |
9+
| Change Sprites from planned/inactive to active/clickable | PASS | Sprites now resolves to `wireframe`, appears in default Toolbox results, and renders `Open Tool`. |
10+
| Link Sprites to `toolbox/sprites/index.html` | PASS | API snapshot and Playwright assert the route. |
11+
| Preserve Toolbox card/menu order and Theme V2 patterns | PASS | Existing registry order and card rendering remain unchanged. |
12+
| Do not change Sprites API, DB, CRUD, import, preview, palette, tags, or reference behavior | PASS | No Sprites tool files or Sprites service contracts changed. |
13+
| Add targeted Playwright coverage for clickable Sprites entry | PASS | `ToolNavigationPrevNext` clicks the Sprites card; `ToolboxRoutePages` asserts the active landing card. |
14+
| No unrelated cleanup | PASS | Changes are scoped to Toolbox metadata sync, registry state, tests, and reports. |
15+
| Do not modify `start_of_day` folders | PASS | No changed paths under `start_of_day`. |
16+
| Create required reports and ZIP | PASS | Required report set and delta ZIP were generated. |

‎docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_validation-lane.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# PR_26177_CHARLIE_017 Validation Lane
2+
3+
## Commands
4+
5+
| Command | Result |
6+
| --- | --- |
7+
| `node --check src/dev-runtime/server/local-api-router.mjs` | PASS |
8+
| `node --check src/shared/toolbox/tool-metadata-inventory.js` | PASS |
9+
| `node --check tests/playwright/tools/ToolNavigationPrevNext.spec.mjs` | PASS |
10+
| `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs` | PASS |
11+
| `npx playwright test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs -g "Toolbox card names link" --workers=1 --reporter=list` | PASS, 1 test |
12+
| `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index\|toolbox status kickers\|Build Path status" --workers=1 --reporter=list` | PASS, 3 tests |
13+
| Direct Local API `/api/toolbox/registry/snapshot` probe | PASS, Sprites route and `wireframe` release channel returned |
14+
| `git diff --check` | PASS |
15+
| `git ls-files --modified --others --exclude-standard \| Select-String -Pattern '(^\|/)start_of_day(/\|$)'` | PASS, no output |
16+
17+
## Playwright
18+
19+
Impacted: Yes, Toolbox landing page and Sprites route clickability changed.
20+
21+
Result: PASS for targeted Toolbox landing and route coverage.
22+
23+
## Adjacent Validation
24+
25+
`npx playwright test tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs -g "share the same DB-backed metadata" --workers=1 --reporter=list`
26+
27+
Result: BLOCKED by unrelated `Unknown API route: GET /api/local-db/snapshot` before Toolbox assertions.
28+
29+
## Full Samples Smoke
30+
31+
Not run. Not required for this targeted Toolbox entry PR.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,28 @@
1-
docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md
2-
docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md
3-
docs_build/dev/reports/PR_26177_DELTA_001-hitboxes-team-ownership.md
4-
docs_build/dev/reports/PR_26177_DELTA_001-hitboxes-team-ownership_branch-validation.md
5-
docs_build/dev/reports/PR_26177_DELTA_001-hitboxes-team-ownership_validation-checklist.md
6-
docs_build/dev/reports/codex_changed_files.txt
7-
docs_build/dev/reports/codex_review.diff
1+
# git status --short
2+
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
3+
M docs_build/dev/reports/playwright_v8_coverage_report.txt
4+
M src/dev-runtime/server/local-api-router.mjs
5+
M src/shared/toolbox/tool-metadata-inventory.js
6+
M tests/playwright/tools/ToolNavigationPrevNext.spec.mjs
7+
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
8+
?? docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active.md
9+
?? docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_branch-validation.md
10+
?? docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_manual-validation-notes.md
11+
?? docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_requirements-checklist.md
12+
?? docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_validation-lane.md
13+
14+
# git ls-files --others --exclude-standard
15+
docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active.md
16+
docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_branch-validation.md
17+
docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_manual-validation-notes.md
18+
docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_requirements-checklist.md
19+
docs_build/dev/reports/PR_26177_CHARLIE_017-sprites-toolbox-entry-active_validation-lane.md
20+
21+
# git diff --stat
22+
.../dev/reports/coverage_changed_js_guardrail.txt | 6 ++--
23+
.../dev/reports/playwright_v8_coverage_report.txt | 33 +++++++++++-----------
24+
src/dev-runtime/server/local-api-router.mjs | 2 +-
25+
src/shared/toolbox/tool-metadata-inventory.js | 5 ++--
26+
.../tools/ToolNavigationPrevNext.spec.mjs | 13 +++++++++
27+
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 23 ++++++++-------
28+
6 files changed, 51 insertions(+), 31 deletions(-)

0 commit comments

Comments
 (0)