diff --git a/packages/main/src/components/FilterBar/FilterBar.cy.tsx b/packages/main/src/components/FilterBar/FilterBar.cy.tsx index f6b1f8b6254..d69875051e6 100644 --- a/packages/main/src/components/FilterBar/FilterBar.cy.tsx +++ b/packages/main/src/components/FilterBar/FilterBar.cy.tsx @@ -424,9 +424,8 @@ describe('FilterBar.cy.tsx', () => { , ); - cy.findByText('Go').should('be.visible'); - cy.get('[ui5-toolbar-item]').should('exist'); - cy.get('[ui5-toolbar-item] [ui5-button]').should('have.attr', 'accessible-description', 'Show Results'); + cy.findToolbarButtonByText('Go').should('be.visible'); + cy.findToolbarButtonByText('Go').should('have.attr', 'accessible-description', 'Show Results'); cy.findToolbarButtonByText('Filters').should('be.visible'); cy.findToolbarButtonByText('Adapt Filters').should('not.exist'); cy.findToolbarButtonByText('Hide Filter Bar').should('be.visible'); @@ -447,7 +446,6 @@ describe('FilterBar.cy.tsx', () => { ); cy.findByText('Go').should('be.visible'); - cy.get('[ui5-toolbar-item]').should('not.exist'); cy.get('[ui5-button]').should('have.attr', 'accessible-description', 'Show Results'); cy.findByText('Filters').should('not.exist'); cy.findByText('Adapt Filters').should('be.visible'); @@ -508,7 +506,7 @@ describe('FilterBar.cy.tsx', () => { , ); - cy.findByText('Go').click({ force: true }); + cy.get('[text="Go"]').click({ force: true }); cy.get('@go').should('have.been.calledOnce'); cy.get('[text="Clear"]').click({ force: true }); diff --git a/packages/main/src/components/FilterBar/index.tsx b/packages/main/src/components/FilterBar/index.tsx index a4cae5257ac..4444708b5f8 100644 --- a/packages/main/src/components/FilterBar/index.tsx +++ b/packages/main/src/components/FilterBar/index.tsx @@ -27,7 +27,6 @@ import { Icon } from '../../webComponents/Icon/index.js'; import { Toolbar } from '../../webComponents/Toolbar/index.js'; import type { ToolbarButtonDomRef } from '../../webComponents/ToolbarButton/index.js'; import { ToolbarButton } from '../../webComponents/ToolbarButton/index.js'; -import { ToolbarItem } from '../../webComponents/ToolbarItem/index.js'; import { FilterGroupItem } from '../FilterGroupItem/index.js'; import type { FilterGroupItemInternalProps } from '../FilterGroupItem/types.js'; import { FlexBox } from '../FlexBox/index.js'; @@ -235,14 +234,18 @@ const FilterBar = forwardRef((props, ref) => const filtersButtonText = `${filtersText}${ activeFiltersCount && parseInt(activeFiltersCount as string, 10) ? ` (${activeFiltersCount})` : '' }`; - const GoButton = showGoOnFB && ( - - ); const FBButtons = ( <> - {showGoOnFB && (hideToolbar ? GoButton : {GoButton})} + {showGoOnFB && ( + + {hideToolbar ? goText : undefined} + + )} {!hideToggleFiltersButton && !hideToolbar && !isPhone && (