From 9715196f60cd0c80c5cf086def69bfb87927b880 Mon Sep 17 00:00:00 2001 From: Ariana Chowdhury Date: Tue, 13 Oct 2026 18:17:48 -0500 Subject: [PATCH 1/2] Added lint-check.yml to fail pr when user does not run make check before making a pr --- .github/workflows/lint-check.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/workflows/lint-check.yml diff --git a/.github/workflows/lint-check.yml b/.github/workflows/lint-check.yml new file mode 100644 index 0000000..d47ddda --- /dev/null +++ b/.github/workflows/lint-check.yml @@ -0,0 +1,30 @@ +name: Lint check + +on: + push: + branches: develop + pull_request: + branches: develop + workflow_dispatch: + +jobs: + build_ubuntu: + runs-on: ubuntu-latest + steps: + + - name: Checkout + uses: actions/checkout@v4 + + - name: Set up Go + uses: actions/setup-go@v5 + with: + go-version: '1.26' + + - name: Setup + run: make setup + + - name: Check + run: make check + + - name: Fail if files changed + run: git diff --exit-code \ No newline at end of file From 711b0b9ff9d559d258aed99565505611b167c13c Mon Sep 17 00:00:00 2001 From: Ariana Chowdhury Date: Wed, 14 Oct 2026 11:49:34 -0500 Subject: [PATCH 2/2] Moved git diff check to go.yml --- .github/workflows/go.yml | 3 +++ .github/workflows/lint-check.yml | 30 ------------------------------ 2 files changed, 3 insertions(+), 30 deletions(-) delete mode 100644 .github/workflows/lint-check.yml diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 5ff2d04..45438e7 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -30,6 +30,9 @@ jobs: - name: Check run: make check + - name: Fail if files changed + run: git diff --exit-code + - name: Test env: LOGIN_NETID: ${{ secrets.LOGIN_NETID }} diff --git a/.github/workflows/lint-check.yml b/.github/workflows/lint-check.yml deleted file mode 100644 index d47ddda..0000000 --- a/.github/workflows/lint-check.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: Lint check - -on: - push: - branches: develop - pull_request: - branches: develop - workflow_dispatch: - -jobs: - build_ubuntu: - runs-on: ubuntu-latest - steps: - - - name: Checkout - uses: actions/checkout@v4 - - - name: Set up Go - uses: actions/setup-go@v5 - with: - go-version: '1.26' - - - name: Setup - run: make setup - - - name: Check - run: make check - - - name: Fail if files changed - run: git diff --exit-code \ No newline at end of file