From d44142d67e9b247d20d85a0ee42e023b74fc3109 Mon Sep 17 00:00:00 2001 From: Sam Mason de Caires Date: Tue, 20 Oct 2026 11:35:03 +0100 Subject: [PATCH] chore: remove deprecated narval wallet connector Co-Authored-By: Claude Opus 5.5 --- .env.development | 1 - .env.example | 1 - .github/actions/build/action.yml | 5 ----- .github/workflows/build-test-deploy-dev.yml | 1 - .github/workflows/build-test-deploy.yml | 1 - package.json | 1 - pnpm-lock.yaml | 24 --------------------- src/ui-config/wagmiConfig.ts | 17 +-------------- 8 files changed, 1 insertion(+), 50 deletions(-) diff --git a/.env.development b/.env.development index 9ce64c9061..f0a0b4f66f 100644 --- a/.env.development +++ b/.env.development @@ -5,7 +5,6 @@ NEXT_PUBLIC_FIAT_ON_RAMP=false #NEXT_PUBLIC_FORK_CHAIN_ID=1 #NEXT_PUBLIC_FORK_URL_RPC="https://rpc.tenderly.co/fork/1234567" NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID= -NEXT_PUBLIC_NARVAL_CLIENT_ID= NEXT_PUBLIC_ENABLE_STAKING=true NEXT_PUBLIC_ENABLE_GOVERNANCE=true NEXT_PUBLIC_API_BASEURL=https://aave-api-v2.aave.com diff --git a/.env.example b/.env.example index 2c487d73c8..dff3a73a25 100644 --- a/.env.example +++ b/.env.example @@ -18,7 +18,6 @@ NEXT_PUBLIC_FORK_BASE_CHAIN_ID= NEXT_PUBLIC_FORK_CHAIN_ID= NEXT_PUBLIC_FORK_URL_RPC= NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID= -NEXT_PUBLIC_NARVAL_CLIENT_ID= NEXT_PUBLIC_MIXPANEL= NEXT_PUBLIC_FIAT_ON_RAMP=true NEXT_PUBLIC_IS_CYPRESS_ENABLED=false diff --git a/.github/actions/build/action.yml b/.github/actions/build/action.yml index ce5ebea35f..005432b88b 100644 --- a/.github/actions/build/action.yml +++ b/.github/actions/build/action.yml @@ -37,10 +37,6 @@ inputs: description: wallet connect project id required: false default: '' - NEXT_PUBLIC_NARVAL_CLIENT_ID: - description: narval client id - required: false - default: '' NEXT_PUBLIC_IS_CYPRESS_ENABLED: description: enables cypress required: false @@ -93,6 +89,5 @@ runs: NEXT_PUBLIC_MIXPANEL: '${{ inputs.NEXT_PUBLIC_MIXPANEL }}' NEXT_PUBLIC_FIAT_ON_RAMP: 'false' NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID: '${{ inputs.NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID }}' - NEXT_PUBLIC_NARVAL_CLIENT_ID: '${{ inputs.NEXT_PUBLIC_NARVAL_CLIENT_ID }}' NEXT_PUBLIC_IS_CYPRESS_ENABLED: '${{ inputs.NEXT_PUBLIC_IS_CYPRESS_ENABLED }}' NEXT_PUBLIC_FUNKIT_API_KEY: '${{ inputs.NEXT_PUBLIC_FUNKIT_API_KEY }}' diff --git a/.github/workflows/build-test-deploy-dev.yml b/.github/workflows/build-test-deploy-dev.yml index ebee46fff0..4ad81168b9 100644 --- a/.github/workflows/build-test-deploy-dev.yml +++ b/.github/workflows/build-test-deploy-dev.yml @@ -41,7 +41,6 @@ jobs: NEXT_PUBLIC_MIXPANEL: ${{ secrets.NEXT_PUBLIC_MIXPANEL }} NEXT_PUBLIC_FIAT_ON_RAMP: 'false' NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID: ${{ secrets.WALLET_CONNECT_PROJECT_ID }} - NEXT_PUBLIC_NARVAL_CLIENT_ID: ${{ secrets.NEXT_PUBLIC_NARVAL_CLIENT_ID }} NEXT_PUBLIC_IS_CYPRESS_ENABLED: ${{ matrix.build.cypress_enabled }} NEXT_PUBLIC_FUNKIT_API_KEY: ${{ secrets.FUNKIT_API_KEY }} diff --git a/.github/workflows/build-test-deploy.yml b/.github/workflows/build-test-deploy.yml index 558b15b012..d83ca38483 100644 --- a/.github/workflows/build-test-deploy.yml +++ b/.github/workflows/build-test-deploy.yml @@ -38,7 +38,6 @@ jobs: NEXT_PUBLIC_MIXPANEL: ${{ secrets.NEXT_PUBLIC_MIXPANEL }} NEXT_PUBLIC_FIAT_ON_RAMP: 'false' NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID: ${{ secrets.WALLET_CONNECT_PROJECT_ID }} - NEXT_PUBLIC_NARVAL_CLIENT_ID: ${{ secrets.NEXT_PUBLIC_NARVAL_CLIENT_ID }} NEXT_PUBLIC_IS_CYPRESS_ENABLED: ${{ matrix.build.cypress_enabled }} NEXT_PUBLIC_FUNKIT_API_KEY: ${{ secrets.FUNKIT_API_KEY }} diff --git a/package.json b/package.json index d0d9bdfc65..838ac9213b 100644 --- a/package.json +++ b/package.json @@ -78,7 +78,6 @@ "@mui/icons-material": "^5.10.14", "@mui/lab": "5.0.0-alpha.103", "@mui/material": "^5.10.9", - "@narval-xyz/connect": "1.0.1", "@number-flow/react": "^0.5.10", "@paraswap/sdk": "6.10.0", "@safe-global/safe-apps-provider": "^0.18.4", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 16c4a38bac..aafc73615c 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -96,9 +96,6 @@ importers: '@mui/material': specifier: ^5.10.9 version: 5.18.0(@emotion/react@11.10.4(@babel/core@7.29.7)(@types/react@18.3.31)(react@18.3.1))(@emotion/styled@11.10.4(@babel/core@7.29.7)(@emotion/react@11.10.4(@babel/core@7.29.7)(@types/react@18.3.31)(react@18.3.1))(@types/react@18.3.31)(react@18.3.1))(@types/react@18.3.31)(react-dom@18.3.1(react@18.3.1))(react@18.3.1) - '@narval-xyz/connect': - specifier: 1.0.1 - version: 1.0.1(@tanstack/react-query@5.101.2(react@18.3.1))(@wagmi/core@2.22.1(@tanstack/query-core@5.101.2)(@types/react@18.3.31)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(use-sync-external-store@1.4.0(react@18.3.1))(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76)))(react@18.3.1)(typescript@5.9.3)(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76))(wagmi@2.19.5(@tanstack/query-core@5.101.2)(@tanstack/react-query@5.101.2(react@18.3.1))(@types/react@18.3.31)(bufferutil@4.1.0)(fastestsmallesttextencoderdecoder@1.0.22)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(utf-8-validate@6.0.6)(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76))(zod@3.25.76)) '@number-flow/react': specifier: ^0.5.10 version: 0.5.14(react-dom@18.3.1(react@18.3.1))(react@18.3.1) @@ -2447,15 +2444,6 @@ packages: '@emnapi/core': ^1.7.1 '@emnapi/runtime': ^1.7.1 - '@narval-xyz/connect@1.0.1': - resolution: {integrity: sha512-inXus1eycMjw2o+SkPIkyYC3Hi4OIlx25SMldx1Uof9vuzXx2tqW01t7cp0CAIkZRkHOsW2DolCMY+TiYi2r+g==} - peerDependencies: - '@tanstack/react-query': '>=5.0.0' - '@wagmi/core': '>=2.0.0' - react: '>=18.0.0' - viem: '>=2.16.2' - wagmi: '>=2.0.0' - '@next/bundle-analyzer@12.3.7': resolution: {integrity: sha512-bUjEBnAtlHR+vorMbq8LJZTZryE0XmNDiVx96kgJjazyVx5+ogC17JEiBi1toNDiz21mfM4rAqDEiD8kgZEzSA==} @@ -13233,18 +13221,6 @@ snapshots: '@tybys/wasm-util': 0.10.3 optional: true - '@narval-xyz/connect@1.0.1(@tanstack/react-query@5.101.2(react@18.3.1))(@wagmi/core@2.22.1(@tanstack/query-core@5.101.2)(@types/react@18.3.31)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(use-sync-external-store@1.4.0(react@18.3.1))(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76)))(react@18.3.1)(typescript@5.9.3)(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76))(wagmi@2.19.5(@tanstack/query-core@5.101.2)(@tanstack/react-query@5.101.2(react@18.3.1))(@types/react@18.3.31)(bufferutil@4.1.0)(fastestsmallesttextencoderdecoder@1.0.22)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(utf-8-validate@6.0.6)(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76))(zod@3.25.76))': - dependencies: - '@tanstack/react-query': 5.101.2(react@18.3.1) - '@wagmi/core': 2.22.1(@tanstack/query-core@5.101.2)(@types/react@18.3.31)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(use-sync-external-store@1.4.0(react@18.3.1))(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76)) - ox: 0.9.17(typescript@5.9.3)(zod@4.4.3) - react: 18.3.1 - viem: 2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76) - wagmi: 2.19.5(@tanstack/query-core@5.101.2)(@tanstack/react-query@5.101.2(react@18.3.1))(@types/react@18.3.31)(bufferutil@4.1.0)(fastestsmallesttextencoderdecoder@1.0.22)(immer@9.0.21)(react@18.3.1)(typescript@5.9.3)(utf-8-validate@6.0.6)(viem@2.45.1(bufferutil@4.1.0)(typescript@5.9.3)(utf-8-validate@6.0.6)(zod@3.25.76))(zod@3.25.76) - zod: 4.4.3 - transitivePeerDependencies: - - typescript - '@next/bundle-analyzer@12.3.7(bufferutil@4.1.0)(utf-8-validate@6.0.6)': dependencies: webpack-bundle-analyzer: 4.3.0(bufferutil@4.1.0)(utf-8-validate@6.0.6) diff --git a/src/ui-config/wagmiConfig.ts b/src/ui-config/wagmiConfig.ts index 2b89cd3a58..69b5901b4c 100644 --- a/src/ui-config/wagmiConfig.ts +++ b/src/ui-config/wagmiConfig.ts @@ -1,4 +1,3 @@ -import { narval } from '@narval-xyz/connect/wagmi'; import { Emitter } from '@wagmi/core/internal'; import { getDefaultConfig } from 'connectkit'; import { @@ -81,7 +80,7 @@ const connectorConfig = { emitter: new Emitter(''), }; -const baseConnectors = prodCkConfig.connectors +const connectors = prodCkConfig.connectors ?.map((connector) => { // initialize the connector with the emitter so we can access the id const c = connector(connectorConfig); @@ -105,20 +104,6 @@ const baseConnectors = prodCkConfig.connectors return 0; }); -const narvalConnector = process.env.NEXT_PUBLIC_NARVAL_CLIENT_ID - ? narval({ - config: { - clientId: process.env.NEXT_PUBLIC_NARVAL_CLIENT_ID, - }, - // Must be injected, otherwise ConnectKit(v1.9.0) shows a "not installed" error message. - // Remove this once ConnectKit has a fix applied. - overrides: { - type: 'injected', - }, - }) - : undefined; -const connectors = narvalConnector ? [...(baseConnectors ?? []), narvalConnector] : baseConnectors; - const prodConfig = createConfig({ ...prodCkConfig, connectors,