From 0c740db2fb6e30c79281c771e02492a03fb40c5f Mon Sep 17 00:00:00 2001 From: Zeniel Chaves Date: Wed, 30 Sep 2026 14:15:18 +0200 Subject: [PATCH] Fix build with GCC 14: drop const from vector_of_kll_sketches k_ and d_ The copy and move assignment operators assign to k_ and d_, which are declared const. GCC 14 rejects this even though the templates are not instantiated ("assignment of read-only member"), so the package cannot be built from source on toolchains that ship GCC 14, such as the Debian trixie based python:3.14 images. Making the members non-const keeps the assignment operators well-formed without changing behaviour. --- src/vector_of_kll.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vector_of_kll.cpp b/src/vector_of_kll.cpp index 3bbe17b6..70139152 100644 --- a/src/vector_of_kll.cpp +++ b/src/vector_of_kll.cpp @@ -104,8 +104,8 @@ class vector_of_kll_sketches { template Array2D make_ndarray(size_t rows, size_t cols) const; - const uint32_t k_; // kll sketch k parameter - const uint32_t d_; // number of dimensions (here: sketches) to hold + uint32_t k_; // kll sketch k parameter + uint32_t d_; // number of dimensions (here: sketches) to hold std::vector> sketches_; };