From 10a8b6b0b5fca0551b0fd99a87b43db17ae3403b Mon Sep 17 00:00:00 2001 From: Anurag Singh Date: Wed, 11 Nov 2026 18:59:48 +0530 Subject: [PATCH 1/2] Serialize purgeRequested as a lowercase boolean in REST drop_table --- pyiceberg/catalog/rest/__init__.py | 2 +- tests/catalog/test_rest.py | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/pyiceberg/catalog/rest/__init__.py b/pyiceberg/catalog/rest/__init__.py index d284b06234..80ea32285a 100644 --- a/pyiceberg/catalog/rest/__init__.py +++ b/pyiceberg/catalog/rest/__init__.py @@ -1519,7 +1519,7 @@ def drop_table(self, identifier: str | Identifier, purge_requested: bool = False self._check_endpoint(Capability.V1_DELETE_TABLE) response = self._session.delete( self.url(Endpoints.drop_table, prefixed=True, **self._split_identifier_for_path(identifier)), - params={"purgeRequested": purge_requested}, + params={"purgeRequested": "true" if purge_requested else "false"}, headers=self._mutation_headers(), ) try: diff --git a/tests/catalog/test_rest.py b/tests/catalog/test_rest.py index 1160d2889a..0b4ea3db6a 100644 --- a/tests/catalog/test_rest.py +++ b/tests/catalog/test_rest.py @@ -2186,6 +2186,30 @@ def test_delete_table_204(rest_mock: Mocker) -> None: RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko")) +def test_delete_table_purge_requested_false(rest_mock: Mocker) -> None: + rest_mock.delete( + f"{TEST_URI}v1/namespaces/example/tables/fokko", + json={}, + status_code=204, + request_headers=TEST_HEADERS, + ) + RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko")) + + assert rest_mock.request_history[-1].url.endswith("?purgeRequested=false") + + +def test_delete_table_purge_requested_true(rest_mock: Mocker) -> None: + rest_mock.delete( + f"{TEST_URI}v1/namespaces/example/tables/fokko", + json={}, + status_code=204, + request_headers=TEST_HEADERS, + ) + RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko"), purge_requested=True) + + assert rest_mock.request_history[-1].url.endswith("?purgeRequested=true") + + def test_delete_table_from_self_identifier_204( rest_mock: Mocker, example_table_metadata_with_snapshot_v1_rest_json: dict[str, Any] ) -> None: From 01002b4f4515c2227ab242d878f50de7a2542d15 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Wed, 11 Nov 2026 09:51:09 -0800 Subject: [PATCH 2/2] Fold purgeRequested assertions into test_delete_table_204 and test purge_table Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- tests/catalog/test_rest.py | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/tests/catalog/test_rest.py b/tests/catalog/test_rest.py index 0b4ea3db6a..6480f51470 100644 --- a/tests/catalog/test_rest.py +++ b/tests/catalog/test_rest.py @@ -2183,31 +2183,24 @@ def test_delete_table_204(rest_mock: Mocker) -> None: status_code=204, request_headers=TEST_HEADERS, ) - RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko")) + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) + catalog.drop_table(("example", "fokko")) + assert rest_mock.last_request.url == f"{TEST_URI}v1/namespaces/example/tables/fokko?purgeRequested=false" -def test_delete_table_purge_requested_false(rest_mock: Mocker) -> None: - rest_mock.delete( - f"{TEST_URI}v1/namespaces/example/tables/fokko", - json={}, - status_code=204, - request_headers=TEST_HEADERS, - ) - RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko")) + catalog.drop_table(("example", "fokko"), purge_requested=True) + assert rest_mock.last_request.url == f"{TEST_URI}v1/namespaces/example/tables/fokko?purgeRequested=true" - assert rest_mock.request_history[-1].url.endswith("?purgeRequested=false") - -def test_delete_table_purge_requested_true(rest_mock: Mocker) -> None: +def test_purge_table_204(rest_mock: Mocker) -> None: rest_mock.delete( f"{TEST_URI}v1/namespaces/example/tables/fokko", json={}, status_code=204, request_headers=TEST_HEADERS, ) - RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko"), purge_requested=True) - - assert rest_mock.request_history[-1].url.endswith("?purgeRequested=true") + RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).purge_table(("example", "fokko")) + assert rest_mock.last_request.url == f"{TEST_URI}v1/namespaces/example/tables/fokko?purgeRequested=true" def test_delete_table_from_self_identifier_204(