From dfdb8ca2ef7035624ea5337c0f86b6ec6f9ce86c Mon Sep 17 00:00:00 2001 From: Szehon Ho Date: Mon, 26 Oct 2026 17:06:58 -0700 Subject: [PATCH 1/3] Clarify signing key setup for non-PMC release managers --- release-process.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/release-process.md b/release-process.md index c818ffe31e..dbc390721d 100644 --- a/release-process.md +++ b/release-process.md @@ -139,15 +139,21 @@ To get the code signing key (a.k.a ASCII-armored public key), run the command: $ gpg --export --armor 3FF6D044 ``` -And then append the generated key to the KEYS file by: +And then append the generated key to the staging KEYS file by: ``` -# Move dev/ to release/ when the voting is completed. See Finalize the Release below svn co --depth=files "https://dist.apache.org/repos/dist/dev/spark" svn-spark # edit svn-spark/KEYS file svn ci --username $ASF_USERNAME --password "$ASF_PASSWORD" -m"Update KEYS" ``` +Release vote emails link to the +[release KEYS file](https://downloads.apache.org/spark/KEYS), so your signing key must also be +published there before starting a vote. Only PMC members can update +[`release/spark/KEYS`](https://dist.apache.org/repos/dist/release/spark/KEYS). If you are a +committer who is not a PMC member, ask your PMC shepherd to add your key to that file. +Adding the key only to `dev/spark/KEYS` does not update the release copy. + If you want to do the release on another machine, you can transfer your secret key to that machine via the `gpg --export-secret-keys` and `gpg --import` commands. From 1bb24a64f23f3b95e66083ceb1c1261fbfe23133 Mon Sep 17 00:00:00 2001 From: Szehon Ho Date: Mon, 26 Oct 2026 17:14:04 -0700 Subject: [PATCH 2/3] Describe checking and adding missing release signing keys --- release-process.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/release-process.md b/release-process.md index dbc390721d..e41c04f6fd 100644 --- a/release-process.md +++ b/release-process.md @@ -147,11 +147,11 @@ svn co --depth=files "https://dist.apache.org/repos/dist/dev/spark" svn-spark svn ci --username $ASF_USERNAME --password "$ASF_PASSWORD" -m"Update KEYS" ``` -Release vote emails link to the -[release KEYS file](https://downloads.apache.org/spark/KEYS), so your signing key must also be -published there before starting a vote. Only PMC members can update -[`release/spark/KEYS`](https://dist.apache.org/repos/dist/release/spark/KEYS). If you are a -committer who is not a PMC member, ask your PMC shepherd to add your key to that file. +Before starting a release vote, check that your signing key is in the +[release KEYS file](https://downloads.apache.org/spark/KEYS) linked from vote emails. +If your key is missing, add it to +[`release/spark/KEYS`](https://dist.apache.org/repos/dist/release/spark/KEYS) if you are a PMC member, +or ask your PMC shepherd to add it for you. Adding the key only to `dev/spark/KEYS` does not update the release copy. If you want to do the release on another machine, you can transfer your secret key to that machine From 962c060d64901739ea6078833d910ff3ac9e72c2 Mon Sep 17 00:00:00 2001 From: Szehon Ho Date: Fri, 13 Nov 2026 18:35:26 +0000 Subject: [PATCH 3/3] Keep only release signing key guidance requested in review --- release-process.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release-process.md b/release-process.md index e41c04f6fd..141bf28a60 100644 --- a/release-process.md +++ b/release-process.md @@ -139,9 +139,10 @@ To get the code signing key (a.k.a ASCII-armored public key), run the command: $ gpg --export --armor 3FF6D044 ``` -And then append the generated key to the staging KEYS file by: +And then append the generated key to the KEYS file by: ``` +# Move dev/ to release/ when the voting is completed. See Finalize the Release below svn co --depth=files "https://dist.apache.org/repos/dist/dev/spark" svn-spark # edit svn-spark/KEYS file svn ci --username $ASF_USERNAME --password "$ASF_PASSWORD" -m"Update KEYS" @@ -152,7 +153,6 @@ Before starting a release vote, check that your signing key is in the If your key is missing, add it to [`release/spark/KEYS`](https://dist.apache.org/repos/dist/release/spark/KEYS) if you are a PMC member, or ask your PMC shepherd to add it for you. -Adding the key only to `dev/spark/KEYS` does not update the release copy. If you want to do the release on another machine, you can transfer your secret key to that machine via the `gpg --export-secret-keys` and `gpg --import` commands.