From 382d41092ddf14e345819277dd5f73b731986f39 Mon Sep 17 00:00:00 2001 From: Dor-bl <59066376+Dor-bl@users.noreply.github.com> Date: Sat, 5 Sep 2026 09:06:55 +0200 Subject: [PATCH] refactor(webdriver): simplify direct connect capabilities check and logging --- appium/webdriver/webdriver.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/appium/webdriver/webdriver.py b/appium/webdriver/webdriver.py index 09d17094..5410409e 100644 --- a/appium/webdriver/webdriver.py +++ b/appium/webdriver/webdriver.py @@ -314,11 +314,10 @@ def _update_command_executor(self, keep_alive: bool) -> None: if not self.caps: raise ValueError('Driver capabilities must be defined') - if not {direct_protocol, direct_host, direct_port, direct_path}.issubset(set(self.caps)): - message = 'Direct connect capabilities from server were:\n' - for key in [direct_protocol, direct_host, direct_port, direct_path]: - message += f"{key}: '{self.caps.get(key, '')}' " - logger.debug(message) + keys = (direct_protocol, direct_host, direct_port, direct_path) + if not set(keys).issubset(self.caps): + details = ' '.join(f"{key}: '{self.caps.get(key, '')}'" for key in keys) + logger.debug(f'Direct connect capabilities from server were:\n{details} ') return protocol = self.caps[direct_protocol]