From d8138e1aed2afbdffcc3c7c9d7dd18586c3b95c2 Mon Sep 17 00:00:00 2001
From: Nicolas Joubert <njoubert@clever-age.com>
Date: Thu, 22 Oct 2026 18:33:57 +0200
Subject: [PATCH] #73 - RequestTransformer is a private service again, as in
 3.2 (made public by mistake in 3.3). Update UPGRADE.md and tests.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---
 CHANGELOG.md                                                | 3 +++
 UPGRADE.md                                                  | 4 ++--
 config/services/transformer.yaml                            | 6 ++----
 .../CleverAgeSoapProcessExtensionTest.php                   | 6 +++---
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3a06a97..949a77c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,9 @@
 Latest
 ------
 
+### Fixes
+* [#73](https://github.com/cleverage/soap-process-bundle/issues/73) `RequestTransformer` is a private service again, as in 3.2: 3.3 made it public by mistake, with the deprecation of a direct access from the service container that never existed. `UPGRADE.md` (3.3) only mentions the task. Update tests.
+
 v3.3.1
 ------
 
diff --git a/UPGRADE.md b/UPGRADE.md
index 551aa32..e8932ce 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -35,8 +35,8 @@ tasks:
 | `cleverage_soap_process.task.request`        | `RequestTask`        | `soap_request` |
 | `cleverage_soap_process.transformer.request` | `RequestTransformer` | `soap_request` |
 
-The service id of the task and the transformer is their class name. Fetching them from the service container
-(`$container->get()`) is deprecated: they will be private in 4.0.
+The service id of the task and the transformer is their class name. Fetching the task from the service container
+(`$container->get()`) is deprecated: it will be private in 4.0 (the transformer is private, as before).
 
 ### Client codes
 
diff --git a/config/services/transformer.yaml b/config/services/transformer.yaml
index 6fba490..5f4eef7 100644
--- a/config/services/transformer.yaml
+++ b/config/services/transformer.yaml
@@ -1,9 +1,7 @@
 services:
     _defaults:
-        # Public for the direct access from the service container, deprecated since 3.3: private in 4.0
-        public: true
-        tags:
-            - { name: container.private, package: cleverage/soap-process-bundle, version: '3.3' }
+        # Private, as in 3.2: the transformers are fetched by their code
+        public: false
 
     CleverAge\SoapProcessBundle\Transformer\RequestTransformer:
         arguments:
diff --git a/tests/DependencyInjection/CleverAgeSoapProcessExtensionTest.php b/tests/DependencyInjection/CleverAgeSoapProcessExtensionTest.php
index 8e47c02..427871d 100644
--- a/tests/DependencyInjection/CleverAgeSoapProcessExtensionTest.php
+++ b/tests/DependencyInjection/CleverAgeSoapProcessExtensionTest.php
@@ -139,9 +139,9 @@ public function testTransformerIsRegistered(): void
         $code = (new RequestTransformer(new ClientRegistry()))->getCode();
         self::assertSame('soap_request', $code);
         self::assertSame([['code' => $code]], $transformer->getTag('cleverage.transformer'));
-        // Public for the direct access from the service container, deprecated
-        self::assertTrue($transformer->isPublic());
-        self::assertSame([['package' => 'cleverage/soap-process-bundle', 'version' => '3.3']], $transformer->getTag('container.private'));
+        // Private, as in 3.2: it was never fetched directly from the service container
+        self::assertFalse($transformer->isPublic());
+        self::assertFalse($transformer->hasTag('container.private'));
         // No logger
         self::assertFalse($transformer->hasTag('monolog.logger'));
         $arguments = $transformer->getArguments();