diff --git a/.corbits-triage.yml b/.corbits-triage.yml index 7e516c3..24222b2 100644 --- a/.corbits-triage.yml +++ b/.corbits-triage.yml @@ -46,6 +46,51 @@ rules: reason: Set in the portal before the policy file. evidence: - maintainer-stated + - id: conventions + check: code-patterns + text: Added code follows the repository's conventions. + presets: + - convention + onFail: label + reason: No invented fallbacks, nested ternaries, immediately invoked functions, promise chains, empty catches, or suppression comments. + evidence: + - maintainer-stated + - id: no-process-env-in-tests + check: code-patterns + text: Tests do not read process.env. + onFail: label + reason: A test must not depend on the environment. + evidence: + - maintainer-stated + patterns: + - id: no-process-env-in-tests + language: typescript + message: Reads process.env in a test. + files: + [ + "**/*.test.ts", + "**/*.test.tsx", + "**/*.test.js", + "**/*.test.jsx", + "**/*.test.mjs", + "**/*.test.cjs", + ] + rule: + pattern: process.env + - id: no-process-env-in-tests + language: javascript + message: Reads process.env in a test. + files: + [ + "**/*.test.ts", + "**/*.test.tsx", + "**/*.test.js", + "**/*.test.jsx", + "**/*.test.mjs", + "**/*.test.cjs", + ] + rule: + pattern: process.env actions: pass: - do: approve @@ -53,9 +98,12 @@ actions: author: - users: - thegreataxios + - brianjfox - do: request-review target: - to: codeowners + to: users + users: + - thegreataxios when: author: - external