From b006a9b4a092bb4059b35cb93dfd1ea4151afc9c Mon Sep 17 00:00:00 2001 From: "user.email" Date: Fri, 30 Oct 2026 12:19:36 -0700 Subject: [PATCH 1/2] ci(policy): add convention checks without code review --- .corbits-triage.yml | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/.corbits-triage.yml b/.corbits-triage.yml index 7e516c3..afa058e 100644 --- a/.corbits-triage.yml +++ b/.corbits-triage.yml @@ -46,6 +46,35 @@ rules: reason: Set in the portal before the policy file. evidence: - maintainer-stated + - id: conventions + check: code-patterns + text: Added code follows the repository's conventions. + presets: + - convention + onFail: label + reason: No invented fallbacks, nested ternaries, immediately invoked functions, promise chains, empty catches, or suppression comments. + evidence: + - maintainer-stated + - id: no-process-env-in-tests + check: code-patterns + text: Tests do not read process.env. + onFail: label + reason: A test must not depend on the environment. + evidence: + - maintainer-stated + patterns: + - id: no-process-env-in-tests + language: typescript + message: Reads process.env in a test. + files: ["**/*.test.ts", "**/*.test.tsx", "**/*.test.js", "**/*.test.jsx", "**/*.test.mjs", "**/*.test.cjs"] + rule: + pattern: process.env + - id: no-process-env-in-tests + language: javascript + message: Reads process.env in a test. + files: ["**/*.test.ts", "**/*.test.tsx", "**/*.test.js", "**/*.test.jsx", "**/*.test.mjs", "**/*.test.cjs"] + rule: + pattern: process.env actions: pass: - do: approve @@ -53,9 +82,12 @@ actions: author: - users: - thegreataxios + - brianjfox - do: request-review target: - to: codeowners + to: users + users: + - thegreataxios when: author: - external From 4e164ff17978ace3458db992bd2c2b042775ed57 Mon Sep 17 00:00:00 2001 From: Sawyer Cutler Date: Sat, 31 Oct 2026 16:28:04 -0700 Subject: [PATCH 2/2] style: format .corbits-triage.yml --- .corbits-triage.yml | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/.corbits-triage.yml b/.corbits-triage.yml index afa058e..24222b2 100644 --- a/.corbits-triage.yml +++ b/.corbits-triage.yml @@ -66,13 +66,29 @@ rules: - id: no-process-env-in-tests language: typescript message: Reads process.env in a test. - files: ["**/*.test.ts", "**/*.test.tsx", "**/*.test.js", "**/*.test.jsx", "**/*.test.mjs", "**/*.test.cjs"] + files: + [ + "**/*.test.ts", + "**/*.test.tsx", + "**/*.test.js", + "**/*.test.jsx", + "**/*.test.mjs", + "**/*.test.cjs", + ] rule: pattern: process.env - id: no-process-env-in-tests language: javascript message: Reads process.env in a test. - files: ["**/*.test.ts", "**/*.test.tsx", "**/*.test.js", "**/*.test.jsx", "**/*.test.mjs", "**/*.test.cjs"] + files: + [ + "**/*.test.ts", + "**/*.test.tsx", + "**/*.test.js", + "**/*.test.jsx", + "**/*.test.mjs", + "**/*.test.cjs", + ] rule: pattern: process.env actions: