From b96861474364457a57de01c9b22a3763a97e5ed1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Desbiens?=
 <frederic.desbiens@eclipse-foundation.org>
Date: Mon, 28 Sep 2026 19:44:34 -0400
Subject: [PATCH] Stopped the version pass skipping ports in silence

The port stage matched a version only where "Version" was followed immediately by
four dotted numbers. A port writing three numbers, or a stray letter before the
first, was passed over and kept its old release, and the pass reported success
either way. Four ports across the suite had gone stale that way, one of them for
two consecutive releases.

The pattern now accepts three or four numbers and tolerates a leading letter. A
check follows it: any port header that names a release other than the one being
prepared is listed and the pass stops, so a port the substitution cannot reach
fails the release instead of shipping a version that misreports itself.

Verified both ways against a FileX tree: with a port whose string the
substitution cannot reach, the pass names the file and exits non-zero; with that
string corrected, all four ports update and the pass completes.

Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
---
 scripts/prepare_release.sh | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/scripts/prepare_release.sh b/scripts/prepare_release.sh
index 0124b47..2681940 100755
--- a/scripts/prepare_release.sh
+++ b/scripts/prepare_release.sh
@@ -145,15 +145,42 @@ PORT_FILES=$(printf "%s" "${PORT_FILES}" | grep -v '^[[:space:]]*$' || true)
 if [ -z "${PORT_FILES}" ]; then
     printf "Warning: No port header files found. Skipping port version string commit.\n"
 else
+    # A port advertises its release in the string the library reports at run time.
+    # The pattern accepts three or four dotted numbers and tolerates a stray
+    # letter before the first one, so a port that writes its version slightly
+    # differently is still reached.
+    VERSION_RE='Version[[:space:]]+[A-Za-z]?[0-9]+(\.[0-9]+)+[a-z]*'
     while IFS= read -r port_file; do
-        if [ -n "${port_file}" ] && grep -qE "Version [0-9]" "${port_file}" 2>/dev/null; then
-            sed -i -E "s/Version [0-9]+\.[0-9]+\.[0-9]+\.[0-9]+[a-z]*/Version ${VERSION}/g" "${port_file}"
+        if [ -n "${port_file}" ] && grep -qE "${VERSION_RE}" "${port_file}" 2>/dev/null; then
+            sed -i -E "s/${VERSION_RE}/Version ${VERSION}/g" "${port_file}"
             printf "  Updated: %s\n" "${port_file#${REPO_ROOT}/}"
         fi
     done <<EOF
 ${PORT_FILES}
 EOF
 
+    # Every port header that names a release must now name this one.  A port
+    # whose string is shaped in some other way is not rewritten above, and
+    # without this check the pass reports success while leaving that port
+    # advertising the previous release for the life of the version.
+    STALE=""
+    while IFS= read -r port_file; do
+        [ -n "${port_file}" ] || continue
+        advertised=$(grep -hoE '"[^"]*[0-9]+\.[0-9]+\.[0-9]+[^"]*"' "${port_file}" 2>/dev/null || true)
+        [ -n "${advertised}" ] || continue
+        if ! printf "%s" "${advertised}" | grep -qF "${VERSION}"; then
+            STALE="${STALE}  ${port_file#${REPO_ROOT}/}
+"
+        fi
+    done <<EOF
+${PORT_FILES}
+EOF
+    if [ -n "${STALE}" ]; then
+        printf "\nError: these port headers still advertise another release:\n%s" "${STALE}" >&2
+        printf "Correct them so the substitution above reaches them, then re-run.\n" >&2
+        exit 1
+    fi
+
     git -C "${REPO_ROOT}" add -u
     if git -C "${REPO_ROOT}" diff --cached --quiet; then
         printf "No port version string changes staged. Skipping commit.\n"