Skip to content

Commit ed3b85c

Browse files
asgerfCopilot
andauthored
Accept Copilot suggestions
Some typos and exclude constructor patterns from call graph stats Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 832dfb4 commit ed3b85c

5 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎unified/ql/lib/codeql/unified/internal/AnalysisQuality.qll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ module FilesCoveredByModuleManifestStatsReport =
9393

9494
module CallGraphStats implements EntityStatsSig {
9595
class Candidate extends CallExpr {
96+
Candidate() { exists(DataFlowCall c | c.asExplicitCall() = this) }
97+
9698
DataFlowCall getDataFlowCall() { result.asExplicitCall() = this }
9799

98100
DataFlowCallable getTarget() { result = viableCallable(this.getDataFlowCall()) }

‎unified/ql/lib/codeql/unified/internal/dataflow/DataFlowCall.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ private newtype TDataFlowCall =
88
}
99

1010
/**
11-
* A call site, covering both explicit calls such as `foo(1,2)`, as well an implicit
11+
* A call site, covering explicit calls such as `foo(1,2)`, as well as implicit
1212
* calls and calls derived from library models.
1313
*
1414
* Currently only explicit calls are implemented.

‎unified/ql/lib/codeql/unified/internal/dataflow/DataFlowCallable.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ private import AllDataFlow
44
private newtype TDataFlowCallable = TSourceCallable(Callable callable)
55

66
/**
7-
* A callable entity, either an function-like entity in the source code,
7+
* A callable entity: either a function-like entity in source code or
88
* an entity derived from a library model.
99
*
1010
* Currently only callables in source code are implemented.

‎unified/ql/lib/codeql/unified/internal/dataflow/DataFlowNode.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ private predicate hasPostUpdate(Expr expr, ControlFlowNode cfgNode) {
3838
/**
3939
* Holds if `repr` performs an access to `var` of the given `kind` at `cfgNode`.
4040
*
41-
* `repr` should be an arbitary but unique representative for the access.
41+
* `repr` should be an arbitrary but unique representative for the access.
4242
*/
4343
predicate performsVariableAccess(
4444
AstNode repr, LocalVariable var, VariableRefKind kind, ControlFlowNode cfgNode

‎unified/ql/lib/codeql/unified/internal/dataflow/LocalSsa.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Node getNodeFromLocalSsaNode(Ssa::Node n) {
105105
}
106106

107107
/**
108-
* Holds if there is use-use flow from `node1`, through one or most post-update reads, into `node2`.
108+
* Holds if there is use-use flow from `node1`, through one or more post-update reads, into `node2`.
109109
*/
110110
predicate skipPostUpdateRead(Ssa::Node node1, Ssa::Node node2) {
111111
Ssa::localFlowStep(_, node1, node2, true) and

0 commit comments

Comments
 (0)