From fe3330286ad41b27e1613959da2d0cfd924f41c9 Mon Sep 17 00:00:00 2001 From: Mateo Guerrero Date: Mon, 16 Nov 2026 10:57:56 -0500 Subject: [PATCH 1/3] fix(scanner): trust goddady internal low env domains in SEC112 --- .../platform/app/extension/security/config.rs | 13 ++++++- .../platform/app/extension/security/rules.rs | 6 ++-- .../extension/security/tests_sec109_115.rs | 36 +++++++++++++++++++ 3 files changed, 52 insertions(+), 3 deletions(-) diff --git a/rust/src/platform/app/extension/security/config.rs b/rust/src/platform/app/extension/security/config.rs index b22ee96f..1cb96603 100644 --- a/rust/src/platform/app/extension/security/config.rs +++ b/rust/src/platform/app/extension/security/config.rs @@ -6,7 +6,18 @@ use super::types::SecurityConfig; pub fn security_config() -> SecurityConfig { SecurityConfig { - trusted_domains: vec!["*.godaddy.com", "godaddy.com", "localhost", "127.0.0.1"], + trusted_domains: vec![ + "*.godaddy.com", + "godaddy.com", + "*.dev-godaddy.com", + "dev-godaddy.com", + "*.test-godaddy.com", + "test-godaddy.com", + "*.ote-godaddy.com", + "ote-godaddy.com", + "localhost", + "127.0.0.1", + ], exclude: vec![ "**/node_modules/**", "**/dist/**", diff --git a/rust/src/platform/app/extension/security/rules.rs b/rust/src/platform/app/extension/security/rules.rs index eb4d9b8b..8f900d4c 100644 --- a/rust/src/platform/app/extension/security/rules.rs +++ b/rust/src/platform/app/extension/security/rules.rs @@ -224,14 +224,16 @@ pub(super) static RULE_DEFS: &[RuleDef] = &[ r#"\brmSync\s*\("#, ], }, - // SEC112 — requests to untrusted domains (no signal, block) + // SEC112 — requests to untrusted domains (no signal, block). Trusts godaddy.com plus + // the exact non-production hosts dev-/test-/ote-godaddy.com (and their subdomains). + // Keep in sync with `trusted_domains` in config.rs. RuleDef { id: "SEC112", severity: Severity::Block, description: "Bundled code makes requests to domains outside the GoDaddy trusted allowlist", signal_patterns: &[], patterns: &[ - r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s]|$))[^\s"'\x60<>]+"#, + r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s]|$))[^\s"'\x60<>]+"#, ], }, // SEC113 — any encoded payload (no signal, warn) diff --git a/rust/src/platform/app/extension/security/tests_sec109_115.rs b/rust/src/platform/app/extension/security/tests_sec109_115.rs index e143788d..4124dacf 100644 --- a/rust/src/platform/app/extension/security/tests_sec109_115.rs +++ b/rust/src/platform/app/extension/security/tests_sec109_115.rs @@ -300,6 +300,42 @@ fn sec112_godaddy_lookalike_blocked() { ); } +#[test] +fn sec112_nonprod_godaddy_domains_allowed() { + for url in [ + "https://dev-godaddy.com/v1", + "https://api.dev-godaddy.com/v1", + "https://test-godaddy.com/v1", + "https://api.test-godaddy.com:8443/v1", + "https://ote-godaddy.com/v1", + "https://api.ote-godaddy.com/v1?x=1", + ] { + let findings = scan_bundle(&format!(r#"fetch("{url}");"#), "test.mjs"); + assert!( + findings.iter().all(|f| f.rule_id != "SEC112"), + "{url} should be trusted: {findings:?}" + ); + } +} + +#[test] +fn sec112_nonprod_godaddy_lookalikes_blocked() { + for url in [ + "https://evil-dev-godaddy.com/", + "https://dev-godaddy.com.evil.net/", + "https://stage-godaddy.com/", + "https://devgodaddy.com/", + "https://dev-godaddy.co/", + "https://evil.net/dev-godaddy.com", + ] { + let findings = scan_bundle(&format!(r#"fetch("{url}");"#), "test.mjs"); + assert!( + findings.iter().any(|f| f.rule_id == "SEC112"), + "{url} should not be trusted: {findings:?}" + ); + } +} + // ----------------------------------------------------------------------- // SEC113 — any encoded payload (no signal, warn) // ----------------------------------------------------------------------- From 00ea1076c81d5bd0173b88880a15fb8ea540407e Mon Sep 17 00:00:00 2001 From: Mateo Guerrero Date: Mon, 16 Nov 2026 11:39:48 -0500 Subject: [PATCH 2/3] fix(scanner): accept quote terminators after trusted hosts in SEC112 --- .../platform/app/extension/security/rules.rs | 2 +- .../extension/security/tests_sec109_115.rs | 35 +++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/rust/src/platform/app/extension/security/rules.rs b/rust/src/platform/app/extension/security/rules.rs index 8f900d4c..f1b732cf 100644 --- a/rust/src/platform/app/extension/security/rules.rs +++ b/rust/src/platform/app/extension/security/rules.rs @@ -233,7 +233,7 @@ pub(super) static RULE_DEFS: &[RuleDef] = &[ description: "Bundled code makes requests to domains outside the GoDaddy trusted allowlist", signal_patterns: &[], patterns: &[ - r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s]|$))[^\s"'\x60<>]+"#, + r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s"'\x60]|$))[^\s"'\x60<>]+"#, ], }, // SEC113 — any encoded payload (no signal, warn) diff --git a/rust/src/platform/app/extension/security/tests_sec109_115.rs b/rust/src/platform/app/extension/security/tests_sec109_115.rs index 4124dacf..06897066 100644 --- a/rust/src/platform/app/extension/security/tests_sec109_115.rs +++ b/rust/src/platform/app/extension/security/tests_sec109_115.rs @@ -318,6 +318,41 @@ fn sec112_nonprod_godaddy_domains_allowed() { } } +#[test] +fn sec112_bare_host_urls_allowed() { + for code in [ + r#"fetch("https://dev-godaddy.com");"#, + r#"fetch('https://test-godaddy.com');"#, + "fetch(`https://ote-godaddy.com`);", + r#"fetch("https://godaddy.com");"#, + r#"fetch("https://api.godaddy.com");"#, + r#"fetch("http://localhost");"#, + r#"fetch("http://127.0.0.1");"#, + ] { + let findings = scan_bundle(code, "test.mjs"); + assert!( + findings.iter().all(|f| f.rule_id != "SEC112"), + "{code} should be trusted: {findings:?}" + ); + } +} + +#[test] +fn sec112_bare_host_lookalikes_blocked() { + for code in [ + r#"fetch("https://evil.net");"#, + r#"fetch("https://evil-dev-godaddy.com");"#, + r#"fetch('https://dev-godaddy.com.evil.net');"#, + "fetch(`https://stage-godaddy.com`);", + ] { + let findings = scan_bundle(code, "test.mjs"); + assert!( + findings.iter().any(|f| f.rule_id == "SEC112"), + "{code} should not be trusted: {findings:?}" + ); + } +} + #[test] fn sec112_nonprod_godaddy_lookalikes_blocked() { for url in [ From 2774ff88a191bc0823b15b2fb3de79fad1cb8d46 Mon Sep 17 00:00:00 2001 From: Mateo Guerrero Date: Mon, 16 Nov 2026 14:09:12 -0500 Subject: [PATCH 3/3] fix(scanner): only accept the opening quote as a host terminator in SEC112 --- .../src/platform/app/extension/security/rules.rs | 7 ++++++- .../app/extension/security/tests_sec109_115.rs | 16 ++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/rust/src/platform/app/extension/security/rules.rs b/rust/src/platform/app/extension/security/rules.rs index f1b732cf..985600de 100644 --- a/rust/src/platform/app/extension/security/rules.rs +++ b/rust/src/platform/app/extension/security/rules.rs @@ -226,6 +226,8 @@ pub(super) static RULE_DEFS: &[RuleDef] = &[ }, // SEC112 — requests to untrusted domains (no signal, block). Trusts godaddy.com plus // the exact non-production hosts dev-/test-/ote-godaddy.com (and their subdomains). + // A closing quote ends the host only when it matches the quote that opened the URL + // string, so `"https://godaddy.com'@evil.net"` (userinfo) is still blocked. // Keep in sync with `trusted_domains` in config.rs. RuleDef { id: "SEC112", @@ -233,7 +235,10 @@ pub(super) static RULE_DEFS: &[RuleDef] = &[ description: "Bundled code makes requests to domains outside the GoDaddy trusted allowlist", signal_patterns: &[], patterns: &[ - r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s"'\x60]|$))[^\s"'\x60<>]+"#, + r#"(?<=")https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s"]|$))[^\s"'\x60<>]+"#, + r#"(?<=')https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s']|$))[^\s"'\x60<>]+"#, + r#"(?<=\x60)https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s\x60]|$))[^\s"'\x60<>]+"#, + r#"(?]+"#, ], }, // SEC113 — any encoded payload (no signal, warn) diff --git a/rust/src/platform/app/extension/security/tests_sec109_115.rs b/rust/src/platform/app/extension/security/tests_sec109_115.rs index 06897066..f55c5b50 100644 --- a/rust/src/platform/app/extension/security/tests_sec109_115.rs +++ b/rust/src/platform/app/extension/security/tests_sec109_115.rs @@ -371,6 +371,22 @@ fn sec112_nonprod_godaddy_lookalikes_blocked() { } } +#[test] +fn sec112_mixed_quote_userinfo_blocked() { + for code in [ + r#"https.get("https://godaddy.com'@evil.net/steal");"#, + r#"https.get('https://godaddy.com"@evil.net/steal');"#, + "https.get(`https://godaddy.com'@evil.net/steal`);", + r#"https.get("https://dev-godaddy.com`@evil.net/steal");"#, + ] { + let findings = scan_bundle(code, "test.mjs"); + assert!( + findings.iter().any(|f| f.rule_id == "SEC112"), + "{code} should not be trusted: {findings:?}" + ); + } +} + // ----------------------------------------------------------------------- // SEC113 — any encoded payload (no signal, warn) // -----------------------------------------------------------------------