From 7961abacf47e1932e242c8469ff1ec5768a38294 Mon Sep 17 00:00:00 2001
From: amjjbonvin <alexandre.bonvin@gmail.com>
Date: Wed, 30 Sep 2026 07:35:01 +0200
Subject: [PATCH] Remove invalid CSS and the dead btnform block from forms.scss

forms.scss carried three declarations of the form `margin-bottom: 5px / 2`.
Sass never evaluated them: two literals with no parentheses emit the slash
verbatim, so the compiled CSS shipped `margin-bottom:5px/2`, which is invalid
and silently discarded by browsers.

Rather than convert them to math.div(), which would newly apply margins that
have never been in effect, they are deleted. Nothing designed for the values
involved -- 2.5px, 1.25px and 1.25px are artifacts of hardcoding numbers into
what was presumably variable arithmetic upstream.

Reach of each, measured against the built site:

  btnform p      dead -- see below
  label          dead -- the site has no <label> element at all, nor any
                  <textarea> or <select>
  input, ...     47 <input> elements, all on one legacy page
                  (/software/haddock2.2/start_new/). Deleting preserves current
                  rendering exactly, since the invalid value already resolved
                  to no margin.

Also delete the whole `btnform { ... }` block. Line 3 read `btnform {` -- a bare
element selector for <btnform>, which is not an HTML element and appears zero
times in the site's markup. That made 30 lines of form styling dead, including
the first invalid declaration.

Renaming it to `form` was considered and rejected. On the one page that has
forms, every nested rule would still match nothing: there are no fieldset,
legend, p or ul elements inside those forms, and all four <br> sit before the
first <form> tag. It would activate only a 5px margin on three legacy forms,
while leaving `form br { display: none }` to silently hide line breaks in any
form added later.

Drop the unused `@use "sass:math"` while here; the file uses only color.*.

Verified: no invalid px/N values remain in the compiled CSS, no HTML page
changed, and the only selectors removed are the six btnform ones. The label and
input rules keep every other declaration.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---
 _sass/forms.scss | 33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/_sass/forms.scss b/_sass/forms.scss
index 1ef719d0..81a92a3f 100644
--- a/_sass/forms.scss
+++ b/_sass/forms.scss
@@ -1,35 +1,4 @@
-@use "sass:math";
 @use "sass:color";
-btnform { 
-	margin: 0 0 5px 0;
-	fieldset { 
-		margin-bottom: 5px; 
-		padding: 0; 
-		border-width: 0; 
-	}
-	legend { 
-		display: block;
-		width: 100%;
-		margin-bottom: 5px * 2;
-		*margin-left: -7px; 
-		padding: 0;
-		color: $textcolor;
-		border: 0;
-		border-bottom: 1px solid color.adjust($black, $lightness: 80%);
-		white-space: normal; 
-	}
-	p {
-		margin-bottom: 5px / 2; 
-	}
-	ul {
-		list-style-type: none; 
-		margin: 0 0 5px 0;
-		padding: 0; 
-	}
-	br {
-		display: none; 
-	}
-}
 label,
 input,
 button,
@@ -47,7 +16,6 @@ textarea {
 }
 label {
 	display: block;
-	margin-bottom: 10px / 8;
 	font-weight: bold;
 	color: $textcolor;
 	cursor: pointer; 
@@ -63,7 +31,6 @@ select {
 	display: inline-block;
 	width: 100%;
 	padding: 4px;
-	margin-bottom: 5px / 4;
 	background-color: $white;
 	border: 1px solid color.adjust($black, $lightness: 80%);
 	color: $textcolor;