From 735b617c23af01e0765a1974f0f6d65d6f3e4970 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 23 Sep 2026 21:52:48 +0000 Subject: [PATCH 1/3] build(deps): bump codecov/codecov-action from 7.1.0 to 7.1.1 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 7.1.0 to 7.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/0b35c9ecc4f0529d0eb674914510c22f85b196b4...303a32d7a59b442fa8d48b6a1cc6825c09c847a5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 7.1.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- .github/workflows/ansible-test-windows.yml | 2 +- .github/workflows/ansible-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-windows.yml b/.github/workflows/ansible-test-windows.yml index 4d69b02c..82d2179c 100644 --- a/.github/workflows/ansible-test-windows.yml +++ b/.github/workflows/ansible-test-windows.yml @@ -211,7 +211,7 @@ jobs: run: ansible-test coverage xml -v --requirements # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0 + - uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: fail_ci_if_error: false diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index db12207f..81956c9d 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -86,7 +86,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0 + - uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: fail_ci_if_error: false env: @@ -180,7 +180,7 @@ jobs: working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}} # See the reports at https://codecov.io/gh/lowlydba/lowlydba.sqlserver - - uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0 + - uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1 with: fail_ci_if_error: false env: From 1b30f42ccbba3e09d78173119ee4cc041d20aa43 Mon Sep 17 00:00:00 2001 From: John McCall Date: Tue, 29 Sep 2026 14:21:02 -0400 Subject: [PATCH 2/3] test(sp_whoisactive): download script with retries to avoid 403s Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall --- .../fragments/406-sp-whoisactive-test-download.yml | 3 +++ .../targets/sp_whoisactive/tasks/main.yml | 13 +++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 changelogs/fragments/406-sp-whoisactive-test-download.yml diff --git a/changelogs/fragments/406-sp-whoisactive-test-download.yml b/changelogs/fragments/406-sp-whoisactive-test-download.yml new file mode 100644 index 00000000..6f82c58b --- /dev/null +++ b/changelogs/fragments/406-sp-whoisactive-test-download.yml @@ -0,0 +1,3 @@ +--- +trivial: + - sp_whoisactive integration tests - download the script once with retries and install from ``local_file`` to avoid intermittent 403 rate-limit failures. diff --git a/tests/integration/targets/sp_whoisactive/tasks/main.yml b/tests/integration/targets/sp_whoisactive/tasks/main.yml index a10cc1b8..a991a8c9 100644 --- a/tests/integration/targets/sp_whoisactive/tasks/main.yml +++ b/tests/integration/targets/sp_whoisactive/tasks/main.yml @@ -2,14 +2,27 @@ - name: Var block vars: target_database: "master" + whoisactive_local_file: 'C:\Windows\Temp\sp_WhoIsActive.sql' module_defaults: lowlydba.sqlserver.sp_whoisactive: sql_instance: "{{ sqlserver_instance }}" sql_username: "{{ sqlserver_username }}" sql_password: "{{ sqlserver_password }}" database: "{{ target_database }}" + local_file: "{{ whoisactive_local_file }}" tags: ["sp_whoisactive"] block: + # Downloading once with retries avoids intermittent 403s (rate limiting) from the module's own download. + - name: Download sp_whoisactive script + ansible.windows.win_get_url: + url: https://raw.githubusercontent.com/amachanic/sp_whoisactive/master/sp_WhoIsActive.sql + dest: "{{ whoisactive_local_file }}" + force: true + register: download + until: download is succeeded + retries: 5 + delay: 10 + - name: Install sp_whoisactive lowlydba.sqlserver.sp_whoisactive: register: result From 5679e6470bab80d5802cf122ec3d1922fe900138 Mon Sep 17 00:00:00 2001 From: John McCall Date: Sat, 3 Oct 2026 12:00:40 -0400 Subject: [PATCH 3/3] test(sp_whoisactive): pre-download script with get_url and retries ansible.windows.win_get_url is unavailable in the Linux ansible-test container, so the previous fix failed to resolve the module. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- tests/integration/targets/sp_whoisactive/tasks/main.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/integration/targets/sp_whoisactive/tasks/main.yml b/tests/integration/targets/sp_whoisactive/tasks/main.yml index a991a8c9..ea5f3cac 100644 --- a/tests/integration/targets/sp_whoisactive/tasks/main.yml +++ b/tests/integration/targets/sp_whoisactive/tasks/main.yml @@ -2,7 +2,7 @@ - name: Var block vars: target_database: "master" - whoisactive_local_file: 'C:\Windows\Temp\sp_WhoIsActive.sql' + whoisactive_local_file: "/tmp/sp_WhoIsActive.sql" module_defaults: lowlydba.sqlserver.sp_whoisactive: sql_instance: "{{ sqlserver_instance }}" @@ -14,9 +14,10 @@ block: # Downloading once with retries avoids intermittent 403s (rate limiting) from the module's own download. - name: Download sp_whoisactive script - ansible.windows.win_get_url: + ansible.builtin.get_url: url: https://raw.githubusercontent.com/amachanic/sp_whoisactive/master/sp_WhoIsActive.sql dest: "{{ whoisactive_local_file }}" + mode: "0644" force: true register: download until: download is succeeded