Skip to content

Regression in 0.20.0: server list repeatedly sends thousands of Minecraft SRV DNS queries and flickers #7452

Description

@lusu007

Modrinth App version

0.20.0

Operating system

Windows 11 (10.0.26200)

Description

Since updating to Modrinth App 0.20.0, the saved Minecraft server list visibly flickers and the app repeatedly performs DNS SRV lookups for every listed server.

Minecraft is completely closed while this happens. Closing the Modrinth App immediately stops the queries. Reopening Modrinth causes them to resume.

"Jump back into worlds" is enabled.

Example queried records include:

  • _minecraft._tcp.play.rivet.games
  • _minecraft._tcp.play.smolder.fr
  • _minecraft._tcp.cytooxien.net

A six-second Pi-hole Query Log sample contains approximately 123 queries, including 117 SRV queries. This is about 20 processed DNS queries per second. Pi-hole subsequently rate-limits the computer after exceeding its default per-client limit.

Pi-hole reports thousands of additional queries while the client is already rate-limited:

Rate-limiting 10.69.2.207 for at least 45 seconds
Still rate-limiting 10.69.2.207 as it made additional 3929 queries
Still rate-limiting 10.69.2.207 as it made additional 3461 queries

Rate-limiting 10.69.2.207 for at least 17 seconds
Still rate-limiting 10.69.2.207 as it made additional 1414 queries

The problem only started after updating to Modrinth App 0.20.0. It was not present before the update. The flickering server entries and repeated DNS queries occur at the same time.

This appears to be a regression of:

Steps to reproduce

  1. Save multiple Minecraft servers using hostnames with Minecraft SRV records in a Modrinth instance.
  2. Enable "Jump back into worlds".
  3. Ensure Minecraft is completely closed.
  4. Start Modrinth App 0.20.0.
  5. Display the saved/recent server list.
  6. Observe that the server status entries flicker.
  7. Monitor DNS traffic using Pi-hole or another DNS logger.
  8. Observe repeated _minecraft._tcp.<server> SRV queries several times per second.
  9. Completely close Modrinth and observe that the queries immediately stop.

Expected behavior

Server status should be refreshed at a reasonable interval. DNS resolutions and in-flight status requests should be cached or de-duplicated.

Actual behavior

The server list repeatedly refreshes, producing enough SRV queries to trigger Pi-hole's per-client rate limit and temporarily break DNS resolution for the entire computer.

Additional context

Issues #7390 and #7368 were reproduced with Modrinth App 0.19.1 and considered fixed in 0.19.2. This reproduction is on Modrinth App 0.20.0 and therefore appears to be a regression.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions