From de8b76a4e5f4970ad79059231a8a7abb5c693397 Mon Sep 17 00:00:00 2001 From: Jesper Terkelsen Date: Thu, 1 Oct 2026 08:53:28 +0200 Subject: [PATCH] chore: remove explanatory comments added with the ARC migration Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/component-build.yml | 6 ------ .github/workflows/component-test-kotlin.yml | 1 - .github/workflows/pull-request-kotlin.yml | 3 --- .github/workflows/sonar-cloud.yml | 3 --- 4 files changed, 13 deletions(-) diff --git a/.github/workflows/component-build.yml b/.github/workflows/component-build.yml index 38d3343..b13f210 100644 --- a/.github/workflows/component-build.yml +++ b/.github/workflows/component-build.yml @@ -193,7 +193,6 @@ jobs: runs-on: ${{ needs.setup.outputs.runner }} timeout-minutes: 30 env: - # On ARC the cache mounts go to S3 when the caller passes the bucket credentials, and the GitHub cache otherwise. S3_CACHE: ${{ inputs.use-arc-runners && secrets.GH_ACTION_ACCESS_KEY_ID != '' }} steps: - name: Checkout @@ -221,8 +220,6 @@ jobs: # docker driver does not support cache-to). - name: Set up Docker Buildx uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4 - # ARC builders start empty and the registry cache does not carry RUN --mount=type=cache - # contents (e.g. /root/.gradle), so persist them between builds. - name: Restore Dockerfile cache mounts id: cache-mounts if: ${{ inputs.use-arc-runners && env.S3_CACHE != 'true' }} @@ -232,8 +229,6 @@ jobs: key: buildkit-cache-mounts-${{ inputs.docker-file-name }}-${{ hashFiles('**/*.gradle.kts', '**/gradle.properties', 'gradle/libs.versions.toml', 'gradle/wrapper/gradle-wrapper.properties') }} restore-keys: | buildkit-cache-mounts-${{ inputs.docker-file-name }}- - # The combined action, not restore/save: its post-step save must run after the - # cache-dance post step below has extracted the mounts from the builder. - name: Restore Dockerfile cache mounts (S3) id: cache-mounts-s3 if: ${{ env.S3_CACHE == 'true' }} @@ -243,7 +238,6 @@ jobs: RUNS_ON_RUNNER_NAME: "" AWS_ACCESS_KEY_ID: ${{ secrets.GH_ACTION_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.GH_ACTION_SECRET_ACCESS_KEY }} - # Blank the ecr-put-image session exported by the credentials step above. AWS_SESSION_TOKEN: "" AWS_REGION: eu-west-1 with: *cache-mounts diff --git a/.github/workflows/component-test-kotlin.yml b/.github/workflows/component-test-kotlin.yml index 31f20a3..02b4502 100644 --- a/.github/workflows/component-test-kotlin.yml +++ b/.github/workflows/component-test-kotlin.yml @@ -51,7 +51,6 @@ permissions: actions: read env: - # Test names with non-ASCII characters become report file names; the ARC runner image defaults to a POSIX locale. LC_ALL: ${{ inputs.use-arc-runners && 'C.UTF-8' || '' }} jobs: diff --git a/.github/workflows/pull-request-kotlin.yml b/.github/workflows/pull-request-kotlin.yml index 1576c52..64742fa 100644 --- a/.github/workflows/pull-request-kotlin.yml +++ b/.github/workflows/pull-request-kotlin.yml @@ -93,9 +93,7 @@ on: required: true description: "SonarQube token" env: - # Test names with non-ASCII characters become report file names; the ARC runner image defaults to a POSIX locale. LC_ALL: ${{ (inputs.use-arc-runners && github.event.repository.private) && 'C.UTF-8' || '' }} - # On ARC the caches use S3 when the caller passes the bucket credentials, and the GitHub cache otherwise. S3_CACHE: ${{ (inputs.use-arc-runners && github.event.repository.private) && secrets.GH_ACTION_ACCESS_KEY_ID != '' }} jobs: setup: @@ -330,7 +328,6 @@ jobs: with: gradle-module: ${{ inputs.gradle-module }} gradle-tasks: 'sonar' - # ARC runs in the same cluster as SonarQube, whose vpn.internal hostname is only reachable over Tailscale. gradle-args: ${{ inputs.gradle-args }}${{ (inputs.use-arc-runners && github.event.repository.private) && ' -Dsonar.host.url=http://sonarqube.sonarqube.svc.cluster.local:9000' || '' }} # Restores what continue-on-error was meant to express, in an `if` where `inputs` does evaluate. - name: Fail when a blocking Sonar scan failed diff --git a/.github/workflows/sonar-cloud.yml b/.github/workflows/sonar-cloud.yml index d41f709..d53e443 100644 --- a/.github/workflows/sonar-cloud.yml +++ b/.github/workflows/sonar-cloud.yml @@ -63,9 +63,7 @@ on: required: true description: "Sonar token (Optional, won't publish to sonar if not present)" env: - # Test names with non-ASCII characters become report file names; the ARC runner image defaults to a POSIX locale. LC_ALL: ${{ (inputs.use-arc-runners && github.event.repository.private) && 'C.UTF-8' || '' }} - # On ARC the caches use S3 when the caller passes the bucket credentials, and the GitHub cache otherwise. S3_CACHE: ${{ (inputs.use-arc-runners && github.event.repository.private) && secrets.GH_ACTION_ACCESS_KEY_ID != '' }} jobs: setup: @@ -210,7 +208,6 @@ jobs: with: gradle-module: ${{ inputs.gradle-module }} gradle-tasks: 'sonar' - # ARC runs in the same cluster as SonarQube, whose vpn.internal hostname is only reachable over Tailscale. gradle-args: ${{ inputs.gradle-args }}${{ (inputs.use-arc-runners && github.event.repository.private) && ' -Dsonar.host.url=http://sonarqube.sonarqube.svc.cluster.local:9000' || '' }} - name: Upload build reports if: always()