diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 307d341df..82a2eb1ef 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -35,8 +35,8 @@ jobs: - name: Gate run: nix develop --command just gate - moq: - name: Translate moq-net + ts: + name: TypeScript package runs-on: ubuntu-24.04-arm timeout-minutes: 60 @@ -48,10 +48,6 @@ jobs: - uses: ./.github/actions/nix - # moq-net's codec at the pinned moq revision, translated and type-checked. - - name: Translate - run: nix develop --command just ts moq - # The package moq consumes as a flake input. - name: Build run: nix build .#ts diff --git a/quest/m0/README.md b/quest/m0/README.md index 3b2be2748..fa2096325 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -7,4 +7,3 @@ Urgent fixes to anything a consumer already depends on. ## Required - [Checks at moq's cost](/quest/m0/checks/README.md) - `just ci` selects by the diff, builds warm, and runs the differential optimized, with a nightly full `just gate` -- [Gate moq-net's translation](/quest/m0/ts-moq-gate.md) - `just ci` translates moq-net at the pin, so a change that breaks it fails in the queue diff --git a/quest/m0/ts-moq-gate.md b/quest/m0/ts-moq-gate.md deleted file mode 100644 index 9341f629d..000000000 --- a/quest/m0/ts-moq-gate.md +++ /dev/null @@ -1,22 +0,0 @@ -# [S] Gate moq-net's translation - -## Goal - -A change that breaks moq-net's translation fails in the merge queue, not the next nightly: -`just ci` for a `ts` change translates moq-net at the pin and type-checks it, as -`just ts moq` does. Today only `nightly.yml` runs `just ts moq`, so -[moq-dev/rust2#519](https://github.com/moq-dev/rust2/pull/519) landed a panic on moq-net -that a bench run found hours later. - -## Plan - -`just ts check` already checks out the pin for the bench's type-check, so what this adds is -building moq-net's dependencies through the driver and translating it. Measure that in CPU, -cold and warm, against [the checks budget](/quest/m0/checks/README.md) before adding it; -if it costs too much, consider running it only for changes under `ts/src` or `ts/runtime`. - -Public API: none. - -## Related - -- [Checks at moq's cost](/quest/m0/checks/README.md) - the gate's CPU budget this spends from diff --git a/sh/dispatch.sh b/sh/dispatch.sh index 7bb5d598d..6af83b624 100755 --- a/sh/dispatch.sh +++ b/sh/dispatch.sh @@ -111,7 +111,11 @@ test_uniffi() { just uniffi test; } test_driver() { just driver test; } test_ffi() { just ffi test; } test_go() { just go test; } -test_ts() { just ts test; } +# moq-net's translation at the pin, its first consumer, before the slower test build. +test_ts() { + just ts moq + just ts test +} # Every check runs before any test, so a lint fails before the test builds. case "$action" in