From 4dd9187bfa95102d4563682ee84916aed14665f4 Mon Sep 17 00:00:00 2001 From: Wesley Nelson Date: Wed, 11 Nov 2026 16:16:14 -0800 Subject: [PATCH] ci: run the aarch64 binding tests on native arm64 runners The aarch64 and armv7 binding tests ran Node under QEMU on x86 runners, and Node crashed there now and then with SIGSEGV, failing a job before any test ran. Each job installed QEMU with docker/setup-qemu-action and then re-registered the emulators from multiarch/qemu-user-static, which replaced them with that image's own qemu-*-static builds. Measured over ten runs per setup, the one crash came under that image's emulator; none came with setup-qemu-action's emulator or on a native runner. Run the two aarch64 jobs on ubuntu-24.04-arm, with no emulation; they also finish in under a minute instead of about four. armv7 has no native runner, so it stays emulated, without the re-registration. --- .github/workflows/ci.yml | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d57c72..cf9a7eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -338,7 +338,8 @@ jobs: matrix: node: - '18' - runs-on: ubuntu-latest + # Native arm64: Node under QEMU emulation crashes now and then (SIGSEGV). + runs-on: ubuntu-24.04-arm steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 @@ -353,23 +354,22 @@ jobs: run: ls -R . shell: bash + - name: Setup node + uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 + with: + node-version: ${{ matrix.node }} + - name: Install dependencies run: | yarn config set supportedArchitectures.cpu "arm64" yarn config set supportedArchitectures.libc "glibc" yarn install - - name: Set up QEMU - uses: docker/setup-qemu-action@99012661954931238ded8c8b007157a8430204e1 # v4.4.0 - with: - platforms: arm64 - - run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes - - name: Setup and run tests uses: addnab/docker-run-action@4f65fabd2431ebc8d299f8e5a018d79a769ae185 # v3 with: image: node:${{ matrix.node }}-slim - options: '--platform linux/arm64 -v ${{ github.workspace }}:/build -w /build' + options: '-v ${{ github.workspace }}:/build -w /build' run: | set -e NGROK_AUTHTOKEN=${{ secrets.NGROK_AUTHTOKEN }} yarn test -t smoke @@ -385,7 +385,8 @@ jobs: matrix: node: - '18' - runs-on: ubuntu-latest + # Native arm64: Node under QEMU emulation crashes now and then (SIGSEGV). + runs-on: ubuntu-24.04-arm steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 @@ -395,28 +396,27 @@ jobs: with: name: bindings-aarch64-unknown-linux-musl path: . - + - name: List packages run: ls -R . shell: bash + - name: Setup node + uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 + with: + node-version: ${{ matrix.node }} + - name: Install dependencies run: | yarn config set supportedArchitectures.cpu "arm64" yarn config set supportedArchitectures.libc "musl" yarn install - - name: Set up QEMU - uses: docker/setup-qemu-action@99012661954931238ded8c8b007157a8430204e1 # v4.4.0 - with: - platforms: arm64 - - run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes - - name: Setup and run tests uses: addnab/docker-run-action@4f65fabd2431ebc8d299f8e5a018d79a769ae185 # v3 with: image: node:${{ matrix.node }}-alpine - options: '--platform linux/arm64 -v ${{ github.workspace }}:/build -w /build' + options: '-v ${{ github.workspace }}:/build -w /build' run: | set -e NGROK_AUTHTOKEN=${{ secrets.NGROK_AUTHTOKEN }} yarn test -t smoke @@ -455,8 +455,7 @@ jobs: uses: docker/setup-qemu-action@99012661954931238ded8c8b007157a8430204e1 # v4.4.0 with: platforms: arm - - run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes - + - name: Setup and run tests uses: addnab/docker-run-action@4f65fabd2431ebc8d299f8e5a018d79a769ae185 # v3 with: