From d809e38d8c23eadada35dce15d8da312555c4de6 Mon Sep 17 00:00:00 2001
From: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Thu, 15 Oct 2026 10:15:59 +0200
Subject: [PATCH] tools: add `--error-on-warn` configure flag in
 `test-shared.yml`

Given that this workflow compiles V8 and other libs separately, that
would allow us to detect any Node.js-specific warning that needs to be
addressed.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 tools/nix/ci-shell.nix | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/nix/ci-shell.nix b/tools/nix/ci-shell.nix
index b446c9e33d3b..0d5c9e997271 100644
--- a/tools/nix/ci-shell.nix
+++ b/tools/nix/ci-shell.nix
@@ -9,6 +9,10 @@ import ../../shell.nix (
     loadJSBuiltinsDynamically = false;
     devTools = [ ];
     benchmarkTools = [ ];
+    extraConfigFlags = [
+      "--debug-node"
+      "--error-on-warn"
+    ];
   }
   // pkgs.lib.optionalAttrs pkgs.stdenv.hostPlatform.isDarwin (
     # Disable optional features on Darwin for coverage and faster CI.
@@ -20,6 +24,7 @@ import ../../shell.nix (
     // {
       withSSL = true; # no-SSL coverage is ensured by Jenkins
       extraConfigFlags = [
+        "--error-on-warn"
         "--without-inspector"
         "--without-node-options"
       ];