From 0c71e22752262559b91d9735686720bb3b3df749 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 21 Oct 2026 11:30:42 +0200 Subject: [PATCH 1/2] build: error on incompatible quic configure flags Signed-off-by: Antoine du Hamel --- configure.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure.py b/configure.py index 5a30e76b1d8..cd29934876c 100755 --- a/configure.py +++ b/configure.py @@ -2458,15 +2458,14 @@ def configure_ffi(o): def configure_quic(o): if options.experimental_quic and options.without_ssl: - warn('--experimental-quic is incompatible with --without-ssl') - o['variables']['node_use_quic'] = b(options.experimental_quic and - not options.without_ssl) + error('--experimental-quic is incompatible with --without-ssl') + o['variables']['node_use_quic'] = b(options.experimental_quic) if not options.experimental_quic: for lib in ['nghttp3', 'ngtcp2']: shared_lib = 'shared_' + lib if getattr(options, shared_lib): - warn(f'--shared-{lib} requires --experimental-quic') + error(f'--shared-{lib} requires --experimental-quic') return configure_library('nghttp3', output, pkgname='libnghttp3') From af5991dde2be174eb31861d873ccd25b880bb2cc Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 21 Oct 2026 11:40:48 +0200 Subject: [PATCH 2/2] fixup! build: error on incompatible quic configure flags --- tools/nix/non-v8-deps-mock.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/nix/non-v8-deps-mock.nix b/tools/nix/non-v8-deps-mock.nix index 19032dbeb79..e0176c7c919 100644 --- a/tools/nix/non-v8-deps-mock.nix +++ b/tools/nix/non-v8-deps-mock.nix @@ -18,13 +18,14 @@ let "libbrotlienc" ]; cares = [ "libcares" ]; - gtest = [ "gtest" ]; + gtest = [ + "gtest" + "gtest_main" + ]; hdr-histogram = [ "hdr_histogram" ]; merve = [ "merve" ]; nbytes = [ "nbytes" ]; nghttp2 = [ "libnghttp2" ]; - nghttp3 = [ "libnghttp3" ]; - ngtcp2 = [ "libngtcp2" ]; uvwasi = [ "uvwasi" ]; zstd = [ "libzstd" ]; };