From a03da666fab7f79ae45fcc18a8d8081208ecdb3f Mon Sep 17 00:00:00 2001 From: Yordis Prieto Date: Mon, 19 Oct 2026 09:15:33 -0400 Subject: [PATCH] fix(web): model picker reopens on the tab the last model came from Signed-off-by: Yordis Prieto --- .../chat/ModelPickerContent.test.ts | 37 +++++++++++++ .../components/chat/ModelPickerContent.tsx | 52 +++++++++++++++---- .../src/components/chat/modelPickerOrigin.ts | 26 ++++++++++ 3 files changed, 104 insertions(+), 11 deletions(-) create mode 100644 apps/web/src/components/chat/modelPickerOrigin.ts diff --git a/apps/web/src/components/chat/ModelPickerContent.test.ts b/apps/web/src/components/chat/ModelPickerContent.test.ts index 50db51bfa068c..efa0c1a0d3caa 100644 --- a/apps/web/src/components/chat/ModelPickerContent.test.ts +++ b/apps/web/src/components/chat/ModelPickerContent.test.ts @@ -9,6 +9,7 @@ import { describe, expect, it } from "vite-plus/test"; import { deriveProviderInstanceEntries } from "../../providerInstances"; import { adjacentModelPickerProvider, + initialModelPickerProvider, resolveModelPickerSelectedModel, shouldIncludeModelPickerOption, shouldOfferModelPickerSetup, @@ -285,3 +286,39 @@ describe("adjacentModelPickerProvider", () => { ).toBe(claude.instanceId); }); }); + +describe("initialModelPickerProvider", () => { + const activeInstanceId = ProviderInstanceId.make("claudeAgent_personal"); + const input = { + activeInstanceId, + keepActiveInstance: false, + activeInstanceVisible: true, + hasFavorites: true, + lastOrigin: null, + } as const; + + it("reopens on the tab the last model was picked from", () => { + expect(initialModelPickerProvider({ ...input, lastOrigin: "favorites" })).toBe("favorites"); + expect(initialModelPickerProvider({ ...input, lastOrigin: "instance" })).toBe(activeInstanceId); + expect(initialModelPickerProvider(input)).toBe(activeInstanceId); + }); + + it("keeps the active instance when it is locked, needs setup, or there are no favorites", () => { + expect( + initialModelPickerProvider({ ...input, keepActiveInstance: true, lastOrigin: "favorites" }), + ).toBe(activeInstanceId); + expect( + initialModelPickerProvider({ ...input, hasFavorites: false, lastOrigin: "favorites" }), + ).toBe(activeInstanceId); + }); + + it("falls back to favorites when the active instance is not in the rail", () => { + expect( + initialModelPickerProvider({ + ...input, + activeInstanceVisible: false, + lastOrigin: "instance", + }), + ).toBe("favorites"); + }); +}); diff --git a/apps/web/src/components/chat/ModelPickerContent.tsx b/apps/web/src/components/chat/ModelPickerContent.tsx index fc8447571f5e2..787a10e4a8f86 100644 --- a/apps/web/src/components/chat/ModelPickerContent.tsx +++ b/apps/web/src/components/chat/ModelPickerContent.tsx @@ -24,6 +24,11 @@ import { import { ChevronRightIcon } from "lucide-react"; import { ModelListRow } from "./ModelListRow"; import { ModelPickerSidebar } from "./ModelPickerSidebar"; +import { + type ModelPickerOrigin, + readModelPickerOrigin, + writeModelPickerOrigin, +} from "./modelPickerOrigin"; import { getProviderStatusMessage, hasProviderSetup } from "./ProviderStatusBanner"; import { modelPickerLegacySectionKey, @@ -131,6 +136,22 @@ export function shouldOfferModelPickerSetup( ); } +/** Reopens on the rail tab the last model was picked from. */ +export function initialModelPickerProvider(input: { + activeInstanceId: ProviderInstanceId; + keepActiveInstance: boolean; + activeInstanceVisible: boolean; + hasFavorites: boolean; + lastOrigin: ModelPickerOrigin | null; +}): ProviderInstanceId | "favorites" { + if (input.keepActiveInstance || !input.hasFavorites) { + return input.activeInstanceId; + } + return !input.activeInstanceVisible || input.lastOrigin === "favorites" + ? "favorites" + : input.activeInstanceId; +} + export function adjacentModelPickerProvider(input: { entries: ReadonlyArray; selectedInstanceId: ProviderInstanceId | "favorites"; @@ -417,18 +438,24 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: { activeEntry, modelOptionsByInstance.get(props.activeInstanceId) ?? [], ); - const [selectedInstanceId, setSelectedInstanceId] = useState( - () => { - if ( + const [lastOrigin] = useState(readModelPickerOrigin); + const [chosenInstanceId, setChosenInstanceId] = useState( + null, + ); + // Favorites can arrive after the picker opens, so follow them until the user picks a tab. + const selectedInstanceId = + chosenInstanceId ?? + initialModelPickerProvider({ + activeInstanceId: props.activeInstanceId, + keepActiveInstance: props.lockedProvider !== null || activeInstanceHasSelectableUnavailableModel || - activeInstanceNeedsSetup - ) { - return props.activeInstanceId; - } - return favorites.length > 0 ? "favorites" : props.activeInstanceId; - }, - ); + activeInstanceNeedsSetup, + activeInstanceVisible: + activeEntry !== undefined && isProviderInstancePickerVisible(activeEntry), + hasFavorites: favorites.length > 0, + lastOrigin, + }); const [expandedLegacyInstances, setExpandedLegacyInstances] = useState( () => new Set( @@ -449,7 +476,7 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: { }; const handleSelectInstance = (instanceId: ProviderInstanceId | "favorites") => { - setSelectedInstanceId(instanceId); + setChosenInstanceId(instanceId); window.requestAnimationFrame(() => { focusSearchInput(); }); @@ -499,6 +526,9 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: { } const resolvedModel = resolveSelectableModel(entry.driverKind, modelSlug, options); if (resolvedModel) { + if (!isSearching) { + writeModelPickerOrigin(selectedInstanceId === "favorites" ? "favorites" : "instance"); + } if (additive && onToggleModel) { onToggleModel(instanceId, resolvedModel); } else { diff --git a/apps/web/src/components/chat/modelPickerOrigin.ts b/apps/web/src/components/chat/modelPickerOrigin.ts new file mode 100644 index 0000000000000..9765e57cc6088 --- /dev/null +++ b/apps/web/src/components/chat/modelPickerOrigin.ts @@ -0,0 +1,26 @@ +import * as Schema from "effect/Schema"; + +import { getLocalStorageItem, setLocalStorageItem } from "../../hooks/useLocalStorage"; + +const MODEL_PICKER_ORIGIN_STORAGE_KEY = "t3code:model-picker-origin:v1"; + +/** Which rail tab the last model was picked from, so the picker reopens there. */ +const ModelPickerOrigin = Schema.Literals(["favorites", "instance"]); +export type ModelPickerOrigin = typeof ModelPickerOrigin.Type; + +export function readModelPickerOrigin(): ModelPickerOrigin | null { + try { + return getLocalStorageItem(MODEL_PICKER_ORIGIN_STORAGE_KEY, ModelPickerOrigin); + } catch (error) { + console.error("Could not read model picker origin.", error); + return null; + } +} + +export function writeModelPickerOrigin(origin: ModelPickerOrigin): void { + try { + setLocalStorageItem(MODEL_PICKER_ORIGIN_STORAGE_KEY, origin, ModelPickerOrigin); + } catch (error) { + console.error("Could not persist model picker origin.", error); + } +}