From 4caa1034279a217c7f45d4b3591f02e01b45c93f Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 22 Oct 2026 00:06:21 +0000 Subject: [PATCH 1/6] test(web): reproduce issue 21087 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A host video blocked by missing filesystem:read shows only "Video unavailable · Demo" with a futile Retry, while a host image explains the missing access. Co-Authored-By: Claude Opus 5.5 --- .../ChatMarkdown.permissions.browser.test.tsx | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/apps/web/src/components/ChatMarkdown.permissions.browser.test.tsx b/apps/web/src/components/ChatMarkdown.permissions.browser.test.tsx index de274fdd433b..5a397899a5b9 100644 --- a/apps/web/src/components/ChatMarkdown.permissions.browser.test.tsx +++ b/apps/web/src/components/ChatMarkdown.permissions.browser.test.tsx @@ -1,3 +1,4 @@ +import { MISSING_FILE_ACCESS_MESSAGE } from "@t3tools/client-runtime/state/assets"; import { AuthOrchestrationOperateScope, EnvironmentId, @@ -24,6 +25,12 @@ const state = vi.hoisted(() => ({ openExternal: vi.fn(), copy: vi.fn(), linkedPullRequest: null as ThreadLinkedPullRequest | null, + fileAccess: { canReadFiles: true, isPending: false, error: null as string | null }, +})); + +vi.mock(import("../state/filesystem"), async (original) => ({ + ...(await original()), + useFilesystemReadAccess: () => state.fileAccess, })); vi.mock(import("../state/use-atom-query-runner"), async (original) => ({ @@ -135,6 +142,7 @@ function setup() { state.allowed = true; state.listeners.clear(); state.linkedPullRequest = null; + state.fileAccess = { canReadFiles: true, isPending: false, error: null }; state.openEditor.mockReset().mockResolvedValue(AsyncResult.success(undefined)); state.updateMetadata.mockReset().mockResolvedValue(AsyncResult.success(undefined)); state.search.mockReset().mockResolvedValue(AsyncResult.success({ entries: [] })); @@ -280,3 +288,14 @@ it.each(["link-to-thread", "unlink-from-thread"])( ); }, ); + +it("explains missing file access for a host video instead of offering a retry", async () => { + using _setup = setup(); + state.fileAccess = { canReadFiles: false, isPending: false, error: null }; + await using screen = await renderMarkdown("![Demo](/tmp/demo.mp4)"); + await expect.element(screen.getByText(/Video unavailable · Demo/)).toBeVisible(); + await expect + .element(screen.getByText(MISSING_FILE_ACCESS_MESSAGE, { exact: false })) + .toBeVisible(); + await expect.element(screen.getByRole("button", { name: "Retry video" })).not.toBeInTheDocument(); +}); From 4af8f4385b635488bb5bee6e448131fc4fdff03f Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 22 Oct 2026 00:12:02 +0000 Subject: [PATCH 2/6] fix(web): host videos explain missing file access instead of offering a futile retry A video blocked by missing filesystem:read now shows the same explanation as images and hides Retry, since retrying cannot grant the permission. Other video failures keep Retry. Co-Authored-By: Claude Opus 5.5 --- .../src/components/chat/ChatMarkdownMedia.tsx | 18 ++++++++++-------- .../src/components/media/MediaVideoPlayer.tsx | 4 +++- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/apps/web/src/components/chat/ChatMarkdownMedia.tsx b/apps/web/src/components/chat/ChatMarkdownMedia.tsx index f0601234628e..af3cd3f5819a 100644 --- a/apps/web/src/components/chat/ChatMarkdownMedia.tsx +++ b/apps/web/src/components/chat/ChatMarkdownMedia.tsx @@ -274,6 +274,7 @@ export function ChatMarkdownVideo(props: { readonly copyMarkdown: string | undefined; readonly originalUrl?: string | undefined; readonly sourceFailed?: boolean | undefined; + readonly unavailableDetail?: string | undefined; readonly style?: CSSProperties | undefined; readonly mediaIdentity?: string | undefined; readonly actionsSource?: MediaActionSource | undefined; @@ -284,6 +285,7 @@ export function ChatMarkdownVideo(props: { key={props.mediaIdentity ?? props.copyMarkdown ?? props.src} src={props.src} sourceFailed={props.sourceFailed} + unavailableDetail={props.unavailableDetail} label={props.alt} originalUrl={props.originalUrl} style={props.style} @@ -391,6 +393,10 @@ export const ChatMarkdownAssetImage = memo(function ChatMarkdownAssetImage(props : fallbackSrc === undefined ? null : fallbackSrc + (props.srcFragment ?? ""); + const missingFileAccess = + assetUrl._tag === "Failure" && + assetUrl.reason === "missing-file-access" && + fallbackSrc === undefined; const knownSize = assetUrl._tag === "Success" ? assetUrl.imageDimensions : undefined; const maxHeightRem = props.maxHeightRem ?? 30; const style = @@ -426,12 +432,14 @@ export const ChatMarkdownAssetImage = memo(function ChatMarkdownAssetImage(props ); @@ -442,13 +450,7 @@ export const ChatMarkdownAssetImage = memo(function ChatMarkdownAssetImage(props key={JSON.stringify([props.environmentId, props.resource, props.srcFragment])} src={src} sourceFailed={assetUrl._tag === "Failure" && fallbackSrc === undefined} - unavailableDetail={ - assetUrl._tag === "Failure" && - assetUrl.reason === "missing-file-access" && - fallbackSrc === undefined - ? MISSING_FILE_ACCESS_MESSAGE - : undefined - } + unavailableDetail={missingFileAccess ? MISSING_FILE_ACCESS_MESSAGE : undefined} alt={props.alt} copyMarkdown={props.copyMarkdown} standalone={props.standalone ?? true} diff --git a/apps/web/src/components/media/MediaVideoPlayer.tsx b/apps/web/src/components/media/MediaVideoPlayer.tsx index 1392b995c536..9e4d0f9f3c6f 100644 --- a/apps/web/src/components/media/MediaVideoPlayer.tsx +++ b/apps/web/src/components/media/MediaVideoPlayer.tsx @@ -12,6 +12,7 @@ import { MediaActions, type MediaActionSource } from "./MediaActions"; interface MediaVideoPlayerProps { readonly src: string | null; readonly label: string; + readonly unavailableDetail?: string | undefined; readonly sourceFailed?: boolean | undefined; readonly originalUrl?: string | undefined; readonly revision?: string | null | undefined; @@ -30,6 +31,7 @@ interface MediaVideoPlayerProps { export function MediaVideoPlayer({ src: latestSrc, label, + unavailableDetail, sourceFailed = false, originalUrl, revision = null, @@ -139,7 +141,7 @@ export function MediaVideoPlayer({ > - Video unavailable{label ? ` · ${label}` : ""} + {["Video unavailable", label, unavailableDetail].filter(Boolean).join(" · ")} {latestSrc !== null || onRetry ? ( From 92182743d2a8101b9d9c72fedba7a1e9dbd7a5bd Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 22 Oct 2026 00:42:22 +0000 Subject: [PATCH 3/6] test(web): add synthetic media permission evidence fixtures --- scripts/media-permission-evidence-harness.js | 212 +++++++++++++++++++ scripts/seed-media-permission-fixture.py | 103 +++++++++ 2 files changed, 315 insertions(+) create mode 100644 scripts/media-permission-evidence-harness.js create mode 100644 scripts/seed-media-permission-fixture.py diff --git a/scripts/media-permission-evidence-harness.js b/scripts/media-permission-evidence-harness.js new file mode 100644 index 000000000000..195086170ca4 --- /dev/null +++ b/scripts/media-permission-evidence-harness.js @@ -0,0 +1,212 @@ +// Browser-only inspector fixture. Run in the paired dev app through native preview evaluation: +// import('/@fs//scripts/media-permission-evidence-harness.js') +// .then(m => m.mountInspector('')) +// This mounts the actual inspector, using the existing app registry and real session permissions. +export async function mountInspector(mediaRoot) { + if (!mediaRoot || !mediaRoot.startsWith("/")) + throw new Error("Pass the absolute generated fixture media directory"); + const [reactModule, domModule, { AppAtomRegistryProvider }, { V2ItemInspector }] = + await Promise.all([ + import("react"), + import("react-dom/client"), + import("/src/rpc/atomRegistry.ts"), + import("/src/components/chat/V2ItemInspector.tsx"), + ]); + const { createElement: h, Suspense } = reactModule.default ?? reactModule; + const { createRoot } = domModule.default ?? domModule; + document.querySelector("#media-evidence-inspector")?.remove(); + const environmentId = location.pathname.split("/")[1]; + const threadId = "media-permission-a5"; + const T = "2026-10-22T12:00:00.000Z"; + const item = { + id: threadId + "-reasoning", + threadId, + runId: threadId + "-run", + nodeId: threadId + "-root", + providerThreadId: null, + providerTurnId: null, + nativeItemRef: null, + parentItemId: null, + ordinal: 2, + status: "completed", + title: "Synthetic media reasoning", + startedAt: T, + completedAt: T, + updatedAt: T, + type: "reasoning", + streaming: false, + text: `![Demo](${mediaRoot}/demo.mp4)`, + }; + const container = document.createElement("div"); + container.id = "media-evidence-inspector"; + Object.assign(container.style, { + position: "fixed", + inset: "0", + zIndex: "9999", + overflow: "auto", + background: "var(--background)", + color: "var(--foreground)", + padding: "24px", + }); + document.body.append(container); + const root = createRoot(container); + root.render( + h( + AppAtomRegistryProvider, + null, + h( + Suspense, + { fallback: "Loading actual inspector…" }, + h( + "div", + { style: { maxWidth: "736px", margin: "0 auto" } }, + h( + "p", + { style: { marginBottom: "24px" } }, + "HARNESS · A5 · Actual V2ItemInspector · real restricted session", + ), + h(V2ItemInspector, { + projectedItem: { + position: 2, + visibility: "local", + sourceThreadId: threadId, + sourceItemId: item.id, + item, + }, + environmentId, + cwd: mediaRoot, + onOpenThread: () => {}, + onOpenTurnDiff: () => {}, + }), + ), + ), + ), + ); + window.removeMediaEvidenceInspector = () => { + root.unmount(); + container.remove(); + }; +} + +// Controlled player boundary plus the actual asset component's GitHub fallback branch. +// The intentionally unsupported GitHub asset URL fails validation; fallback media is local. +export async function mountControls(mediaRoot) { + if (!mediaRoot?.startsWith("/")) throw new Error("Pass the generated media directory"); + const [ + reactModule, + domModule, + { AppAtomRegistryProvider }, + { ChatMarkdownAssetImage }, + { MediaVideoPlayer }, + ] = await Promise.all([ + import("react"), + import("react-dom/client"), + import("/src/rpc/atomRegistry.ts"), + import("/src/components/chat/ChatMarkdownMedia.tsx"), + import("/src/components/media/MediaVideoPlayer.tsx"), + ]); + const { createElement: h, Suspense, useState } = reactModule.default ?? reactModule; + const { createRoot } = domModule.default ?? domModule; + const environmentId = location.pathname.split("/")[1]; + const good = `${location.origin}/@fs${mediaRoot}/demo.mp4`; + const broken = `${location.origin}/@fs${mediaRoot}/corrupt.mp4`; + function Controls() { + const [scenario, select] = useState("fallback-good"); + const [resolved, resolve] = useState(false); + const [deferred, setDeferred] = useState(null); + const control = (name, action) => + h( + "button", + { + key: name, + type: "button", + onClick: action, + style: { padding: "8px", border: "1px solid", borderRadius: "6px", margin: "4px" }, + }, + name, + ); + const choose = (name) => { + resolve(false); + select(name); + }; + let player; + if (scenario.startsWith("fallback")) { + player = h(ChatMarkdownAssetImage, { + key: scenario, + environmentId, + kind: "video", + alt: "Demo", + resource: { + _tag: "github-media", + cwd: mediaRoot, + url: "https://example.invalid/fixture.mp4", + }, + fallbackSrc: scenario === "fallback-good" ? good : broken, + originalUrl: scenario === "fallback-good" ? good : broken, + srcFragment: "#t=0.1", + }); + } else { + player = h(MediaVideoPlayer, { + key: scenario, + label: "Demo", + src: resolved ? good : null, + sourceFailed: scenario === "retry", + onRetry: + scenario === "retry" + ? () => new Promise((accept, reject) => setDeferred({ accept, reject })) + : undefined, + className: "w-full max-w-[min(100%,30rem)]", + }); + } + return h( + "div", + { style: { maxWidth: "736px", margin: "0 auto" } }, + h("p", null, "HARNESS · actual asset/player components · controlled boundary states"), + h( + "div", + { style: { margin: "20px 0" } }, + ...["fallback-good", "fallback-broken", "retry", "loading"].map((name) => + control(name, () => choose(name)), + ), + ), + h("p", { style: { marginBottom: "20px" } }, `Scenario: ${scenario}`), + h(Suspense, { fallback: "Loading actual component…" }, player), + h( + "div", + { style: { marginTop: "20px" } }, + control("Resolve", () => { + resolve(true); + deferred?.accept(); + setDeferred(null); + }), + control("Reject", () => { + deferred?.reject(new Error("Synthetic refresh failure")); + setDeferred(null); + }), + ), + h( + "p", + { style: { marginTop: "20px" } }, + "Loading is controlled at player props. This does not simulate session-query pending/error.", + ), + ); + } + const container = document.createElement("div"); + container.id = "media-evidence-controls"; + Object.assign(container.style, { + position: "fixed", + inset: "0", + zIndex: "9999", + overflow: "auto", + background: "var(--background)", + color: "var(--foreground)", + padding: "24px", + }); + document.body.append(container); + const root = createRoot(container); + root.render(h(AppAtomRegistryProvider, null, h(Controls))); + window.removeMediaEvidenceControls = () => { + root.unmount(); + container.remove(); + }; +} diff --git a/scripts/seed-media-permission-fixture.py b/scripts/seed-media-permission-fixture.py new file mode 100644 index 000000000000..c461ed4c476e --- /dev/null +++ b/scripts/seed-media-permission-fixture.py @@ -0,0 +1,103 @@ +#!/usr/bin/env python3 +"""Seed synthetic, projection-only media evidence. Run after migrations, with server stopped. + +python3 scripts/seed-media-permission-fixture.py --home .t3/evidence --server-port 13866 +Re-run after projection replay. No provider is started; this is visual test data, +not a test of event history. Requires ffmpeg and ffprobe on PATH. +""" +import argparse +import datetime +import json +import pathlib +import socket +import sqlite3 +import struct +import subprocess +import zlib + +parser = argparse.ArgumentParser(description=__doc__) +parser.add_argument('--home', type=pathlib.Path, required=True) +parser.add_argument('--server-port', type=int, required=True) +args = parser.parse_args() +root = pathlib.Path(__file__).resolve().parents[1] +home = args.home.resolve() +assert home.is_relative_to(root / '.t3'), 'Home must be inside this checkout/.t3' +assert not args.home.is_symlink(), 'Do not use symlinked homes' +with socket.socket() as probe: + assert probe.connect_ex(('127.0.0.1', args.server_port)) != 0, 'Stop the dev server first' +db = home / 'userdata/statev2.sqlite' +assert db.is_file(), 'Initialize migrations with the dev server, then stop it' +connection = sqlite3.connect(db) +assert not connection.execute("select 1 from orchestration_v2_projection_messages where thread_id NOT LIKE 'media-permission-%' limit 1").fetchone(), 'Use a fresh synthetic-only home' +bootstrap = connection.execute("select project_id,workspace_root from projection_projects where project_id != 'media-permission-fixture'").fetchall() +assert all(pathlib.Path(path) == root / 'apps/server' for _, path in bootstrap), 'Unexpected non-fixture project' +backup = db.with_name('statev2.before-media-fixture.' + datetime.datetime.now(datetime.timezone.utc).strftime('%Y%m%dT%H%M%S%f') + '.sqlite') +with sqlite3.connect(backup) as destination: + connection.backup(destination) +backup.chmod(0o400) +media = home / 'media-permission-fixture' +media.mkdir(exist_ok=True) +assert not media.is_symlink() +def chunk(kind, data): + return struct.pack('>I', len(data)) + kind + data + struct.pack('>I', zlib.crc32(kind + data)) +# Deterministic RGB checkerboard, without image-library dependencies. +pixels = b''.join(b'\0' + b''.join(bytes((38, 155, 160) if (x//40+y//40)%2 else (244, 182, 78)) for x in range(320)) for y in range(180)) +(media/'demo.png').write_bytes(b'\x89PNG\r\n\x1a\n' + chunk(b'IHDR', struct.pack('>IIBBBBB',320,180,8,2,0,0,0)) + chunk(b'IDAT',zlib.compress(pixels)) + chunk(b'IEND',b'')) +subprocess.run(['ffmpeg','-y','-hide_banner','-loglevel','error','-f','lavfi','-i','testsrc2=size=320x180:rate=15','-t','3','-an','-c:v','libx264','-threads','1','-pix_fmt','yuv420p','-movflags','+faststart','-map_metadata','-1',str(media/'demo.mp4')],check=True) +probe = json.loads(subprocess.check_output(['ffprobe','-v','error','-show_streams','-of','json',str(media/'demo.mp4')])) +assert probe['streams'][0]['codec_name'] == 'h264' and probe['streams'][0]['pix_fmt'] == 'yuv420p' +(media/'corrupt.mp4').write_text('Synthetic invalid media fixture\n') +(media/'recovery.mp4').unlink(missing_ok=True) +T='2026-10-22T12:00:00.000Z' +P='media-permission-fixture' +selection={'instanceId':'codex','model':'gpt-5.4'} +creation={'createdBy':'agent','creationSource':'provider'} +def insert(table, values): + connection.execute('INSERT INTO '+table+' ('+','.join(values)+') VALUES ('+','.join('?' for _ in values)+')',list(values.values())) +def payload(table, columns, value): + insert(table,dict(columns,payload_json=json.dumps(value))) +video=str(media/'demo.mp4'); image=str(media/'demo.png') +fixtures={ + 'a1': ('A1 · Denied host video',f'![Demo]({video})\n\n![Image comparison]({image})'), + 'a2': ('A2 · Empty label',f'![]({video})'), + 'a3': ('A3 · Long labels',f'![A deliberately long descriptive video label that explains the synthetic demonstration and should wrap without losing the access explanation]({video})\n\n![{"a"*140}.mp4]({video})'), + 'a4': ('A4 · Authored dimensions',f'Demo'), + 'a5': ('A5 · Reasoning inspector',f'![Demo]({video})'), + 'r1': ('R1 · Inline image',f'Before inline ![Image comparison]({image}) after inline.'), + 'r2': ('R2/R3 · Retry recovery',f'![Demo]({media/"recovery.mp4"})'), + 'r3': ('R3 · Decode failure',f'![Demo]({media/"corrupt.mp4"})'), + 'r7': ('R7 · Host playback',f'![Demo]({video}#t=0.1)\n\n![Image comparison]({image})'), + 'r8': ('R8 · Direct HTTP', f'![Demo](http://localhost:5826/@fs{media}/demo.mp4)\n\n![Broken direct](http://localhost:5826/@fs{media}/corrupt.mp4)'), +} +with connection: + for project_id, _ in bootstrap: + connection.execute('DELETE FROM orchestration_v2_projection_threads WHERE project_id=?', (project_id,)) + connection.execute('DELETE FROM projection_projects WHERE project_id=?', (project_id,)) + for suffix in ['turn_items','messages','nodes','runs','threads']: + connection.execute('DELETE FROM orchestration_v2_projection_'+suffix+' WHERE '+('project_id' if suffix=='threads' else 'thread_id')+('=?' if suffix=='threads' else " LIKE 'media-permission-%'"), (P,) if suffix=='threads' else ()) + connection.execute('DELETE FROM projection_projects WHERE project_id=?',(P,)) + insert('projection_projects',dict(project_id=P,title='Synthetic media evidence',workspace_root=str(media),scripts_json='[]',created_at=T,updated_at=T)) + for key,(title,text) in fixtures.items(): + tid='media-permission-'+key; rid=tid+'-run'; nid=tid+'-root' + thread=dict(creation,id=tid,projectId=P,title=title,providerInstanceId='codex',modelSelection=selection,runtimeMode='full-access',interactionMode='default',branch=None,worktreePath=None,activeProviderThreadId=None,lineage=dict(parentThreadId=None,relationshipToParent=None,rootThreadId=tid),forkedFrom=None,createdAt=T,updatedAt=T,archivedAt=None,settledOverride='settled',settledAt=T,lastVisitedAt=T,deletedAt=None) + payload('orchestration_v2_projection_threads',dict(thread_id=tid,project_id=P,title=title,default_provider='codex',provider_instance_id='codex',runtime_mode='full-access',interaction_mode='default',created_at=T,updated_at=T),thread) + run=dict(id=rid,threadId=tid,ordinal=1,providerInstanceId='codex',modelSelection=selection,providerThreadId=None,userMessageId=tid+'-user',rootNodeId=nid,activeAttemptId=None,status='completed',requestedAt=T,startedAt=T,completedAt=T,checkpointId=None,contextHandoffId=None) + payload('orchestration_v2_projection_runs',dict(run_id=rid,thread_id=tid,ordinal=1,provider='codex',provider_instance_id='codex',status='completed',requested_at=T,completed_at=T),run) + node=dict(id=nid,threadId=tid,runId=rid,parentNodeId=None,rootNodeId=nid,kind='root_turn',status='completed',countsForRun=True,providerThreadId=None,providerTurnId=None,nativeItemRef=None,runtimeRequestId=None,checkpointScopeId=None,startedAt=T,completedAt=T) + payload('orchestration_v2_projection_nodes',dict(node_id=nid,thread_id=tid,run_id=rid,root_node_id=nid,kind='root_turn',status='completed',started_at=T,completed_at=T),node) + for ordinal,role,body in [(1,'user',title),(3,'assistant',text if key!='a5' else 'Synthetic reasoning fixture complete.')]: + mid=tid+('-user' if role=='user' else '-assistant') + message=dict(creation,id=mid,threadId=tid,runId=rid,nodeId=nid,role=role,text=body,attachments=[],streaming=False,createdAt=T,updatedAt=T) + payload('orchestration_v2_projection_messages',dict(message_id=mid,thread_id=tid,run_id=rid,node_id=nid,role=role,streaming=0,created_at=T,updated_at=T),message) + item=dict(creation,id=mid+'-item',threadId=tid,runId=rid,nodeId=nid,providerThreadId=None,providerTurnId=None,nativeItemRef=None,parentItemId=None,ordinal=ordinal,status='completed',title=None,startedAt=T,completedAt=T,updatedAt=T,type=role+'_message',messageId=mid,text=body,attachments=[],streaming=False) + if role=='user': item['inputIntent']='turn_start' + payload('orchestration_v2_projection_turn_items',dict(turn_item_id=item['id'],thread_id=tid,run_id=rid,node_id=nid,ordinal=ordinal,type=item['type'],status='completed',updated_at=T),item) + if key=='a5': + item=dict(id=tid+'-reasoning',threadId=tid,runId=rid,nodeId=nid,providerThreadId=None,providerTurnId=None,nativeItemRef=None,parentItemId=None,ordinal=2,status='completed',title='Synthetic media reasoning',startedAt=T,completedAt=T,updatedAt=T,type='reasoning',text=text,streaming=False) + payload('orchestration_v2_projection_turn_items',dict(turn_item_id=item['id'],thread_id=tid,run_id=rid,node_id=nid,ordinal=2,type='reasoning',status='completed',updated_at=T),item) + for key in fixtures: + tid='media-permission-'+key + msg=connection.execute("SELECT json_extract(payload_json,'$.text') FROM orchestration_v2_projection_messages WHERE message_id=?",(tid+'-assistant',)).fetchone()[0] + item=connection.execute("SELECT json_extract(payload_json,'$.text') FROM orchestration_v2_projection_turn_items WHERE turn_item_id=?",(tid+'-assistant-item',)).fetchone()[0] + assert msg==item +print(json.dumps(dict(home=str(home),backup=str(backup),media=str(media),threads=list(fixtures),ffmpeg=subprocess.check_output(['ffmpeg','-version'],text=True).splitlines()[0],projectionOnly=True),indent=2)) From 150961baea123868a67464c57f33cf15517abce7 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 22 Oct 2026 00:54:13 +0000 Subject: [PATCH 4/6] fix(web): narrow host videos fit the file access explanation Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/media/MediaVideoPlayer.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/media/MediaVideoPlayer.tsx b/apps/web/src/components/media/MediaVideoPlayer.tsx index 9e4d0f9f3c6f..9dd67dc2e832 100644 --- a/apps/web/src/components/media/MediaVideoPlayer.tsx +++ b/apps/web/src/components/media/MediaVideoPlayer.tsx @@ -135,7 +135,10 @@ export function MediaVideoPlayer({ From d7def219ab1f718fe8791a33d3d4bf89a7edee7a Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 22 Oct 2026 06:37:37 +0000 Subject: [PATCH 5/6] chore: knip ignores the browser-only media evidence harness Co-Authored-By: Claude Opus 5.5 --- knip.jsonc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/knip.jsonc b/knip.jsonc index 7fbfe3825995..709f1f0e8f4a 100644 --- a/knip.jsonc +++ b/knip.jsonc @@ -30,7 +30,9 @@ ], "ignoreDependencies": ["esbuild"], // The `t3` npm package's files: copied into the package, never imported. - "ignore": ["npm-launcher/**"], + // The media evidence harness is imported by the dev app's browser, where its + // `/src/...` specifiers resolve against apps/web. + "ignore": ["npm-launcher/**", "media-permission-evidence-harness.js"], }, "apps/server": { // Vite+ pack entries and the launcher used by installed background services. From 9498fe90874e8df79039f91193cc3a5ac901e5e3 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 11 Nov 2026 01:44:42 +0000 Subject: [PATCH 6/6] chore(web): drop the media permission evidence fixtures They were scratch tooling for capturing PR evidence, not part of the fix. AI-assisted; verified with the tests and tools listed above. --- knip.jsonc | 21 +- scripts/media-permission-evidence-harness.js | 212 ------------------- scripts/seed-media-permission-fixture.py | 103 --------- 3 files changed, 14 insertions(+), 322 deletions(-) delete mode 100644 scripts/media-permission-evidence-harness.js delete mode 100644 scripts/seed-media-permission-fixture.py diff --git a/knip.jsonc b/knip.jsonc index e9e56ee98dfa..068c8cf84ab6 100644 --- a/knip.jsonc +++ b/knip.jsonc @@ -20,7 +20,7 @@ // Knip loads its preprocessor through a CLI option; native verification and // worktree setup (from t3.json) run directly. release-desktop.yml bundles the // Windows verify script with esbuild through a path knip does not trace, - // electron-builder loads the macOS signer by path, and mobile-e2e.ts runs + // electron-builder loads the macOS signer and the Linux afterPack hook by path, and mobile-e2e.ts runs // agent-device's CLI by path, and mobile-behavior.ts spawns its runner by path. // release-desktop.yml runs the desktop launch check through xvfb-run, which knip // does not trace. @@ -28,21 +28,24 @@ // These fixture scripts are injected into a browser page by path. "fixtures/*/*.js", "knip-schemas.ts", + "linux-after-pack.ts", "mobile-behavior/run.ts", "mobile-native-client.ts", + // e2e loads its config and the scenarios by path, and starts the app script. + "e2e.config.ts", + "prove-scenario.ts", + "scenarios/*.ts", "setup-worktree.ts", "sign-macos.ts", "prepare-server-compile-cache.cjs", "smoke-desktop-app.ts", "verify-windows-desktop-artifact.ts", ], - "ignoreDependencies": ["agent-device", "esbuild"], + "ignoreDependencies": ["esbuild"], // The `t3` npm package's files: copied into the package, never imported. // knip-schemas.test.ts writes a throwaway project to .knip-test-*, which a - // knip run beside it in check:changed must not report. The media evidence - // harness is imported by the dev app's browser, where its `/src/...` - // specifiers resolve against apps/web. - "ignore": ["npm-launcher/**", ".knip-test-*/**", "media-permission-evidence-harness.js"], + // knip run beside it in check:changed must not report. + "ignore": ["npm-launcher/**", ".knip-test-*/**"], }, "apps/server": { // Vite+ pack entries and the launcher used by installed background services. @@ -69,6 +72,7 @@ "@t3tools/web", "@napi-rs/keyring", "ffi-rs", + "transcribe-cpp", ], }, "apps/desktop": { @@ -119,11 +123,14 @@ // Fonts are configured as asset paths; Expo autolinks the native packages. "ignoreDependencies": [ "@expo-google-fonts/dm-sans", - "@t3tools/mobile-highlights-native", "@t3tools/mobile-review-diff-native", "@t3tools/mobile-terminal-native", ], }, + "apps/mobile/modules/t3-highlights": { + // Nitrogen discovers HybridObject specifications by filename. + "entry": ["src/*.nitro.ts!"], + }, "apps/mobile/modules/t3-source-text": { // React Native codegen discovers component specifications by filename. "entry": ["src/*NativeComponent.ts!"], diff --git a/scripts/media-permission-evidence-harness.js b/scripts/media-permission-evidence-harness.js deleted file mode 100644 index 195086170ca4..000000000000 --- a/scripts/media-permission-evidence-harness.js +++ /dev/null @@ -1,212 +0,0 @@ -// Browser-only inspector fixture. Run in the paired dev app through native preview evaluation: -// import('/@fs//scripts/media-permission-evidence-harness.js') -// .then(m => m.mountInspector('')) -// This mounts the actual inspector, using the existing app registry and real session permissions. -export async function mountInspector(mediaRoot) { - if (!mediaRoot || !mediaRoot.startsWith("/")) - throw new Error("Pass the absolute generated fixture media directory"); - const [reactModule, domModule, { AppAtomRegistryProvider }, { V2ItemInspector }] = - await Promise.all([ - import("react"), - import("react-dom/client"), - import("/src/rpc/atomRegistry.ts"), - import("/src/components/chat/V2ItemInspector.tsx"), - ]); - const { createElement: h, Suspense } = reactModule.default ?? reactModule; - const { createRoot } = domModule.default ?? domModule; - document.querySelector("#media-evidence-inspector")?.remove(); - const environmentId = location.pathname.split("/")[1]; - const threadId = "media-permission-a5"; - const T = "2026-10-22T12:00:00.000Z"; - const item = { - id: threadId + "-reasoning", - threadId, - runId: threadId + "-run", - nodeId: threadId + "-root", - providerThreadId: null, - providerTurnId: null, - nativeItemRef: null, - parentItemId: null, - ordinal: 2, - status: "completed", - title: "Synthetic media reasoning", - startedAt: T, - completedAt: T, - updatedAt: T, - type: "reasoning", - streaming: false, - text: `![Demo](${mediaRoot}/demo.mp4)`, - }; - const container = document.createElement("div"); - container.id = "media-evidence-inspector"; - Object.assign(container.style, { - position: "fixed", - inset: "0", - zIndex: "9999", - overflow: "auto", - background: "var(--background)", - color: "var(--foreground)", - padding: "24px", - }); - document.body.append(container); - const root = createRoot(container); - root.render( - h( - AppAtomRegistryProvider, - null, - h( - Suspense, - { fallback: "Loading actual inspector…" }, - h( - "div", - { style: { maxWidth: "736px", margin: "0 auto" } }, - h( - "p", - { style: { marginBottom: "24px" } }, - "HARNESS · A5 · Actual V2ItemInspector · real restricted session", - ), - h(V2ItemInspector, { - projectedItem: { - position: 2, - visibility: "local", - sourceThreadId: threadId, - sourceItemId: item.id, - item, - }, - environmentId, - cwd: mediaRoot, - onOpenThread: () => {}, - onOpenTurnDiff: () => {}, - }), - ), - ), - ), - ); - window.removeMediaEvidenceInspector = () => { - root.unmount(); - container.remove(); - }; -} - -// Controlled player boundary plus the actual asset component's GitHub fallback branch. -// The intentionally unsupported GitHub asset URL fails validation; fallback media is local. -export async function mountControls(mediaRoot) { - if (!mediaRoot?.startsWith("/")) throw new Error("Pass the generated media directory"); - const [ - reactModule, - domModule, - { AppAtomRegistryProvider }, - { ChatMarkdownAssetImage }, - { MediaVideoPlayer }, - ] = await Promise.all([ - import("react"), - import("react-dom/client"), - import("/src/rpc/atomRegistry.ts"), - import("/src/components/chat/ChatMarkdownMedia.tsx"), - import("/src/components/media/MediaVideoPlayer.tsx"), - ]); - const { createElement: h, Suspense, useState } = reactModule.default ?? reactModule; - const { createRoot } = domModule.default ?? domModule; - const environmentId = location.pathname.split("/")[1]; - const good = `${location.origin}/@fs${mediaRoot}/demo.mp4`; - const broken = `${location.origin}/@fs${mediaRoot}/corrupt.mp4`; - function Controls() { - const [scenario, select] = useState("fallback-good"); - const [resolved, resolve] = useState(false); - const [deferred, setDeferred] = useState(null); - const control = (name, action) => - h( - "button", - { - key: name, - type: "button", - onClick: action, - style: { padding: "8px", border: "1px solid", borderRadius: "6px", margin: "4px" }, - }, - name, - ); - const choose = (name) => { - resolve(false); - select(name); - }; - let player; - if (scenario.startsWith("fallback")) { - player = h(ChatMarkdownAssetImage, { - key: scenario, - environmentId, - kind: "video", - alt: "Demo", - resource: { - _tag: "github-media", - cwd: mediaRoot, - url: "https://example.invalid/fixture.mp4", - }, - fallbackSrc: scenario === "fallback-good" ? good : broken, - originalUrl: scenario === "fallback-good" ? good : broken, - srcFragment: "#t=0.1", - }); - } else { - player = h(MediaVideoPlayer, { - key: scenario, - label: "Demo", - src: resolved ? good : null, - sourceFailed: scenario === "retry", - onRetry: - scenario === "retry" - ? () => new Promise((accept, reject) => setDeferred({ accept, reject })) - : undefined, - className: "w-full max-w-[min(100%,30rem)]", - }); - } - return h( - "div", - { style: { maxWidth: "736px", margin: "0 auto" } }, - h("p", null, "HARNESS · actual asset/player components · controlled boundary states"), - h( - "div", - { style: { margin: "20px 0" } }, - ...["fallback-good", "fallback-broken", "retry", "loading"].map((name) => - control(name, () => choose(name)), - ), - ), - h("p", { style: { marginBottom: "20px" } }, `Scenario: ${scenario}`), - h(Suspense, { fallback: "Loading actual component…" }, player), - h( - "div", - { style: { marginTop: "20px" } }, - control("Resolve", () => { - resolve(true); - deferred?.accept(); - setDeferred(null); - }), - control("Reject", () => { - deferred?.reject(new Error("Synthetic refresh failure")); - setDeferred(null); - }), - ), - h( - "p", - { style: { marginTop: "20px" } }, - "Loading is controlled at player props. This does not simulate session-query pending/error.", - ), - ); - } - const container = document.createElement("div"); - container.id = "media-evidence-controls"; - Object.assign(container.style, { - position: "fixed", - inset: "0", - zIndex: "9999", - overflow: "auto", - background: "var(--background)", - color: "var(--foreground)", - padding: "24px", - }); - document.body.append(container); - const root = createRoot(container); - root.render(h(AppAtomRegistryProvider, null, h(Controls))); - window.removeMediaEvidenceControls = () => { - root.unmount(); - container.remove(); - }; -} diff --git a/scripts/seed-media-permission-fixture.py b/scripts/seed-media-permission-fixture.py deleted file mode 100644 index c461ed4c476e..000000000000 --- a/scripts/seed-media-permission-fixture.py +++ /dev/null @@ -1,103 +0,0 @@ -#!/usr/bin/env python3 -"""Seed synthetic, projection-only media evidence. Run after migrations, with server stopped. - -python3 scripts/seed-media-permission-fixture.py --home .t3/evidence --server-port 13866 -Re-run after projection replay. No provider is started; this is visual test data, -not a test of event history. Requires ffmpeg and ffprobe on PATH. -""" -import argparse -import datetime -import json -import pathlib -import socket -import sqlite3 -import struct -import subprocess -import zlib - -parser = argparse.ArgumentParser(description=__doc__) -parser.add_argument('--home', type=pathlib.Path, required=True) -parser.add_argument('--server-port', type=int, required=True) -args = parser.parse_args() -root = pathlib.Path(__file__).resolve().parents[1] -home = args.home.resolve() -assert home.is_relative_to(root / '.t3'), 'Home must be inside this checkout/.t3' -assert not args.home.is_symlink(), 'Do not use symlinked homes' -with socket.socket() as probe: - assert probe.connect_ex(('127.0.0.1', args.server_port)) != 0, 'Stop the dev server first' -db = home / 'userdata/statev2.sqlite' -assert db.is_file(), 'Initialize migrations with the dev server, then stop it' -connection = sqlite3.connect(db) -assert not connection.execute("select 1 from orchestration_v2_projection_messages where thread_id NOT LIKE 'media-permission-%' limit 1").fetchone(), 'Use a fresh synthetic-only home' -bootstrap = connection.execute("select project_id,workspace_root from projection_projects where project_id != 'media-permission-fixture'").fetchall() -assert all(pathlib.Path(path) == root / 'apps/server' for _, path in bootstrap), 'Unexpected non-fixture project' -backup = db.with_name('statev2.before-media-fixture.' + datetime.datetime.now(datetime.timezone.utc).strftime('%Y%m%dT%H%M%S%f') + '.sqlite') -with sqlite3.connect(backup) as destination: - connection.backup(destination) -backup.chmod(0o400) -media = home / 'media-permission-fixture' -media.mkdir(exist_ok=True) -assert not media.is_symlink() -def chunk(kind, data): - return struct.pack('>I', len(data)) + kind + data + struct.pack('>I', zlib.crc32(kind + data)) -# Deterministic RGB checkerboard, without image-library dependencies. -pixels = b''.join(b'\0' + b''.join(bytes((38, 155, 160) if (x//40+y//40)%2 else (244, 182, 78)) for x in range(320)) for y in range(180)) -(media/'demo.png').write_bytes(b'\x89PNG\r\n\x1a\n' + chunk(b'IHDR', struct.pack('>IIBBBBB',320,180,8,2,0,0,0)) + chunk(b'IDAT',zlib.compress(pixels)) + chunk(b'IEND',b'')) -subprocess.run(['ffmpeg','-y','-hide_banner','-loglevel','error','-f','lavfi','-i','testsrc2=size=320x180:rate=15','-t','3','-an','-c:v','libx264','-threads','1','-pix_fmt','yuv420p','-movflags','+faststart','-map_metadata','-1',str(media/'demo.mp4')],check=True) -probe = json.loads(subprocess.check_output(['ffprobe','-v','error','-show_streams','-of','json',str(media/'demo.mp4')])) -assert probe['streams'][0]['codec_name'] == 'h264' and probe['streams'][0]['pix_fmt'] == 'yuv420p' -(media/'corrupt.mp4').write_text('Synthetic invalid media fixture\n') -(media/'recovery.mp4').unlink(missing_ok=True) -T='2026-10-22T12:00:00.000Z' -P='media-permission-fixture' -selection={'instanceId':'codex','model':'gpt-5.4'} -creation={'createdBy':'agent','creationSource':'provider'} -def insert(table, values): - connection.execute('INSERT INTO '+table+' ('+','.join(values)+') VALUES ('+','.join('?' for _ in values)+')',list(values.values())) -def payload(table, columns, value): - insert(table,dict(columns,payload_json=json.dumps(value))) -video=str(media/'demo.mp4'); image=str(media/'demo.png') -fixtures={ - 'a1': ('A1 · Denied host video',f'![Demo]({video})\n\n![Image comparison]({image})'), - 'a2': ('A2 · Empty label',f'![]({video})'), - 'a3': ('A3 · Long labels',f'![A deliberately long descriptive video label that explains the synthetic demonstration and should wrap without losing the access explanation]({video})\n\n![{"a"*140}.mp4]({video})'), - 'a4': ('A4 · Authored dimensions',f'Demo'), - 'a5': ('A5 · Reasoning inspector',f'![Demo]({video})'), - 'r1': ('R1 · Inline image',f'Before inline ![Image comparison]({image}) after inline.'), - 'r2': ('R2/R3 · Retry recovery',f'![Demo]({media/"recovery.mp4"})'), - 'r3': ('R3 · Decode failure',f'![Demo]({media/"corrupt.mp4"})'), - 'r7': ('R7 · Host playback',f'![Demo]({video}#t=0.1)\n\n![Image comparison]({image})'), - 'r8': ('R8 · Direct HTTP', f'![Demo](http://localhost:5826/@fs{media}/demo.mp4)\n\n![Broken direct](http://localhost:5826/@fs{media}/corrupt.mp4)'), -} -with connection: - for project_id, _ in bootstrap: - connection.execute('DELETE FROM orchestration_v2_projection_threads WHERE project_id=?', (project_id,)) - connection.execute('DELETE FROM projection_projects WHERE project_id=?', (project_id,)) - for suffix in ['turn_items','messages','nodes','runs','threads']: - connection.execute('DELETE FROM orchestration_v2_projection_'+suffix+' WHERE '+('project_id' if suffix=='threads' else 'thread_id')+('=?' if suffix=='threads' else " LIKE 'media-permission-%'"), (P,) if suffix=='threads' else ()) - connection.execute('DELETE FROM projection_projects WHERE project_id=?',(P,)) - insert('projection_projects',dict(project_id=P,title='Synthetic media evidence',workspace_root=str(media),scripts_json='[]',created_at=T,updated_at=T)) - for key,(title,text) in fixtures.items(): - tid='media-permission-'+key; rid=tid+'-run'; nid=tid+'-root' - thread=dict(creation,id=tid,projectId=P,title=title,providerInstanceId='codex',modelSelection=selection,runtimeMode='full-access',interactionMode='default',branch=None,worktreePath=None,activeProviderThreadId=None,lineage=dict(parentThreadId=None,relationshipToParent=None,rootThreadId=tid),forkedFrom=None,createdAt=T,updatedAt=T,archivedAt=None,settledOverride='settled',settledAt=T,lastVisitedAt=T,deletedAt=None) - payload('orchestration_v2_projection_threads',dict(thread_id=tid,project_id=P,title=title,default_provider='codex',provider_instance_id='codex',runtime_mode='full-access',interaction_mode='default',created_at=T,updated_at=T),thread) - run=dict(id=rid,threadId=tid,ordinal=1,providerInstanceId='codex',modelSelection=selection,providerThreadId=None,userMessageId=tid+'-user',rootNodeId=nid,activeAttemptId=None,status='completed',requestedAt=T,startedAt=T,completedAt=T,checkpointId=None,contextHandoffId=None) - payload('orchestration_v2_projection_runs',dict(run_id=rid,thread_id=tid,ordinal=1,provider='codex',provider_instance_id='codex',status='completed',requested_at=T,completed_at=T),run) - node=dict(id=nid,threadId=tid,runId=rid,parentNodeId=None,rootNodeId=nid,kind='root_turn',status='completed',countsForRun=True,providerThreadId=None,providerTurnId=None,nativeItemRef=None,runtimeRequestId=None,checkpointScopeId=None,startedAt=T,completedAt=T) - payload('orchestration_v2_projection_nodes',dict(node_id=nid,thread_id=tid,run_id=rid,root_node_id=nid,kind='root_turn',status='completed',started_at=T,completed_at=T),node) - for ordinal,role,body in [(1,'user',title),(3,'assistant',text if key!='a5' else 'Synthetic reasoning fixture complete.')]: - mid=tid+('-user' if role=='user' else '-assistant') - message=dict(creation,id=mid,threadId=tid,runId=rid,nodeId=nid,role=role,text=body,attachments=[],streaming=False,createdAt=T,updatedAt=T) - payload('orchestration_v2_projection_messages',dict(message_id=mid,thread_id=tid,run_id=rid,node_id=nid,role=role,streaming=0,created_at=T,updated_at=T),message) - item=dict(creation,id=mid+'-item',threadId=tid,runId=rid,nodeId=nid,providerThreadId=None,providerTurnId=None,nativeItemRef=None,parentItemId=None,ordinal=ordinal,status='completed',title=None,startedAt=T,completedAt=T,updatedAt=T,type=role+'_message',messageId=mid,text=body,attachments=[],streaming=False) - if role=='user': item['inputIntent']='turn_start' - payload('orchestration_v2_projection_turn_items',dict(turn_item_id=item['id'],thread_id=tid,run_id=rid,node_id=nid,ordinal=ordinal,type=item['type'],status='completed',updated_at=T),item) - if key=='a5': - item=dict(id=tid+'-reasoning',threadId=tid,runId=rid,nodeId=nid,providerThreadId=None,providerTurnId=None,nativeItemRef=None,parentItemId=None,ordinal=2,status='completed',title='Synthetic media reasoning',startedAt=T,completedAt=T,updatedAt=T,type='reasoning',text=text,streaming=False) - payload('orchestration_v2_projection_turn_items',dict(turn_item_id=item['id'],thread_id=tid,run_id=rid,node_id=nid,ordinal=2,type='reasoning',status='completed',updated_at=T),item) - for key in fixtures: - tid='media-permission-'+key - msg=connection.execute("SELECT json_extract(payload_json,'$.text') FROM orchestration_v2_projection_messages WHERE message_id=?",(tid+'-assistant',)).fetchone()[0] - item=connection.execute("SELECT json_extract(payload_json,'$.text') FROM orchestration_v2_projection_turn_items WHERE turn_item_id=?",(tid+'-assistant-item',)).fetchone()[0] - assert msg==item -print(json.dumps(dict(home=str(home),backup=str(backup),media=str(media),threads=list(fixtures),ffmpeg=subprocess.check_output(['ffmpeg','-version'],text=True).splitlines()[0],projectionOnly=True),indent=2))