From 1f1838e64a1489a4decaf1cd4a26ca6367629043 Mon Sep 17 00:00:00 2001 From: Lakshmi Tanmay Date: Mon, 2 Nov 2026 21:22:24 +0530 Subject: [PATCH 1/3] fix(desktop): report browser title changes without navigation --- .../preview/usePreviewBridge.test.ts | 55 ++++++++++++++++++- .../components/preview/usePreviewBridge.ts | 15 ++++- 2 files changed, 65 insertions(+), 5 deletions(-) diff --git a/apps/web/src/components/preview/usePreviewBridge.test.ts b/apps/web/src/components/preview/usePreviewBridge.test.ts index 736ac7d743c32..15946a7bc9adf 100644 --- a/apps/web/src/components/preview/usePreviewBridge.test.ts +++ b/apps/web/src/components/preview/usePreviewBridge.test.ts @@ -1,9 +1,9 @@ -import type { DesktopPreviewTabState } from "@t3tools/contracts"; +import { ThreadId, type DesktopPreviewTabState } from "@t3tools/contracts"; import { describe, expect, it } from "vite-plus/test"; import { useBrowserSurfaceStore } from "~/browser/browserSurfaceStore"; -import { createCaptureActivity, projectDesktopState } from "./usePreviewBridge"; +import { buildReportInput, createCaptureActivity, projectDesktopState } from "./usePreviewBridge"; const favicon = { dataUrl: "data:image/png;base64,AAAA", @@ -30,6 +30,57 @@ function state(navStatus: DesktopPreviewTabState["navStatus"]): DesktopPreviewTa }; } +describe("buildReportInput", () => { + it("reports title changes at the same URL without repeating unrelated desktop updates", () => { + const threadId = ThreadId.make("thread-1"); + const tabId = "tab-1"; + const url = "http://localhost:3000/app"; + let lastReport = { + lastReportedUrl: null as string | null, + lastReportedKind: null as DesktopPreviewTabState["navStatus"]["kind"] | null, + lastReportedTitle: null as string | null, + }; + const report = (nextState: DesktopPreviewTabState) => { + const result = buildReportInput({ threadId, tabId, state: nextState, ...lastReport }); + if (result) { + lastReport = result; + } + return result?.input.navStatus ?? null; + }; + + expect(report(state({ kind: "Loading", url, title: "" }))).toEqual({ + _tag: "Loading", + url, + title: "", + }); + const loaded = state({ kind: "Success", url, title: "Original title" }); + expect(report(loaded)).toEqual({ _tag: "Success", url, title: "Original title" }); + expect(report(loaded)).toBeNull(); + + const retitled = state({ kind: "Success", url, title: "Updated title" }); + expect(report(retitled)).toEqual({ _tag: "Success", url, title: "Updated title" }); + expect( + report({ + ...retitled, + audible: true, + controller: "human", + updatedAt: "2026-08-09T00:00:01.000Z", + }), + ).toBeNull(); + expect(report(state({ kind: "Success", url, title: "" }))).toEqual({ + _tag: "Success", + url, + title: "", + }); + expect(report(state({ kind: "Success", url, title: "" }))).toBeNull(); + expect(report(state({ kind: "Loading", url, title: "" }))).toEqual({ + _tag: "Loading", + url, + title: "", + }); + }); +}); + describe("projectDesktopState", () => { it("shows a retained icon only while the current document has the captured origin", () => { expect( diff --git a/apps/web/src/components/preview/usePreviewBridge.ts b/apps/web/src/components/preview/usePreviewBridge.ts index 92bc9b29b35c3..6973f22f7dd3b 100644 --- a/apps/web/src/components/preview/usePreviewBridge.ts +++ b/apps/web/src/components/preview/usePreviewBridge.ts @@ -54,6 +54,7 @@ export function usePreviewBridge(input: { const lastReportedUrl = useRef(null); const lastReportedKind = useRef(null); + const lastReportedTitle = useRef(null); const lastDesktopNavStatus = useRef(null); const captureActivity = useRef | null>(null); const handleStateChange = useEffectEvent( @@ -74,10 +75,12 @@ export function usePreviewBridge(input: { state, lastReportedUrl: lastReportedUrl.current, lastReportedKind: lastReportedKind.current, + lastReportedTitle: lastReportedTitle.current, }); if (!reported || serverDriven) return; lastReportedUrl.current = reported.lastReportedUrl; lastReportedKind.current = reported.lastReportedKind; + lastReportedTitle.current = reported.lastReportedTitle; void reportStatus({ environmentId: stableThreadRef.environmentId, input: reported.input, @@ -89,6 +92,7 @@ export function usePreviewBridge(input: { if (!previewBridge || typeof window === "undefined") return; lastReportedUrl.current = null; lastReportedKind.current = null; + lastReportedTitle.current = null; lastDesktopNavStatus.current = null; const activity = createCaptureActivity(runtimeTabId); captureActivity.current = activity; @@ -134,25 +138,28 @@ export function projectDesktopState(state: DesktopPreviewTabState): DesktopPrevi }; } -function buildReportInput(args: { +export function buildReportInput(args: { readonly threadId: ThreadId; readonly tabId: string; readonly state: DesktopPreviewTabState; readonly lastReportedUrl: string | null; readonly lastReportedKind: DesktopPreviewTabState["navStatus"]["kind"] | null; + readonly lastReportedTitle: string | null; }): { readonly input: PreviewReportStatusInput; readonly lastReportedUrl: string; readonly lastReportedKind: DesktopPreviewTabState["navStatus"]["kind"]; + readonly lastReportedTitle: string; } | null { - const { threadId, tabId, state, lastReportedUrl, lastReportedKind } = args; + const { threadId, tabId, state, lastReportedUrl, lastReportedKind, lastReportedTitle } = args; const status = state.navStatus; if (status.kind === "Idle") return null; const sameAsLast = status.kind !== "LoadFailed" && status.kind === lastReportedKind && - status.url === lastReportedUrl; + status.url === lastReportedUrl && + status.title === lastReportedTitle; if (sameAsLast) return null; const base = { @@ -175,6 +182,7 @@ function buildReportInput(args: { }, lastReportedUrl: status.url, lastReportedKind: "LoadFailed", + lastReportedTitle: status.title, }; } return { @@ -184,5 +192,6 @@ function buildReportInput(args: { }, lastReportedUrl: status.url, lastReportedKind: status.kind, + lastReportedTitle: status.title, }; } From 4eb63a53358e36ec5dbe1ade1312324ba3010340 Mon Sep 17 00:00:00 2001 From: Lakshmi Tanmay Date: Mon, 2 Nov 2026 22:53:22 +0530 Subject: [PATCH 2/3] ci: retrigger checks after PDF preview readiness failure From 20079e20efc259382bbce0a6fd41ed035216c67f Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 12 Nov 2026 20:32:16 +0000 Subject: [PATCH 3/3] test(web): keep the title-only preview report regression case AI-assisted; verified with the tests and tools listed above. --- .../components/preview/usePreviewBridge.test.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/apps/web/src/components/preview/usePreviewBridge.test.ts b/apps/web/src/components/preview/usePreviewBridge.test.ts index 15946a7bc9adf..be98eebcd91b1 100644 --- a/apps/web/src/components/preview/usePreviewBridge.test.ts +++ b/apps/web/src/components/preview/usePreviewBridge.test.ts @@ -48,11 +48,6 @@ describe("buildReportInput", () => { return result?.input.navStatus ?? null; }; - expect(report(state({ kind: "Loading", url, title: "" }))).toEqual({ - _tag: "Loading", - url, - title: "", - }); const loaded = state({ kind: "Success", url, title: "Original title" }); expect(report(loaded)).toEqual({ _tag: "Success", url, title: "Original title" }); expect(report(loaded)).toBeNull(); @@ -67,17 +62,6 @@ describe("buildReportInput", () => { updatedAt: "2026-08-09T00:00:01.000Z", }), ).toBeNull(); - expect(report(state({ kind: "Success", url, title: "" }))).toEqual({ - _tag: "Success", - url, - title: "", - }); - expect(report(state({ kind: "Success", url, title: "" }))).toBeNull(); - expect(report(state({ kind: "Loading", url, title: "" }))).toEqual({ - _tag: "Loading", - url, - title: "", - }); }); });