diff --git a/apps/web/src/components/settings/KeybindingsSettings.logic.test.ts b/apps/web/src/components/settings/KeybindingsSettings.logic.test.ts index 7f57caaf04f68..6098239492d70 100644 --- a/apps/web/src/components/settings/KeybindingsSettings.logic.test.ts +++ b/apps/web/src/components/settings/KeybindingsSettings.logic.test.ts @@ -9,10 +9,12 @@ import { resolveShortcutCommand } from "../../keybindings"; import { buildKeybindingRows, + buildWhenVariableOptions, keybindingConflictLabels, keybindingFromKeyboardEvent, parseWhenExpressionDraft, shortcutToKeybindingInput, + unknownWhenVariables, whenAstToExpression, } from "./KeybindingsSettings.logic"; @@ -205,6 +207,10 @@ describe("KeybindingsSettings.logic", () => { }, }, }); + const previewOpenDraft = parseWhenExpressionDraft("previewOpen && !previewFocus"); + assert(previewOpenDraft.ok); + expect(unknownWhenVariables(previewOpenDraft.value)).toEqual([]); + expect(buildWhenVariableOptions()).toContain("previewOpen"); expect(parseWhenExpressionDraft("editorFocus &&")).toEqual({ ok: false, message: "Use variables with !, &&, ||, and parentheses.", diff --git a/apps/web/src/components/settings/KeybindingsSettings.logic.ts b/apps/web/src/components/settings/KeybindingsSettings.logic.ts index fe9b47b4dcadc..38a1ac4e763dc 100644 --- a/apps/web/src/components/settings/KeybindingsSettings.logic.ts +++ b/apps/web/src/components/settings/KeybindingsSettings.logic.ts @@ -60,6 +60,7 @@ export type KeybindingCommandOption = KeybindingCommand; const CORE_WHEN_VARIABLES = [ "terminalFocus", "terminalOpen", + "previewOpen", "isWeb", "isDesktop", "true",