From 4e8f78a42de8903e909739a0398c196aae9cbfe0 Mon Sep 17 00:00:00 2001 From: pouyarezvani Date: Wed, 4 Nov 2026 12:37:55 -0800 Subject: [PATCH 1/3] fix(web): the Fix action on a thread details PR row stays inside the card On a watched pull request whose checks show a count, the row's metadata line (number, checks count, watch icon, trailing action) is wider than the 280px thread details card. Every control on it is shrink-0 and nowrap, so the card clipped the Fix action at its right edge. The checks count control now shrinks and its label truncates, so the trailing action always stays fully visible. Closes #31113 Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/ThreadDetailsPrRow.tsx | 2 +- .../src/components/pullRequest/PullRequestChecksPopover.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx index 8c3f81442799..76028cf168a5 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx @@ -445,7 +445,7 @@ export function ThreadDetailsPrRow({ checksState={checksRollup} checks={detail.checks} variant="count" - render={} + render={} /> ) : null} {watchControl("icon")} diff --git a/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx b/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx index cfcea204a56e..c74be44c78ba 100644 --- a/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx +++ b/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx @@ -182,11 +182,11 @@ export function PullRequestChecksPopover({ {variant === "count" ? ( <> {checks !== undefined && incompleteCount > 0 ? ( - + {checks.length - incompleteCount}/{checks.length} checks ) : failedCount > 0 ? ( - {failedCount} failed + {failedCount} failed ) : null} ) : null} From 3ba7811778cda62967e945116661c170d2ec8eed Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 11 Nov 2026 04:28:13 +0000 Subject: [PATCH 2/3] fix(web): hide the checks count while the PR row action is pending AI-assisted; verified with the tests and tools listed above. --- apps/web/src/components/chat/ThreadDetailsPrRow.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx index c25cc2193357..3641246ea916 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx @@ -446,7 +446,13 @@ export function ThreadDetailsPrRow({ checksState={checksRollup} checks={detail.checks} variant="count" - render={} + render={ + span]:hidden")} + /> + } /> ) : null} {watchControl("icon")} From 45ff3c3301d7d2ee03d390be00e92c9151c01562 Mon Sep 17 00:00:00 2001 From: Yash Singh Date: Thu, 12 Nov 2026 14:07:43 -0600 Subject: [PATCH 3/3] fix(web): keep PR check counts and Fix labels readable --- .../src/components/chat/ThreadDetailsPrRow.tsx | 18 +++++++++--------- .../pullRequest/PullRequestChecksPopover.tsx | 8 ++++++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx index 3641246ea916..55a5abf07f00 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx @@ -69,6 +69,7 @@ import { AlertDialogTitle, } from "../ui/alert-dialog"; import { Button } from "../ui/button"; +import { Spinner } from "../ui/spinner"; import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip"; import { THREAD_DETAILS_PANEL_ICON_CLASS, @@ -342,10 +343,15 @@ export function ThreadDetailsPrRow({ : rowAction === "fix" ? { label: "Fix", - pendingLabel: "Preparing...", + pendingLabel: "Fix", pending: handoff === "findings", destructive: true, - suffix: , + suffix: + handoff === "findings" ? ( + + ) : ( + + ), tooltip: "Fix the failing checks in a new thread", onClick: startFixChecks, } @@ -446,13 +452,7 @@ export function ThreadDetailsPrRow({ checksState={checksRollup} checks={detail.checks} variant="count" - render={ - span]:hidden")} - /> - } + render={} /> ) : null} {watchControl("icon")} diff --git a/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx b/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx index c74be44c78ba..276dc613272d 100644 --- a/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx +++ b/apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx @@ -182,8 +182,12 @@ export function PullRequestChecksPopover({ {variant === "count" ? ( <> {checks !== undefined && incompleteCount > 0 ? ( - - {checks.length - incompleteCount}/{checks.length} checks + // Clip the second line so "checks" disappears whole when the count must shrink. + + + {checks.length - incompleteCount}/{checks.length} + {" "} + checks ) : failedCount > 0 ? ( {failedCount} failed