From 524a1eec05d614fa8ec274c804a8287e690cabed Mon Sep 17 00:00:00 2001 From: Prior <843283+prior@users.noreply.github.com> Date: Wed, 11 Nov 2026 23:04:45 -0500 Subject: [PATCH] fix(web): favorites tab shows starred models with a visible filled star --- apps/web/src/components/chat/ModelListRow.tsx | 4 +--- apps/web/src/components/chat/ModelPickerContent.tsx | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/web/src/components/chat/ModelListRow.tsx b/apps/web/src/components/chat/ModelListRow.tsx index 69da770f1f84b..95d06c7b880da 100644 --- a/apps/web/src/components/chat/ModelListRow.tsx +++ b/apps/web/src/components/chat/ModelListRow.tsx @@ -23,8 +23,6 @@ export const ModelListRow = memo(function ModelListRow(props: { acpRegistryAgentId?: string | undefined; acpRegistryIconUrl?: string | undefined; isFavorite: boolean; - /** In Favorites every row is starred, so the star shows only on hover. */ - favoriteStarOnHover?: boolean; isSelected: boolean; /** Marks this instance apart from another of the same provider. */ showInstanceBadge: boolean; @@ -121,7 +119,7 @@ export const ModelListRow = memo(function ModelListRow(props: { className={cn( "size-3.5 sm:size-3", props.isFavorite && "fill-current text-warning", - (!props.isFavorite || props.favoriteStarOnHover) && + !props.isFavorite && "opacity-0 group-hover:opacity-100 group-data-highlighted:opacity-100 in-focus-visible:opacity-100 pointer-coarse:opacity-100", )} /> diff --git a/apps/web/src/components/chat/ModelPickerContent.tsx b/apps/web/src/components/chat/ModelPickerContent.tsx index 8b4bdf0b16e4d..ce82b79523664 100644 --- a/apps/web/src/components/chat/ModelPickerContent.tsx +++ b/apps/web/src/components/chat/ModelPickerContent.tsx @@ -1054,7 +1054,6 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: { ? selectedModelKeySet.has(modelKey) : modelKey === activeModelKey } - favoriteStarOnHover={selectedInstanceId === "favorites" && !isSearching} showInstanceBadge={badgedInstanceIds.has(model.instanceId)} showNewBadge={model.badge === "new"} unavailable={model.isUnavailable === true}