Skip to content

Commit 3d06f8a

Browse files
quickbeardclaude
andcommitted
fix(app): explain the resource fields before showing them
Every other field in Add sandbox is introduced by the line above it; the CPU and memory description sat underneath, so it read as a footnote to boxes the user had already had to guess at. Moved above the pair, and the dialog now reads the same way throughout: what the field is for, then the field. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 4cedca7 commit 3d06f8a

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

‎packages/app/src/sandbox/dialog-add.tsx‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,17 @@ export function DialogAddSandbox(props: { onCreated?: (config: SandboxConfig) =>
266266
<p class="text-12 text-v2-text-text-muted">{language.t("sandbox.add.imageOk")}</p>
267267
</Show>
268268
<Show when={resourcesApply()}>
269+
{/* Both are optional and both have real defaults, which the user
270+
cannot otherwise discover — an empty box says nothing about
271+
what the sandbox will actually get. */}
272+
<p class="text-12 text-v2-text-text-muted">
273+
{language.t("sandbox.add.resourcesHint", {
274+
cpus: SANDBOX_DEFAULT_CPUS,
275+
memory: SANDBOX_DEFAULT_MEMORY_GIB,
276+
maxCpus: SANDBOX_CPUS_RANGE.max,
277+
maxMemory: SANDBOX_MEMORY_MIB_RANGE.max / 1024,
278+
})}
279+
</p>
269280
{/* Grid, not flex: the input sets its own `width: 280px` and
270281
`flex: none`, so two of them side by side overflowed the dialog
271282
rather than sharing the row. Grid tracks size them, and
@@ -288,17 +299,6 @@ export function DialogAddSandbox(props: { onCreated?: (config: SandboxConfig) =>
288299
onInput={(event) => setStore("memoryGiB", event.currentTarget.value)}
289300
/>
290301
</div>
291-
{/* Both are optional and both have real defaults, which the user
292-
cannot otherwise discover — an empty box says nothing about
293-
what the sandbox will actually get. */}
294-
<p class="text-12 text-v2-text-text-muted">
295-
{language.t("sandbox.add.resourcesHint", {
296-
cpus: SANDBOX_DEFAULT_CPUS,
297-
memory: SANDBOX_DEFAULT_MEMORY_GIB,
298-
maxCpus: SANDBOX_CPUS_RANGE.max,
299-
maxMemory: SANDBOX_MEMORY_MIB_RANGE.max / 1024,
300-
})}
301-
</p>
302302
<Show when={!resourcesValid()}>
303303
<p class="text-12 text-v2-text-text-muted">
304304
{language.t("sandbox.add.resourcesInvalid", {

0 commit comments

Comments
 (0)