Skip to content

Commit d2a3981

Browse files
quickbeardclaude
andcommitted
fix(app): show an unusable sandbox image in the danger colour
"That image is for macOS sandboxes. This computer needs the Windows/Linux image." was rendered in the muted colour, the same as the line above it that says the image is being checked and the one below that says it is fine. The one message that means the create cannot go ahead read as an aside. It now uses the v2 danger token with role="alert", matching how the other v2 dialogs report an inline validation failure. The whole message() family goes with it — wrong architecture, not an archive, not a sandbox image, unreadable — since each of them blocks the create for the same reason. One change covers both dialogs: the field is shared by DialogAddSandbox in Settings and DialogAddDefaultSandbox in Work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 88a7ab2 commit d2a3981

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎packages/app/src/sandbox/image-field.tsx‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,17 @@ export function createSandboxImageField() {
111111
<Show when={store.checking}>
112112
<p class="text-12 text-v2-text-text-muted">{language.t("sandbox.add.imageChecking")}</p>
113113
</Show>
114-
<Show when={message()}>{(text) => <p class="text-12 text-v2-text-text-muted">{text()}</p>}</Show>
114+
{/* The only line here that reports a problem, so it is the only one
115+
in the danger colour — "checking" and "this image can be used" sit
116+
beside it in the muted one. role="alert" matches how the other v2
117+
dialogs announce an inline validation failure. */}
118+
<Show when={message()}>
119+
{(text) => (
120+
<p role="alert" class="text-12 text-v2-state-fg-danger">
121+
{text()}
122+
</p>
123+
)}
124+
</Show>
115125
<Show when={store.checkedPath === store.path && store.path && !store.problem}>
116126
<p class="text-12 text-v2-text-text-muted">{language.t("sandbox.add.imageOk")}</p>
117127
</Show>

0 commit comments

Comments
 (0)