Fix implicit PHP and PHPUnit version in RequiresAnnotationWithValueToAttributeRector (#560)

* decopule RequiresAttributeFactory

* split test fixtures to be more granular and easier to extend

* prefix PHP and PHPUnit version with >= in RequiresAnnotationWithValueToAttributeRector

Author: TomasVotruba

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_extension.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @requires extension mysqli
+ * @requires extension mysqli >= 8.3.0
+ */
+final class BarController extends TestCase
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli')]
+#[\PHPUnit\Framework\Attributes\RequiresPhpExtension('mysqli', '>= 8.3.0')]
+final class BarController extends TestCase
+{
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_fixture.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class RequiresFunction extends TestCase
+{
+    /**
+     * @requires function someFunction
+     * @requires function \some\className::someMethod
+     */
+    public function testWithRequires()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class RequiresFunction extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\RequiresFunction('someFunction')]
+    #[\PHPUnit\Framework\Attributes\RequiresMethod(\some\className::class, 'someMethod')]
+    public function testWithRequires()
+    {
+    }
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_function.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @requires OS Windows
+ * @requires OSFAMILY Darwin
+ */
+class RequiresOS extends TestCase
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+#[\PHPUnit\Framework\Attributes\RequiresOperatingSystem('Windows')]
+#[\PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily('Darwin')]
+class RequiresOS extends TestCase
+{
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_os.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @requires PHP 8.0
+ */
+class RequiresPHP extends TestCase
+{
+    /**
+     * @requires PHP > 8.4
+     */
+    public function testWithRequires()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+#[\PHPUnit\Framework\Attributes\RequiresPhp('>= 8.0')]
+class RequiresPHP extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\RequiresPhp('> 8.4')]
+    public function testWithRequires()
+    {
+    }
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_php.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @requires PHPUnit >= 10
+ * @requires PHPUnit 5
+ */
+final class RequiresPHPUnit extends TestCase
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+#[\PHPUnit\Framework\Attributes\RequiresPhpunit('>= 10')]
+#[\PHPUnit\Framework\Attributes\RequiresPhpunit('>= 5')]
+final class RequiresPHPUnit extends TestCase
+{
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_phpunit.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class RequiresSetting extends TestCase
+{
+    /**
+     * @requires setting date.timezone Europe/Berlin
+     */
+    public function testWithRequires()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\Class_\RequiresAnnotationWithValueToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class RequiresSetting extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\RequiresSetting('date.timezone', 'Europe/Berlin')]
+    public function testWithRequires()
+    {
+    }
+}
+
+?>

rules-tests/AnnotationsToAttributes/Rector/Class_/RequiresAnnotationWithValueToAttributeRector/Fixture/requires_setting.php.inc

@@ -0,0 +1,78 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\AnnotationsToAttributes\NodeFactory;
+
+use PhpParser\Node\AttributeGroup;
+use Rector\PhpAttribute\NodeFactory\PhpAttributeGroupFactory;
+
+final readonly class RequiresAttributeFactory
+{
+    public function __construct(
+        private PhpAttributeGroupFactory $phpAttributeGroupFactory
+    ) {
+    }
+
+    public function create(string $annotationValue): ?AttributeGroup
+    {
+        $annotationValues = explode(' ', $annotationValue, 2);
+
+        $type = array_shift($annotationValues);
+        $attributeValue = array_shift($annotationValues);
+
+        switch ($type) {
+            case 'PHP':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresPhp';
+
+                // only version is used, we need to prefix with >=
+                if (is_string($attributeValue) && is_numeric($attributeValue[0])) {
+                    $attributeValue = '>= ' . $attributeValue;
+                }
+
+                $attributeValue = [$attributeValue];
+                break;
+            case 'PHPUnit':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresPhpunit';
+
+                // only version is used, we need to prefix with >=
+                if (is_string($attributeValue) && is_numeric($attributeValue[0])) {
+                    $attributeValue = '>= ' . $attributeValue;
+                }
+
+                $attributeValue = [$attributeValue];
+                break;
+            case 'OS':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresOperatingSystem';
+                $attributeValue = [$attributeValue];
+                break;
+            case 'OSFAMILY':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily';
+                $attributeValue = [$attributeValue];
+                break;
+            case 'function':
+                if (str_contains((string) $attributeValue, '::')) {
+                    $attributeClass = 'PHPUnit\Framework\Attributes\RequiresMethod';
+                    $attributeValue = explode('::', (string) $attributeValue);
+                    $attributeValue[0] .= '::class';
+                } else {
+                    $attributeClass = 'PHPUnit\Framework\Attributes\RequiresFunction';
+                    $attributeValue = [$attributeValue];
+                }
+
+                break;
+            case 'extension':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresPhpExtension';
+                $attributeValue = explode(' ', (string) $attributeValue, 2);
+                break;
+            case 'setting':
+                $attributeClass = 'PHPUnit\Framework\Attributes\RequiresSetting';
+                $attributeValue = explode(' ', (string) $attributeValue, 2);
+                break;
+            default:
+                return null;
+        }
+
+        return $this->phpAttributeGroupFactory->createFromClassWithItems($attributeClass, [...$attributeValue]);
+    }
+}