From be8a2828fe55f17433289a9c843576aa9d6b807e Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Tue, 27 Oct 2026 22:03:29 +0100
Subject: [PATCH] [Php71] Skip array dim fetch in
 BinaryOpBetweenNumberAndStringRector, element number type is phpdoc-only

---
 .../Fixture/skip_array_dim_fetch_phpdoc.php.inc   | 15 +++++++++++++++
 .../BinaryOpBetweenNumberAndStringRector.php      |  6 ++++++
 2 files changed, 21 insertions(+)
 create mode 100644 rules-tests/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/skip_array_dim_fetch_phpdoc.php.inc

diff --git a/rules-tests/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/skip_array_dim_fetch_phpdoc.php.inc b/rules-tests/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/skip_array_dim_fetch_phpdoc.php.inc
new file mode 100644
index 00000000000..0e8d277097e
--- /dev/null
+++ b/rules-tests/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector/Fixture/skip_array_dim_fetch_phpdoc.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector\Fixture;
+
+class SkipArrayDimFetchPhpdoc
+{
+    /**
+     * @param array{adaid?: int} $where
+     */
+    public function run(array $where): void
+    {
+        if (array_key_exists('adaid', $where) && $where['adaid'] != '') {
+        }
+    }
+}
diff --git a/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php b/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php
index 877ae8a45a4..f384b8c9f56 100644
--- a/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php
+++ b/rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php
@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BinaryOp;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
 use PhpParser\Node\Expr\BinaryOp\Concat;
@@ -91,6 +92,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // array element number type only comes from phpdoc array shape, never a runtime guarantee
+        if ($node->left instanceof ArrayDimFetch || $node->right instanceof ArrayDimFetch) {
+            return null;
+        }
+
         if ($this->exprAnalyzer->isNonTypedFromParam($node->left)) {
             return null;
         }