From 737930a02b18d06ffb3557fdf294a8161e1c9d14 Mon Sep 17 00:00:00 2001 From: Adam Gemmell Date: Mon, 19 Oct 2026 15:38:49 +0000 Subject: [PATCH 1/4] Apply reversible compiler driver flag for a53 mitigation when required --- compiler/rustc_codegen_ssa/src/back/link.rs | 8 +++++++- .../src/spec/targets/aarch64_unknown_linux_gnu.rs | 8 +------- .../src/spec/targets/aarch64_unknown_linux_musl.rs | 8 +------- tests/run-make/a53-mitigation/empty.rs | 1 + tests/run-make/a53-mitigation/rmake.rs | 12 ++++++++++++ 5 files changed, 22 insertions(+), 15 deletions(-) create mode 100644 tests/run-make/a53-mitigation/empty.rs create mode 100644 tests/run-make/a53-mitigation/rmake.rs diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index 622ac2a905d70..8c5ab04f16a45 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -44,7 +44,7 @@ use rustc_span::{Symbol, bug}; use rustc_structures::{CrateType, NativeLibKind}; use rustc_target::spec::crt_objects::CrtObjects; use rustc_target::spec::{ - BinaryFormat, Cc, CfgAbi, Env, LinkOutputKind, LinkSelfContainedComponents, + Arch, BinaryFormat, Cc, CfgAbi, Env, LinkOutputKind, LinkSelfContainedComponents, LinkSelfContainedDefault, LinkerFeatures, LinkerFlavor, LinkerFlavorCli, Lld, Os, RelocModel, RelroLevel, SanitizerSet, SplitDebuginfo, }; @@ -2405,6 +2405,12 @@ fn add_post_link_objects( /// Add arbitrary "pre-link" args defined by the target spec or from command line. /// FIXME: Determine where exactly these args need to be inserted. fn add_pre_link_args(cmd: &mut dyn Linker, sess: &Session, flavor: LinkerFlavor) { + // Emit the CC flag for the A53 mitigation early, as later linker args can override it if + // required with `-mno-fix-cortex-a53-843419` + if sess.target.arch == Arch::AArch64 && matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, ..)) { + cmd.cc_arg("-mfix-cortex-a53-843419"); + } + if let Some(args) = sess.target.pre_link_args.get(&flavor) { cmd.verbatim_args(args.iter().map(Deref::deref)); } diff --git a/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_gnu.rs b/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_gnu.rs index a4a5ee6f2c9ca..f7e1cbfac2635 100644 --- a/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_gnu.rs +++ b/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_gnu.rs @@ -1,6 +1,5 @@ use crate::spec::{ - Arch, Cc, FramePointer, LinkerFlavor, Lld, SanitizerSet, StackProbeType, Target, - TargetMetadata, TargetOptions, base, + Arch, FramePointer, SanitizerSet, StackProbeType, Target, TargetMetadata, TargetOptions, base, }; pub(crate) fn target() -> Target { @@ -16,11 +15,6 @@ pub(crate) fn target() -> Target { data_layout: "e-m:e-p270:32:32-p271:32:32-p272:64:64-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128-Fn32".into(), arch: Arch::AArch64, options: TargetOptions { - // Enable the Cortex-A53 errata 843419 mitigation by default - pre_link_args: TargetOptions::link_args( - LinkerFlavor::Gnu(Cc::Yes, Lld::No), - &["-Wl,--fix-cortex-a53-843419"], - ), features: "+v8a,+outline-atomics".into(), // the AAPCS64 expects use of non-leaf frame pointers per // https://github.com/ARM-software/abi-aa/blob/4492d1570eb70c8fd146623e0db65b2d241f12e7/aapcs64/aapcs64.rst#the-frame-pointer diff --git a/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_musl.rs b/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_musl.rs index 93319d23bf077..6ba5112342c3e 100644 --- a/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_musl.rs +++ b/compiler/rustc_target/src/spec/targets/aarch64_unknown_linux_musl.rs @@ -1,6 +1,5 @@ use crate::spec::{ - Arch, Cc, FramePointer, LinkerFlavor, Lld, SanitizerSet, StackProbeType, Target, - TargetMetadata, TargetOptions, base, + Arch, FramePointer, SanitizerSet, StackProbeType, Target, TargetMetadata, TargetOptions, base, }; pub(crate) fn target() -> Target { @@ -30,11 +29,6 @@ pub(crate) fn target() -> Target { data_layout: "e-m:e-p270:32:32-p271:32:32-p272:64:64-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128-Fn32".into(), arch: Arch::AArch64, options: TargetOptions { - // Enable the Cortex-A53 errata 843419 mitigation by default - pre_link_args: TargetOptions::link_args( - LinkerFlavor::Gnu(Cc::Yes, Lld::No), - &["-Wl,--fix-cortex-a53-843419"], - ), // the AAPCS64 expects use of non-leaf frame pointers per // https://github.com/ARM-software/abi-aa/blob/4492d1570eb70c8fd146623e0db65b2d241f12e7/aapcs64/aapcs64.rst#the-frame-pointer // and we tend to encounter interesting bugs in AArch64 unwinding code if we do not diff --git a/tests/run-make/a53-mitigation/empty.rs b/tests/run-make/a53-mitigation/empty.rs new file mode 100644 index 0000000000000..f328e4d9d04c3 --- /dev/null +++ b/tests/run-make/a53-mitigation/empty.rs @@ -0,0 +1 @@ +fn main() {} diff --git a/tests/run-make/a53-mitigation/rmake.rs b/tests/run-make/a53-mitigation/rmake.rs new file mode 100644 index 0000000000000..19353abbaaa0b --- /dev/null +++ b/tests/run-make/a53-mitigation/rmake.rs @@ -0,0 +1,12 @@ +//@ only-aarch64-unknown-linux-gnu +//@ needs-target-std + +use run_make_support::rustc; + +fn main() { + rustc() + .input("empty.rs") + .print("link-args") + .run_unchecked() + .assert_stdout_contains("-mfix-cortex-a53-843419"); +} From d28c7503b3c26ee2a267397c0efdfc5f00ca89d6 Mon Sep 17 00:00:00 2001 From: Adam Gemmell Date: Wed, 21 Oct 2026 16:39:34 +0100 Subject: [PATCH 2/4] Retry linking if the linker doesn't support the A53 mitigation --- compiler/rustc_codegen_ssa/src/back/link.rs | 22 +++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index 8c5ab04f16a45..e03e8099d5e3d 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -1349,6 +1349,28 @@ fn link_natively( continue; } + // Check if linking failed with an error message that the linker doesn't recognise the + // cortex-a53 mitigation. We pass `-mfix-cortex-a53-843419` to CC-based linker drivers, + // which forward `--fix-cortex-a53-843419` to the linker itself, but either component may + // not recognise each flag. Notably this was only added to Clang in version 21. + if matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, _)) + && unknown_arg_regex.is_match(&out) + && out.contains("fix-cortex-a53-843419") + && cmd.get_args().iter().any(|e| e.to_string_lossy() == "-mfix-cortex-a53-843419") + { + info!("linker output: {:?}", out); + info!( + "The linker or linker driver do not support `fix-cortex-a53-843419`. Retrying without it." + ); + for arg in cmd.take_args() { + if arg.to_string_lossy() != "-mfix-cortex-a53-843419" { + cmd.arg(arg); + } + } + info!("{cmd:?}"); + continue; + } + // Detect '-static-pie' used with an older version of gcc or clang not supporting it, // or with glibc that's missing crt objects, e.g. for arches that don't support it. // Fallback from '-static-pie' to '-static' in either case. From 0a217f2d251ef0dba4e87134d9f7bfeefde20e10 Mon Sep 17 00:00:00 2001 From: Adam Gemmell Date: Fri, 23 Oct 2026 12:20:57 +0100 Subject: [PATCH 3/4] Omit the mitigation on Apple and Windows targets --- compiler/rustc_codegen_ssa/src/back/link.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index e03e8099d5e3d..eda6198e734bc 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -2429,7 +2429,11 @@ fn add_post_link_objects( fn add_pre_link_args(cmd: &mut dyn Linker, sess: &Session, flavor: LinkerFlavor) { // Emit the CC flag for the A53 mitigation early, as later linker args can override it if // required with `-mno-fix-cortex-a53-843419` - if sess.target.arch == Arch::AArch64 && matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, ..)) { + if sess.target.arch == Arch::AArch64 + && !sess.target.is_like_darwin + && sess.target.os != Os::Windows + && matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, ..)) + { cmd.cc_arg("-mfix-cortex-a53-843419"); } From 8274e7a4f5bd0ff6da148ae708bb8164fdeaf64b Mon Sep 17 00:00:00 2001 From: Adam Gemmell Date: Fri, 23 Oct 2026 12:36:09 +0100 Subject: [PATCH 4/4] Remove unnecessary calls to to_string_lossy() --- compiler/rustc_codegen_ssa/src/back/link.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index eda6198e734bc..06d9a377b58bf 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -1336,12 +1336,12 @@ fn link_natively( if matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, Lld::Yes)) && unknown_arg_regex.is_match(&out) && out.contains("-fuse-ld=lld") - && cmd.get_args().iter().any(|e| e.to_string_lossy() == "-fuse-ld=lld") + && cmd.get_args().iter().any(|e| e == "-fuse-ld=lld") { info!("linker output: {:?}", out); info!("The linker driver does not support `-fuse-ld=lld`. Retrying without it."); for arg in cmd.take_args() { - if arg.to_string_lossy() != "-fuse-ld=lld" { + if arg != "-fuse-ld=lld" { cmd.arg(arg); } } @@ -1356,14 +1356,14 @@ fn link_natively( if matches!(flavor, LinkerFlavor::Gnu(Cc::Yes, _)) && unknown_arg_regex.is_match(&out) && out.contains("fix-cortex-a53-843419") - && cmd.get_args().iter().any(|e| e.to_string_lossy() == "-mfix-cortex-a53-843419") + && cmd.get_args().iter().any(|e| e == "-mfix-cortex-a53-843419") { info!("linker output: {:?}", out); info!( "The linker or linker driver do not support `fix-cortex-a53-843419`. Retrying without it." ); for arg in cmd.take_args() { - if arg.to_string_lossy() != "-mfix-cortex-a53-843419" { + if arg != "-mfix-cortex-a53-843419" { cmd.arg(arg); } }