From d24f6a8781ec8f849930137e938e0e407471e1a9 Mon Sep 17 00:00:00 2001 From: samuelho-dev Date: Sat, 26 Sep 2026 18:24:30 +0000 Subject: [PATCH] fix(terraform): delete object-store plans correctly (CTK-835) The AWS CLI s3 rm command does not accept --no-progress, so post-apply Garage cleanup failed after both successful and failed applies. Remove the unsupported flag while retaining warning-only cleanup behavior. Verified with actionlint and git diff --check. References CTK-835 --- .github/workflows/terraform-apply.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/terraform-apply.yml b/.github/workflows/terraform-apply.yml index 5243af4..0014d0c 100644 --- a/.github/workflows/terraform-apply.yml +++ b/.github/workflows/terraform-apply.yml @@ -182,11 +182,11 @@ jobs: PLAN_KEY: ${{ inputs.plan-storage-key }} run: | if ! env -u AWS_SESSION_TOKEN aws --endpoint-url "$PLAN_ENDPOINT" --region garage \ - s3 rm "s3://$PLAN_BUCKET/$PLAN_KEY" --no-progress; then + s3 rm "s3://$PLAN_BUCKET/$PLAN_KEY"; then echo "::warning::failed to delete object-store plan archive" fi if ! env -u AWS_SESSION_TOKEN aws --endpoint-url "$PLAN_ENDPOINT" --region garage \ - s3 rm "s3://$PLAN_BUCKET/$PLAN_KEY.sha256" --no-progress; then + s3 rm "s3://$PLAN_BUCKET/$PLAN_KEY.sha256"; then echo "::warning::failed to delete object-store plan archive checksum" fi