From 725e04905a2dc0f2e272f01eebf989493a2baf27 Mon Sep 17 00:00:00 2001 From: Waleed Latif Date: Wed, 4 Nov 2026 13:25:23 -0800 Subject: [PATCH] fix(ci): distinguish handled search redirects from runtime errors --- .../scripts/test-organization-search-e2e.ts | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/apps/sim/scripts/test-organization-search-e2e.ts b/apps/sim/scripts/test-organization-search-e2e.ts index 99627f66c2f..a4a6b7bbe53 100644 --- a/apps/sim/scripts/test-organization-search-e2e.ts +++ b/apps/sim/scripts/test-organization-search-e2e.ts @@ -1025,7 +1025,18 @@ try { verifyLegacyDraft(undefined, 'assistant') ) await check('The UI completes without unexpected browser runtime errors', async () => { - await expect.poll(() => browserErrorEventCount).toBe(browserErrorCount) + const handledRedirectCount = () => + browserErrorEvents.reduce( + (count, event) => + event.stage === 'Search URLs cannot change an agent conversation into an assistant' && + event.url === `${baseUrl.origin}${root}/search/chat/${agentId}` && + event.digest === `NEXT_REDIRECT;replace;${root}/chat/${agentId};307;` && + event.message.startsWith('Minified React error #419;') + ? count + event.count + : count, + 0 + ) + await expect.poll(() => browserErrorEventCount - handledRedirectCount()).toBe(browserErrorCount) const deniedRecoveries = browserErrorEvents.filter( (event) => event.digest === 'NEXT_HTTP_ERROR_FALLBACK;404' && @@ -1036,7 +1047,11 @@ try { ].includes(event.stage) ) const recoveryCount = deniedRecoveries.reduce((total, event) => total + event.count, 0) - assert.equal(browserErrorEventCount, recoveryCount, 'Unexpected browser error events') + assert.equal( + browserErrorEventCount, + recoveryCount + handledRedirectCount(), + 'Unexpected browser error events' + ) assert.equal(browserErrorCount, recoveryCount, 'Unexpected browser runtime errors') for (const sample of browserErrorSamples) { const matchedCount = deniedRecoveries